All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH 1/1] riscv: allow building w/o DHCP, SCSI, VIRTIO
Date: Mon, 4 Jul 2022 17:50:04 +0800	[thread overview]
Message-ID: <CAEUhbmXk1-b=EJRLnGfi5TrQ1zDtOH=opta-0yL_QOgxQ_yxMw@mail.gmail.com> (raw)
In-Reply-To: <20220703112837.98207-1-heinrich.schuchardt@canonical.com>

On Sun, Jul 3, 2022 at 7:28 PM Heinrich Schuchardt
<heinrich.schuchardt@canonical.com> wrote:
>
> Consider which boot devices are enabled in the definition of the
> BOOT_TARGET_DEVICES() macro.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  include/configs/qemu-riscv.h | 25 ++++++++++++++++++++++---
>  1 file changed, 22 insertions(+), 3 deletions(-)
>
> diff --git a/include/configs/qemu-riscv.h b/include/configs/qemu-riscv.h
> index f462895fb5..427da69d3f 100644
> --- a/include/configs/qemu-riscv.h
> +++ b/include/configs/qemu-riscv.h
> @@ -33,11 +33,30 @@
>  /* Environment options */
>
>  #ifndef CONFIG_SPL_BUILD
> +
> +#if defined(CONFIG_CMD_DHCP)
> +#define BOOT_TARGET_DEVICES_DHCP(func) func(DHCP, dhcp, na)
> +#else
> +#define BOOT_TARGET_DEVICES_DHCP(func)
> +#endif
> +
> +#if defined(CONFIG_SCSI)

For consistency, maybe CONFIG_CMD_SCSI?

> +# define BOOT_TARGET_DEVICES_SCSI(func) func(SCSI, scsi, 0)
> +#else
> +# define BOOT_TARGET_DEVICES_SCSI(func)
> +#endif
> +
> +#if defined(CONFIG_CMD_VIRTIO)
> +# define BOOT_TARGET_DEVICES_VIRTIO(func) func(VIRTIO, virtio, 0)
> +#else
> +# define BOOT_TARGET_DEVICES_VIRTIO(func)
> +#endif
> +
>  #define BOOT_TARGET_DEVICES(func) \
>         func(QEMU, qemu, na) \
> -       func(VIRTIO, virtio, 0) \
> -       func(SCSI, scsi, 0) \
> -       func(DHCP, dhcp, na)
> +       BOOT_TARGET_DEVICES_VIRTIO(func) \
> +       BOOT_TARGET_DEVICES_SCSI(func) \
> +       BOOT_TARGET_DEVICES_DHCP(func)
>
>  #include <config_distro_bootcmd.h>
>

Regards,
Bin

  parent reply	other threads:[~2022-07-04  9:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-03 11:28 [PATCH 1/1] riscv: allow building w/o DHCP, SCSI, VIRTIO Heinrich Schuchardt
2022-07-03 12:09 ` Heinrich Schuchardt
2022-07-04  9:55   ` Bin Meng
2022-07-04 11:02     ` Heinrich Schuchardt
2022-07-04  9:50 ` Bin Meng [this message]
2022-07-04 10:07   ` Heinrich Schuchardt
2022-07-04 10:16     ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEUhbmXk1-b=EJRLnGfi5TrQ1zDtOH=opta-0yL_QOgxQ_yxMw@mail.gmail.com' \
    --to=bmeng.cn@gmail.com \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.