From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75386C4338F for ; Mon, 2 Aug 2021 02:51:25 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DBC9661057 for ; Mon, 2 Aug 2021 02:51:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DBC9661057 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3536B8337D; Mon, 2 Aug 2021 04:51:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ocplXZ18"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4BD1B83380; Mon, 2 Aug 2021 04:51:03 +0200 (CEST) Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5CDC783383 for ; Mon, 2 Aug 2021 04:50:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bmeng.cn@gmail.com Received: by mail-yb1-xb35.google.com with SMTP id d73so1376075ybc.10 for ; Sun, 01 Aug 2021 19:50:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l+qBSy5INq4YZBXUyCssOHBRGVqFblVvYrLQ+3GEIxk=; b=ocplXZ18ievXwnrLGGrfJMvSkMoKOGLCRkprItvZniUwwsoiVqMl2MyXRkiY5bInL+ YeiT9HCBaNkbSLnGJTBMPeNIlPQ3NX+UNeGREGsglr7RKZR4XzUnZCSJ+6sZtCb9yE9H cWjsN4CHSMiH8pAziv4N76xk02ZsCYFapLGH2lWvEk82/rCH5IP85sHB78frWqal29Nw YbOUDwjIE6NW5VRwAIEs0T5N7g8Yh53HeKt/8S7joQZMGVkmDeoZl0a23b1/0tXY/6Y/ KiFq8XehxUyBGEvOtnLsUpV3h6Vkj2jIYd/Msq7HOx4ANCpzPtpAQBf256f6PC9ap2AG lkBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l+qBSy5INq4YZBXUyCssOHBRGVqFblVvYrLQ+3GEIxk=; b=BxWU0lYE7jV197fRJkVqyKHLSnBWVtzehLzuYvOb1g1c+THCEo9aI4VwV2Za3SC3pF 5mhHT184wsFZkQS3CMXTwripgOC74gtsZ847zOC+C/TZwPrFW0Ay79xysaZfW06viI+c 1wVdEZlNv4/iZhHxygwX5AreR26acpsvPNGdR2UL8lHl5gz3Zvmjz48tIljo6VS7bZnJ dy6ut39CruuqTOLGS4KXR9McSC0ocn/89dHcCe1Brq4aemQVkj//qQWAdQFtLvgnPtxB u9wj2km2eYv+ogQRlDY9J6m64zaHP0xKJsYECd6lFy9aVLIn1EH/yIw/LX/KxNFkPbgm hc8g== X-Gm-Message-State: AOAM532/6oApyQLnOI5myprVrY356uM6TNomxk4rsTWF4z5dI0vGqMaF BSKelEfF+ruM5XhukAigMbzmH7pA5BAzPjEhiBs= X-Google-Smtp-Source: ABdhPJzeW+jb8UshyUIEATbWbTFe6KO4KpzScMK4iyLYBxAUOrc1tN0uruWKP3DQT9cMR+autPW1nluYYIRh8WvRVmk= X-Received: by 2002:a25:cc0c:: with SMTP id l12mr19166270ybf.152.1627872657221; Sun, 01 Aug 2021 19:50:57 -0700 (PDT) MIME-Version: 1.0 References: <20210731084529.7524-1-bmeng.cn@gmail.com> <20210731084529.7524-6-bmeng.cn@gmail.com> In-Reply-To: From: Bin Meng Date: Mon, 2 Aug 2021 10:50:45 +0800 Message-ID: Subject: Re: [PATCH 5/7] x86: cmd: hob: Fix the command usage and help messages To: Simon Glass Cc: U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Mon, Aug 2, 2021 at 3:19 AM Simon Glass wrote: > > On Sat, 31 Jul 2021 at 02:45, Bin Meng wrote: > > > > At present the hob command usage and help messages are messed up > > in a single line. They should be separated. > > > > This was a regression introduced when [seq] and [-v] were added > > to the command. > > > > Fixes: d11544dfa9f4 ("x86: hob: Add way to show a single hob entry") > > Fixes: 51af144eb7a0 ("x86: Allow showing details about a HOB entry") > > Signed-off-by: Bin Meng > > --- > > > > cmd/x86/hob.c | 7 +++---- > > 1 file changed, 3 insertions(+), 4 deletions(-) > > Reviewed-by: Simon Glass > Tested on chromebook_coral, chromebook_samus, chromebook_link, minnowmax > Tested-by: Simon Glass applied to u-boot-x86, thanks!