All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/5] tools: buildman: Remove useless mkdir() in Make() in test.py
Date: Tue, 29 Oct 2019 21:56:16 +0800	[thread overview]
Message-ID: <CAEUhbmXz3uMdcqMKHUPsXFdpZOWi-1FMfAH=BNHaD=mTi_YJgQ@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ3ZiFJ4Et8vbRfnpL1Fyy+QT6PkstyWXj8TuS-rsen1Tw@mail.gmail.com>

Hi Simon,

On Tue, Oct 29, 2019 at 11:37 AM Simon Glass <sjg@chromium.org> wrote:
>
> Hi Bin,
>
> On Mon, 28 Oct 2019 at 08:25, Bin Meng <bmeng.cn@gmail.com> wrote:
> >
> > In the 'Make' function, the codes tries to create a directory
> > if current stage is 'build'. But the directory isn't used at
> > all anywhere.
> >
> > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> >
> > ---
> >
> > Changes in v2:
> > - remove the unneeded debug codes
> >
> >  tools/buildman/test.py | 8 --------
> >  1 file changed, 8 deletions(-)
>
> Can you check this works OK when there is no output dir at all? E.g.
>
> -o /path/to/a/deep/non-existent/dir

If I understand the codes correctly the "O=<path>" in args[] does not
come from "-o /path/to/a/deep/non-existent/dir" but from the
builderthread with some hardcoded values. The removed codes here seem
to do something not very useful.

>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Regards,
Bin

  reply	other threads:[~2019-10-29 13:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28 14:24 [U-Boot] [PATCH v2 0/5] Bring all testings in gitlab and travis CI to Azure Pipelines Bin Meng
2019-10-28 14:24 ` [U-Boot] [PATCH v2 1/5] tools: buildman: Honor output directory when generating boards.cfg Bin Meng
2019-10-29  3:32   ` Simon Glass
2019-10-29  7:11     ` Bin Meng
2019-10-30 17:03   ` Tom Rini
2019-10-28 14:25 ` [U-Boot] [PATCH v2 2/5] tools: buildman: Remove useless mkdir() in Make() in test.py Bin Meng
2019-10-29  3:37   ` Simon Glass
2019-10-29 13:56     ` Bin Meng [this message]
2019-10-30  0:03       ` Simon Glass
2019-10-30 17:03   ` Tom Rini
2019-10-28 14:25 ` [U-Boot] [PATCH v2 3/5] arm: mvebu: Avoid generating kwbimage.cfg in the source tree Bin Meng
2019-10-29  3:37   ` Simon Glass
2019-10-30 17:03   ` Tom Rini
2019-10-28 14:25 ` [U-Boot] [PATCH v2 4/5] .travis.yml: Remove the unneeded '&' for ls20xx buildman Bin Meng
2019-10-29  3:37   ` Simon Glass
2019-10-30 17:03   ` Tom Rini
2019-10-28 14:25 ` [U-Boot] [PATCH v2 5/5] Bring all testings in gitlab and travis CI to Azure Pipelines Bin Meng
2019-10-30 17:03   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEUhbmXz3uMdcqMKHUPsXFdpZOWi-1FMfAH=BNHaD=mTi_YJgQ@mail.gmail.com' \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.