From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <5487A355.6030704@broadcom.com> References: <1418172891-19441-1-git-send-email-rjui@broadcom.com> <1418172891-19441-2-git-send-email-rjui@broadcom.com> <5487A16C.5000707@gmail.com> <5487A355.6030704@broadcom.com> Date: Wed, 10 Dec 2014 08:42:55 +0530 Message-ID: Subject: Re: [PATCH 1/4] i2c: iProc: define Broadcom iProc I2C binding From: Varka Bhadram Content-Type: multipart/alternative; boundary=089e014940462d7f6e0509d409a2 To: Ray Jui Cc: Wolfram Sang , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Grant Likely , Christian Daudt , Matt Porter , Florian Fainelli , Russell King , Scott Branden , "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , bcm-kernel-feedback-list@broadcom.com, "devicetree@vger.kernel.org" List-ID: --089e014940462d7f6e0509d409a2 Content-Type: text/plain; charset=UTF-8 On Wed, Dec 10, 2014 at 7:05 AM, Ray Jui wrote: > > > On 12/9/2014 5:27 PM, Varka Bhadram wrote: > >> Hi, >> >> On Wednesday 10 December 2014 06:24 AM, Ray Jui wrote: >> >>> Document the I2C device tree binding for Broadcom iProc family of >>> SoCs >>> >>> Signed-off-by: Ray Jui >>> Reviewed-by: Scott Branden >>> --- >>> .../devicetree/bindings/i2c/brcm,iproc-i2c.txt | 37 >>> ++++++++++++++++++++ >>> 1 file changed, 37 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt >>> >>> diff --git a/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt >>> b/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt >>> new file mode 100644 >>> index 0000000..81f982c >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt >>> @@ -0,0 +1,37 @@ >>> +Broadcom iProc I2C controller >>> + >>> +Required properties: >>> + >>> +- compatible: >>> + Must be "brcm,iproc-i2c" >>> + >>> +- reg: >>> + Define the base and range of the I/O address space that contain >>> the iProc >>> + I2C controller registers >>> + >>> +- interrupts: >>> + Should contain the I2C interrupt >>> + >>> +- clock-frequency: >>> + This is the I2C bus clock. Need to be either 100000 or 400000 >>> + >>> +- #address-cells: >>> + Always 1 (for I2C addresses) >>> + >>> +- #size-cells: >>> + Always 0 >>> + >>> >> >> All the properties defined with two lines of statements. >> >> Why cant they be with single line statement, like: >> >> compatible: Must be "brcm,iproc-i2c" >> reg: Define the base and range of the I/O address space that >> contain the iProc I2C controller registers >> >> .... >> >> >> I thought making them two lines are more readable (and obviously that's > very subjective, :)). But more importantly, it matches the format of other > Broadcom iProc/Cygnus devicetree binding documents that are currently in > progress of upstreaming. > But max of the bindings over the kernel follows single line statements. -- Thanks and Regards, Varka Bhadram. --089e014940462d7f6e0509d409a2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On Wed, Dec 10, 2014 at 7:05 AM, Ray Jui <rjui@broadcom.com> wrote:

On 12/9/2014 5:27 PM, Varka Bhadram wrote:

Hi,

On Wednesday 10 December 2014 06:24 AM, Ray Jui wrote:

Document the I2C device tree binding for Broadcom iProc family of
SoCs

Signed-off-by: Ray Jui <rjui@broadcom.com>
Reviewed-by: Scott Branden <sbranden@broadcom.com>
---
=C2=A0 .../devicetree/bindings/i2c/brcm,iproc-i2c.txt=C2=A0 =C2=A0 = =C2=A0|=C2=A0 =C2=A037
++++++++++++++++++++
=C2=A0 1 file changed, 37 insertions(+)
=C2=A0 create mode 100644
Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt

diff --git a/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt
b/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt new file mode 100644
index 0000000..81f982c
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.tx= t
@@ -0,0 +1,37 @@
+Broadcom iProc I2C controller
+
+Required properties:
+
+- compatible:
+=C2=A0 =C2=A0 Must be "brcm,iproc-i2c"
+
+- reg:
+=C2=A0 =C2=A0 Define the base and range of the I/O address space that cont= ain
the iProc
+=C2=A0 =C2=A0 I2C controller registers
+
+- interrupts:
+=C2=A0 =C2=A0 Should contain the I2C interrupt
+
+- clock-frequency:
+=C2=A0 =C2=A0 This is the I2C bus clock. Need to be either 100000 or 40000= 0
+
+- #address-cells:
+=C2=A0 =C2=A0 Always 1 (for I2C addresses)
+
+- #size-cells:
+=C2=A0 =C2=A0 Always 0
+

All the properties defined with two lines of statements.

Why cant they be with single line statement, like:

compatible:=C2=A0 =C2=A0 Must be "brcm,iproc-i2c"
reg:=C2=A0 =C2=A0 =C2=A0 =C2=A0 Define the base and range of the I/O addres= s space that
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0contain the iProc I2C controller register= s

....

I thought making them two lines are more readable (and obviously that's= very subjective, :)). But more importantly, it matches the format of other= Broadcom iProc/Cygnus devicetree binding documents that are currently in p= rogress of upstreaming.

But max of the bindings over the kernel follows single line statement= s.

--

Thanks and Regards,
Varka Bhadram.

--089e014940462d7f6e0509d409a2--