From: Xiongwei Song <sxwjean@gmail.com>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: Matthew Wilcox <willy@infradead.org>,
Zheng Liang <zhengliang6@huawei.com>,
Phillip Lougher <phillip@squashfs.org.uk>,
Zhang Yi <yi.zhang@huawei.com>, Hou Tao <houtao1@huawei.com>,
Miao Xie <miaoxie@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Song, Xiongwei" <Xiongwei.Song@windriver.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"squashfs-devel@lists.sourceforge.net"
<squashfs-devel@lists.sourceforge.net>
Subject: Re: squashfs performance regression and readahea
Date: Tue, 10 May 2022 21:18:44 +0800 [thread overview]
Message-ID: <CAEVVKH9SuUFoR8SGP0tcB1fohW3nWRCVmSro_iDUVEV0NS2VqQ@mail.gmail.com> (raw)
In-Reply-To: <CAJMQK-jgNPvO+8xZph-MPs57DjDrVvhduxvHbtR_Hwd7+kZc-A@mail.gmail.com>
On Tue, May 10, 2022 at 8:47 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
>
> On Tue, May 10, 2022 at 8:31 PM Xiongwei Song <sxwjean@gmail.com> wrote:
> >
> > Hi Hsin-Yi,
> >
> > On Mon, May 9, 2022 at 10:29 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
> > >
> > > On Mon, May 9, 2022 at 9:21 PM Matthew Wilcox <willy@infradead.org> wrote:
> > > >
> > > > On Mon, May 09, 2022 at 08:43:45PM +0800, Xiongwei Song wrote:
> > > > > Hi Hsin-Yi and Matthew,
> > > > >
> > > > > With the patch from the attachment on linux 5.10, ran the command as I
> > > > > mentioned earlier,
> > > > > got the results below:
> > > > > 1:40.65 (1m + 40.65s)
> > > > > 1:10.12
> > > > > 1:11.10
> > > > > 1:11.47
> > > > > 1:11.59
> > > > > 1:11.94
> > > > > 1:11.86
> > > > > 1:12.04
> > > > > 1:12.21
> > > > > 1:12.06
> > > > >
> > > > > The performance has improved obviously, but compared to linux 4.18, the
> > > > > performance is not so good.
> > > > >
> > > I think you shouldn't compare the performance with 4.18 directly,
> > > since there might be other factors that impact the performance.
> >
> > Make sense.
> >
> > >I'd suggest comparing the same kernel version with:
> > > a) with this patch
> > > b) with c1f6925e1091 ("mm: put readahead pages in cache earlier") reverted.
> >
> > With 9eec1d897139 ("squashfs: provide backing_dev_info in order to disable
> > read-ahead") reverted and applied 0001-WIP-squashfs-implement-readahead.patch,
> > test result on linux 5.18:
> > 1:41.51 (1m + 41.51s)
> > 1:08.11
> > 1:10.37
> > 1:11.17
> > 1:11.32
> > 1:11.59
> > 1:12.23
> > 1:12.08
> > 1:12.76
> > 1:12.51
> >
> > performance worse 1 ~ 2s than linux 5.18 vanilla.
> >
>
> Can you share the pack file you used for testing? Thanks
You are saying the files that are put in squashfs partitions? If yes, I can tell
I just put some dynamic libraries in partitions:
-rwxr-xr-x 1 root root 200680 Apr 20 03:57 ld-2.33.so
lrwxrwxrwx 1 root root 10 Apr 20 03:57 ld-linux-x86-64.so.2 -> ld-2.33.so
-rwxr-xr-x 1 root root 18776 Apr 20 03:57 libanl-2.33.so
lrwxrwxrwx 1 root root 14 Apr 20 03:57 libanl.so.1 -> libanl-2.33.so
lrwxrwxrwx 1 root root 17 Apr 20 04:08 libblkid.so.1 -> libblkid.so.1.1.0
-rwxr-xr-x 1 root root 330776 Apr 20 04:08 libblkid.so.1.1.0
-rwxr-xr-x 1 root root 1823192 Apr 20 03:57 libc-2.33.so
...... snip ......
The number of files is 110(55 libs + 55 soft links to libs). I have 90 squashfs
partitions which save the identical files. The space of each partition is 11M,
nothing special.
Thanks.
> > >
> > > According to https://lore.kernel.org/linux-mm/Ynfzh2ifG85MZEoN@casper.infradead.org/t/
> > > It seems to be a 3 sec difference?
> >
> > 5 ~ 6s difference.
> >
> > Regards,
> > Xiongwei
> >
> > >
> > > 1:37.16 (1m + 37.16s)
> > > 1:04.18
> > > 1:05.28
> > > 1:06.07
> > > 1:06.31
> > > 1:06.58
> > > 1:06.80
> > > 1:06.79
> > > 1:06.95
> > > 1:06.61
> > >
> > > > > Moreover, I wanted to test on linux 5.18. But I think I should revert
> > > > > 9eec1d897139 ("squashfs: provide backing_dev_info in order to disable
> > > > > read-ahead"),
> > > > > right? Otherwise, the patch doesn't work?
> > > >
> > > > I've never seen patch 9eec1d897139 before. If you're going to point
> > > > out bugs in my code, at least have the decency to cc me on it. It
> > > > should never have gone in, and should be reverted so the problem can
> > > > be fixed properly.
next prev parent reply other threads:[~2022-05-10 13:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-08 14:46 squashfs performance regression and readahea Song, Xiongwei
2022-05-08 16:44 ` Matthew Wilcox
2022-05-09 7:05 ` Hsin-Yi Wang
2022-05-09 7:10 ` Hsin-Yi Wang
2022-05-09 9:42 ` Song, Xiongwei
2022-05-09 12:43 ` Xiongwei Song
2022-05-09 13:21 ` Matthew Wilcox
2022-05-09 14:29 ` Hsin-Yi Wang
2022-05-10 12:30 ` Xiongwei Song
2022-05-10 12:47 ` Hsin-Yi Wang
2022-05-10 13:18 ` Xiongwei Song [this message]
2022-05-11 15:12 ` Hsin-Yi Wang
2022-05-11 19:13 ` Phillip Lougher
2022-05-12 6:23 ` Hsin-Yi Wang
2022-05-13 5:33 ` Phillip Lougher
2022-05-13 6:35 ` Hsin-Yi Wang
2022-05-15 0:54 ` Phillip Lougher
2022-05-16 8:23 ` Hsin-Yi Wang
2022-05-16 9:00 ` Xiongwei Song
2022-05-16 9:10 ` Hsin-Yi Wang
2022-05-16 9:34 ` Xiongwei Song
2022-05-16 11:01 ` Hsin-Yi Wang
2022-05-13 13:09 ` Matthew Wilcox
2022-05-15 0:05 ` Phillip Lougher
2022-05-13 12:16 ` Xiongwei Song
2022-05-13 12:29 ` Xiongwei Song
2022-05-13 16:43 ` Hsin-Yi Wang
2022-05-13 18:12 ` Matthew Wilcox
2022-05-13 23:12 ` Xiongwei Song
2022-05-14 11:51 ` Hsin-Yi Wang
2022-05-10 1:11 ` Phillip Lougher
2022-05-10 2:35 ` Matthew Wilcox
2022-05-10 3:20 ` Phillip Lougher
2022-05-10 3:41 ` Phillip Lougher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEVVKH9SuUFoR8SGP0tcB1fohW3nWRCVmSro_iDUVEV0NS2VqQ@mail.gmail.com \
--to=sxwjean@gmail.com \
--cc=Xiongwei.Song@windriver.com \
--cc=akpm@linux-foundation.org \
--cc=houtao1@huawei.com \
--cc=hsinyi@chromium.org \
--cc=linux-mm@kvack.org \
--cc=miaoxie@huawei.com \
--cc=phillip@squashfs.org.uk \
--cc=squashfs-devel@lists.sourceforge.net \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
--cc=yi.zhang@huawei.com \
--cc=zhengliang6@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.