From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2018C7E for ; Fri, 25 Nov 2022 03:58:22 +0000 (UTC) Received: by mail-ej1-f50.google.com with SMTP id ho10so7712941ejc.1 for ; Thu, 24 Nov 2022 19:58:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qQyWEHxXa79BofbvN9Ap5hUF4GqRCe2Xjm2cBntw/bE=; b=Lr8vVyUXtkK6UZYfzOdWDABeh/apxGg1mIEnt0ef3Zn+MAvK0NYu5eimOEDUW9uIDl RRSLerbb4aYtwun2wAN4H0WrvEwxRx3TOdJXE7pxvWzi0EFHIAp9WkGrEBhSGn1Fusyy CJPkalmbHREaFQ1Mso7r3R7Rn1JuwDbx00kcY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qQyWEHxXa79BofbvN9Ap5hUF4GqRCe2Xjm2cBntw/bE=; b=N/848xOGp6ZklwMwT6Vn4v7u6tqPZvooacHAaOnmCY6YZ2rAjsSZyaOKouNYhPbbi2 fiJAB6YRvUK4fqPj92qBzm3Lt73G5Gd21uPBP6BPFQtjFRtIeAwkBuzasu+/c8hyzn3j fj8E3wA3Pw0OG/W8bD8FmINGNS3iMWESeR/gE7QLfSr4IrWyWZzK6qeUrDi61INRI/dR KdMpX7gjJo4rHejMbCz08ywRUx9eZAFKTOyzHBDv0VgjD4H4WPlr/1c+zJSWUfQe0LF4 ZzbCysrjAcbPoRTxoW7MYzfpHh7vUYPvZkDbEVeGdgBt9yGi2alaZwKtntouwCHgZ5ip FiJA== X-Gm-Message-State: ANoB5pnnsbZr5Ji929sFL99bqpjxU5p8F/QCpjGRacd7Q4I5r9QvIKP1 W2362Gf3CcBR6xeFHkgCQoGMmNwNEdmldXtMvYRfpg== X-Google-Smtp-Source: AA0mqf60DoiiSCvpqj+wbIXb7MO5zK4U2JjnitTifneLjLdAV07UDYzW6uQh0/y4Sqr6wogfXNwTwDBzX2w5ZETbiug= X-Received: by 2002:a17:906:43c7:b0:7bb:c1e6:c4ac with SMTP id j7-20020a17090643c700b007bbc1e6c4acmr3635363ejn.757.1669348700297; Thu, 24 Nov 2022 19:58:20 -0800 (PST) Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20221124102056.393220-1-treapking@chromium.org> <20221124102056.393220-4-treapking@chromium.org> <166930150025.3946612.5757271936642172776.robh@kernel.org> In-Reply-To: <166930150025.3946612.5757271936642172776.robh@kernel.org> From: Pin-yen Lin Date: Fri, 25 Nov 2022 11:58:09 +0800 Message-ID: Subject: Re: [PATCH v6 3/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support To: Rob Herring Cc: Prashant Malani , Greg Kroah-Hartman , Heikki Krogerus , devicetree@vger.kernel.org, ", Andy Shevchenko" , dri-devel@lists.freedesktop.org, Laurent Pinchart , linux-acpi@vger.kernel.org, AngeloGioacchino Del Regno , Rob Herring , chrome-platform@lists.linux.dev, Robert Foss , Allen Chen , Hsin-Yi Wang , =?UTF-8?B?TsOtY29sYXMgRiAuIFIgLiBBIC4gUHJhZG8=?= , Neil Armstrong , Daniel Vetter , Sakari Ailus , Guenter Roeck , Stephen Boyd , Andrzej Hajda , Daniel Scally , Marek Vasut , Benson Leung , "Rafael J . Wysocki" , Thomas Zimmermann , David Airlie , linux-kernel@vger.kernel.org, Jonas Karlman , Lyude Paul , Krzysztof Kozlowski , Javier Martinez Canillas , Xin Ji , Jernej Skrabec Content-Type: text/plain; charset="UTF-8" Sorry for accidentally using the tab characters. Will fix this in v7. On Fri, Nov 25, 2022 at 1:39 AM Rob Herring wrote: > > > On Thu, 24 Nov 2022 18:20:52 +0800, Pin-yen Lin wrote: > > Analogix 7625 can be used in systems to switch the DP traffic between > > two downstreams, which can be USB Type-C DisplayPort alternate mode > > lane or regular DisplayPort output ports. > > > > Update the binding to accommodate this usage by introducing a > > data-lanes and a mode-switch property on endpoints. > > > > Also include the link to the product brief in the bindings. > > > > Signed-off-by: Pin-yen Lin > > > > --- > > > > Changes in v6: > > - Remove switches node and use endpoints and data-lanes property to > > describe the connections. > > > > .../display/bridge/analogix,anx7625.yaml | 73 ++++++++++++++++++- > > 1 file changed, 71 insertions(+), 2 deletions(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml:218:1: [error] syntax error: found character '\t' that cannot start any token (syntax) > > dtschema/dtc warnings/errors: > make[1]: *** Deleting file 'Documentation/devicetree/bindings/display/bridge/analogix,anx7625.example.dts' > Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml:218:1: found character '\t' that cannot start any token > make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/display/bridge/analogix,anx7625.example.dts] Error 1 > make[1]: *** Waiting for unfinished jobs.... > ./Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml:218:1: found character '\t' that cannot start any token > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml: ignoring, error parsing file > make: *** [Makefile:1492: dt_binding_check] Error 2 > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221124102056.393220-4-treapking@chromium.org > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A3E0C433FE for ; Fri, 25 Nov 2022 03:58:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 22BAC10E28F; Fri, 25 Nov 2022 03:58:27 +0000 (UTC) Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 38CCA10E28F for ; Fri, 25 Nov 2022 03:58:21 +0000 (UTC) Received: by mail-ej1-x62b.google.com with SMTP id fy37so7630509ejc.11 for ; Thu, 24 Nov 2022 19:58:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qQyWEHxXa79BofbvN9Ap5hUF4GqRCe2Xjm2cBntw/bE=; b=Lr8vVyUXtkK6UZYfzOdWDABeh/apxGg1mIEnt0ef3Zn+MAvK0NYu5eimOEDUW9uIDl RRSLerbb4aYtwun2wAN4H0WrvEwxRx3TOdJXE7pxvWzi0EFHIAp9WkGrEBhSGn1Fusyy CJPkalmbHREaFQ1Mso7r3R7Rn1JuwDbx00kcY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qQyWEHxXa79BofbvN9Ap5hUF4GqRCe2Xjm2cBntw/bE=; b=g+dRcye+zkOAaeK2ymGpB/Qm8BMwuxPhkXt7Kar1EvxGjO0em7UHaPgdfK5uptgnQr ZTDBJz9MevyG2X/RH9DjRTy/MaWg7Owl/zs0xmbWiG9EqzuMnIK4CjR5E96Fn0Z8SDXd SWM7EO6p2ri6cvrTkBRSDzCEkq0O6nXcDJSHq0lsDMD8602h1dCNT0pUfhHXLvJDU2yR NOGLbsU6vtjL2M10eHxP6xj977ORKYhCEeCG4P5c+Yd14d5kqActBWmmv9BC5vhJYgFk 7q7HnqWJn9G9JDCw7y2g+pPztEPBJtL1qp4mfhaCLDQTQ8I8aDgKg4N7NdtfEznL3qBC rnpA== X-Gm-Message-State: ANoB5pmqyHXRTfMfzf74P7tOT8FJTDlIx0z1PpboB2B0TBYp2tIKCx+z 8lxMRq6NAo125TKe6S8CH5qyzhwtBck+T3EAubgEfQ== X-Google-Smtp-Source: AA0mqf60DoiiSCvpqj+wbIXb7MO5zK4U2JjnitTifneLjLdAV07UDYzW6uQh0/y4Sqr6wogfXNwTwDBzX2w5ZETbiug= X-Received: by 2002:a17:906:43c7:b0:7bb:c1e6:c4ac with SMTP id j7-20020a17090643c700b007bbc1e6c4acmr3635363ejn.757.1669348700297; Thu, 24 Nov 2022 19:58:20 -0800 (PST) MIME-Version: 1.0 References: <20221124102056.393220-1-treapking@chromium.org> <20221124102056.393220-4-treapking@chromium.org> <166930150025.3946612.5757271936642172776.robh@kernel.org> In-Reply-To: <166930150025.3946612.5757271936642172776.robh@kernel.org> From: Pin-yen Lin Date: Fri, 25 Nov 2022 11:58:09 +0800 Message-ID: Subject: Re: [PATCH v6 3/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support To: Rob Herring Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heikki Krogerus , Krzysztof Kozlowski , "Rafael J . Wysocki" , dri-devel@lists.freedesktop.org, Laurent Pinchart , Andrzej Hajda , Guenter Roeck , Marek Vasut , chrome-platform@lists.linux.dev, Javier Martinez Canillas , Jernej Skrabec , linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, Sakari Ailus , =?UTF-8?B?TsOtY29sYXMgRiAuIFIgLiBBIC4gUHJhZG8=?= , Jonas Karlman , Allen Chen , Stephen Boyd , Rob Herring , Hsin-Yi Wang , ", Andy Shevchenko" , Xin Ji , AngeloGioacchino Del Regno , Neil Armstrong , Thomas Zimmermann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Robert Foss , Daniel Scally , Prashant Malani Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Sorry for accidentally using the tab characters. Will fix this in v7. On Fri, Nov 25, 2022 at 1:39 AM Rob Herring wrote: > > > On Thu, 24 Nov 2022 18:20:52 +0800, Pin-yen Lin wrote: > > Analogix 7625 can be used in systems to switch the DP traffic between > > two downstreams, which can be USB Type-C DisplayPort alternate mode > > lane or regular DisplayPort output ports. > > > > Update the binding to accommodate this usage by introducing a > > data-lanes and a mode-switch property on endpoints. > > > > Also include the link to the product brief in the bindings. > > > > Signed-off-by: Pin-yen Lin > > > > --- > > > > Changes in v6: > > - Remove switches node and use endpoints and data-lanes property to > > describe the connections. > > > > .../display/bridge/analogix,anx7625.yaml | 73 ++++++++++++++++++- > > 1 file changed, 71 insertions(+), 2 deletions(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml:218:1: [error] syntax error: found character '\t' that cannot start any token (syntax) > > dtschema/dtc warnings/errors: > make[1]: *** Deleting file 'Documentation/devicetree/bindings/display/bridge/analogix,anx7625.example.dts' > Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml:218:1: found character '\t' that cannot start any token > make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/display/bridge/analogix,anx7625.example.dts] Error 1 > make[1]: *** Waiting for unfinished jobs.... > ./Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml:218:1: found character '\t' that cannot start any token > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml: ignoring, error parsing file > make: *** [Makefile:1492: dt_binding_check] Error 2 > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221124102056.393220-4-treapking@chromium.org > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command. >