All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] pci: Convert to use built-in RCU list checking
@ 2019-08-30 23:18 Joel Fernandes (Google)
  2019-08-30 23:18 ` [PATCH 2/2] ipc/sem: " Joel Fernandes (Google)
  2019-09-04  4:06 ` [PATCH 1/2] pci: " kbuild test robot
  0 siblings, 2 replies; 8+ messages in thread
From: Joel Fernandes (Google) @ 2019-08-30 23:18 UTC (permalink / raw)
  To: linux-kernel
  Cc: Joel Fernandes (Google),
	Andrew Morton, Arnd Bergmann, Bjorn Helgaas, Catalin Marinas,
	Gustavo A. R. Silva, Jonathan Derrick, Keith Busch, linux-pci,
	Lorenzo Pieralisi

CONFIG_PROVE_RCU_LIST requires list_for_each_entry_rcu() to pass a
lockdep expression if using srcu or locking for protection. It can only
check regular RCU protection, all other protection needs to be passed as
lockdep expression.

Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
---
 drivers/pci/controller/vmd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
index 4575e0c6dc4b..127631d0c6da 100644
--- a/drivers/pci/controller/vmd.c
+++ b/drivers/pci/controller/vmd.c
@@ -718,7 +718,8 @@ static irqreturn_t vmd_irq(int irq, void *data)
 	int idx;
 
 	idx = srcu_read_lock(&irqs->srcu);
-	list_for_each_entry_rcu(vmdirq, &irqs->irq_list, node)
+	list_for_each_entry_rcu(vmdirq, &irqs->irq_list, node,
+				srcu_read_lock_held(&irqs->srcu))
 		generic_handle_irq(vmdirq->virq);
 	srcu_read_unlock(&irqs->srcu, idx);
 
-- 
2.23.0.187.g17f5b7556c-goog


^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-09-04 19:36 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-30 23:18 [PATCH 1/2] pci: Convert to use built-in RCU list checking Joel Fernandes (Google)
2019-08-30 23:18 ` [PATCH 2/2] ipc/sem: " Joel Fernandes (Google)
2019-09-04  5:09   ` kbuild test robot
2019-09-04  4:06 ` [PATCH 1/2] pci: " kbuild test robot
2019-09-04  5:04   ` Joel Fernandes
2019-09-04 17:13     ` Andy Shevchenko
2019-09-04 18:01       ` Joel Fernandes
2019-09-04 19:36         ` Andy Shevchenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.