All of lore.kernel.org
 help / color / mirror / Atom feed
From: bjorn.forsman@gmail.com (Bjørn Forsman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: kirkwood: Add support for Buffalo LS-XHL
Date: Tue, 5 Jul 2011 23:42:09 +0200	[thread overview]
Message-ID: <CAEYzJUHfu=PCjW1FfuEZ4BwJ9qrrv8ZLNGKfoOXp6bcE_nuGAA@mail.gmail.com> (raw)
In-Reply-To: <201107042250.42500.michael@walle.cc>

2011/7/4 Michael Walle <michael@walle.cc>:
> Am Donnerstag 30 Juni 2011, 22:58:15 schrieb Bj?rn Forsman:
>> Hi Michael,
> [..]
>> So, the power switch also seem to suffer from some interrupt overload;
>> 10154532 IRQs for Power-auto Switch is not right...right?
>>
>> Have you seen this behaviour?
> Nope, the interrupt behaves normally for me. But i'm running this patch with
> kernel 2.6.32 and tested it briefly with 2.6.39.
>
> Could you verify, if you are triggering the bug Simon posted above?

Yes, it must be the same bug. I reverted
e59347a1d15c0b1d9fdc510520f8fa78d7d19a5b (arm: orion: Use generic irq
chip) on top of "3.0-rc5 + this LS-XHL patch" and the IRQ issues are
gone.

$ cat /proc/interrupts   # after toggling the buttons and setting fan
speed to 0 a few times
...
104:          4  orion_gpio_irq  GPIO fan alarm
105:          4  orion_gpio_irq  Function Button
106:          6  orion_gpio_irq  Power-auto Switch
107:          4  orion_gpio_irq  Power-on Switch

No system hang/reboot/lockups :-)

Compare that with /proc/interrupts from the bugged version; it lists
"-" instead of "orion_gpio_irq" as IRQ handler:

104:     100000         -  GPIO fan alarm
105:          0         -  Function Button
106:          0         -  Power-auto Switch
107:          0         -  Power-on Switch

Best regards,
Bj?rn Forsman

      reply	other threads:[~2011-07-05 21:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-09 21:38 [PATCH v2] ARM: kirkwood: Add support for Buffalo LS-XHL Michael Walle
2011-06-09 21:38 ` Michael Walle
2011-06-10 13:45   ` Simon Guinot
2011-06-11  2:52     ` Nicolas Pitre
2011-06-30 20:58   ` Bjørn Forsman
2011-06-30 21:49     ` Simon Guinot
2011-07-04 20:50     ` Michael Walle
2011-07-05 21:42       ` Bjørn Forsman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEYzJUHfu=PCjW1FfuEZ4BwJ9qrrv8ZLNGKfoOXp6bcE_nuGAA@mail.gmail.com' \
    --to=bjorn.forsman@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.