From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754091AbbCISkW (ORCPT <rfc822;w@1wt.eu>);
	Mon, 9 Mar 2015 14:40:22 -0400
Received: from mail-ig0-f182.google.com ([209.85.213.182]:46776 "EHLO
	mail-ig0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750817AbbCISkN (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 9 Mar 2015 14:40:13 -0400
MIME-Version: 1.0
In-Reply-To: <1424997357-31487-2-git-send-email-jonathar@broadcom.com>
References: <jonathar@broadcom.com>
	<1424997357-31487-1-git-send-email-jonathar@broadcom.com>
	<1424997357-31487-2-git-send-email-jonathar@broadcom.com>
Date: Mon, 9 Mar 2015 11:40:11 -0700
Message-ID: <CAE_wzQ-43+oGAmyJ_cgso1XfnCYFGVczPvePG++x=povcAPOdA@mail.gmail.com>
Subject: Re: [PATCH v2 1/1] serial: 8250_dw: Fix get_mctrl behaviour
From: Dmitry Torokhov <dtor@chromium.org>
To: Jonathan Richardson <jonathar@broadcom.com>
Cc: Anatol Pomazau <anatol@google.com>, Scott Branden <sbranden@broadcom.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.cz>, devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-serial@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
        Desmond Liu <desmondl@broadcom.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 26, 2015 at 4:35 PM, Jonathan Richardson
<jonathar@broadcom.com> wrote:
> @@ -334,6 +342,30 @@ static int dw8250_probe_of(struct uart_port *p,
>         if (id >= 0)
>                 p->line = id;
>
> +       if (of_property_read_bool(np, "dcd-override")) {
> +               /* Always report DCD as active */
> +               data->msr_mask_on |= UART_MSR_DCD;
> +               data->msr_mask_off |= UART_MSR_DDCD;
> +       }
> +
> +       if (of_property_read_bool(np, "dsr-override")) {
> +               /* Always report DSR as active */
> +               data->msr_mask_on |= UART_MSR_DSR;
> +               data->msr_mask_off |= UART_MSR_DDSR;
> +       }
> +
> +       if (of_property_read_bool(np, "cts-override")) {
> +               /* Always report DSR as active */
> +               data->msr_mask_on |= UART_MSR_DSR;
> +               data->msr_mask_off |= UART_MSR_DDSR;
> +       }
> +
> +       if (of_property_read_bool(np, "ri-override")) {
> +               /* Always report Ring indicator as inactive */
> +               data->msr_mask_off |= UART_MSR_RI;
> +               data->msr_mask_off |= UART_MSR_TERI;

This looks like a typo. Should the 1st line be data->msr_mask_on by any chance?

Thanks,
Dmitry