From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ce3KW-0000nm-5D for mharc-grub-devel@gnu.org; Wed, 15 Feb 2017 12:25:24 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ce3KS-0000nW-QZ for grub-devel@gnu.org; Wed, 15 Feb 2017 12:25:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ce3KQ-0006SO-Oe for grub-devel@gnu.org; Wed, 15 Feb 2017 12:25:20 -0500 Received: from mail-ua0-x244.google.com ([2607:f8b0:400c:c08::244]:32875) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ce3KQ-0006SJ-Jb for grub-devel@gnu.org; Wed, 15 Feb 2017 12:25:18 -0500 Received: by mail-ua0-x244.google.com with SMTP id d5so14138897uag.0 for ; Wed, 15 Feb 2017 09:25:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VXSPud27fQKMad+599/2yB+A0GeNJv07SC71WO1k194=; b=Qwq0admt+HW4TLjTnxs3b4pAt4OLke6FHyAPrkkyyYOw577/ukHn3sK4tb5oRtQD3e 0iqX2LupoH5yWitOuTV0cLhKdJ7pAQl/phPoZO/A8AdVBCvKmrEuFiLsgWK174fMHeYI IFIim2aNzvNVMr68kLnfCPd8vKTr/RfbV0JGjjKKpmVdk5G59jNYkfus8MR92JW39ZmV Ku7q/jYdipEJUJI5WVzBuW8CSzSpLwwSwf3mn/ZasAdEXNEwYcWiacbEVS6RBC1pRSN1 ln/EFkNKMqLZ33XvOJsCEwSvdQBv8EwcZE2YJJ91d/yybnt+7IZ4UH5zOBCoi2+sWzZ3 2k/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VXSPud27fQKMad+599/2yB+A0GeNJv07SC71WO1k194=; b=uJ5O4ohFPter6OJ58md7QmgWNLKlClMlSUf8E76Bo3mM9OgGSYcf/FJCpZgS32zrzb K+0c6FE9L5CbHdI/xFe51DO3XdnaCkGIzJJCgRPb/Rpx/seRHmnAwHT54zfU/dFaV1jD RIib7wPM06KNqMScENO10/OvowCHN3OV3xARHoZR/5HvJve6GLz85AI012M7RqFXPjxz sIqzJxoolOqX9c5OmpGs47z+jqzgbNbm1YJ4bVTWCRtjTzfGPfgw+d6WoHX+MfrowuZv lrWBPkahmBvRc1mIUxhzQ5cr6MZn1iSCuaIE+IqD3hu/nfnEV1KH4Tx4craa3nBwfbRN AsAQ== X-Gm-Message-State: AMke39lqKLiGX6hXkPatDPedEJwBcJIvaSD30BHXuiGk50kiZNzEM+/iThvsijn5zKsVD6nbyCnCr5iNOTC7OA== X-Received: by 10.176.67.193 with SMTP id l59mr18593662ual.0.1487179517894; Wed, 15 Feb 2017 09:25:17 -0800 (PST) MIME-Version: 1.0 References: <20170214180035.3461-1-skenton@ou.edu> In-Reply-To: From: "Vladimir 'phcoder' Serbinenko" Date: Wed, 15 Feb 2017 17:25:07 +0000 Message-ID: Subject: Re: [PATCH 1/1] add --partuuid to probe To: The development of GNU GRUB Cc: Steve Kenton Content-Type: multipart/alternative; boundary=001a114bd270e1a5f2054894f60c X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400c:c08::244 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Feb 2017 17:25:23 -0000 --001a114bd270e1a5f2054894f60c Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, Feb 15, 2017, 17:27 Andrei Borzenkov wrote: > 15.02.2017 13:56, Vladimir 'phcoder' Serbinenko =D0=BF=D0=B8=D1=88=D0=B5= =D1=82: > > On Tue, Feb 14, 2017, 19:01 Steve Kenton wrote: > > > >> Support both EFI and NT Disk Signature for passing to kernel as > >> root=3DPARTUUID=3D$val > >> > >> Signed-off-by: Steve Kenton > >> --- > >> It's been six months so I thought I'd resend this so it does not get > lost > >> in case I get hit by a meteor or something before the next release > >> > >> grub-core/commands/probe.c | 53 > >> ++++++++++++++++++++++++++++++++++++++++++++++ > >> 1 file changed, 53 insertions(+) > >> > >> diff --git a/grub-core/commands/probe.c b/grub-core/commands/probe.c > >> index cf2793e..3afc8b8 100644 > >> --- a/grub-core/commands/probe.c > >> +++ b/grub-core/commands/probe.c > >> @@ -45,6 +45,7 @@ static const struct grub_arg_option options[] =3D > >> {"fs", 'f', 0, N_("Determine filesystem type."), 0, 0= }, > >> {"fs-uuid", 'u', 0, N_("Determine filesystem > UUID."), > >> 0, 0}, > >> {"label", 'l', 0, N_("Determine filesystem label."), 0, > 0}, > >> + {"partuuid", 'g', 0, N_("Determine partition GUID/UUID."), = 0, > >> 0}, /* GUID but Linux kernel calls it "PARTUUID" */ > >> > > I like how it generalizes. > > > >> {0, 0, 0, 0, 0, 0} > >> }; > >> > >> @@ -154,6 +155,58 @@ grub_cmd_probe (grub_extcmd_context_t ctxt, int > argc, > >> char **args) > >> grub_device_close (dev); > >> return GRUB_ERR_NONE; > >> } > >> + if (state[6].set) > >> + { > >> + char *partuuid =3D NULL; /* NULL to silence a spurious GCC warn= ing > */ > >> + grub_uint8_t diskbuf[16]; > >> + if (dev->disk && dev->disk->partition) > >> + { > >> + grub_partition_t p =3D dev->disk->partition; > >> + if (!grub_strcmp (p->partmap->name, "msdos")) > >> > > Please use =3D=3D 0 rather than ! > > > >> + { > >> + const int diskid_offset =3D 440; /* location in MBR */ > >> > > Please get this from a common header rather than hard coding. I think w= e > > have it in msdos.h > > > >> + dev->disk->partition =3D p->parent; > >> + /* little-endian 4-byte NT disk signature */ > >> + err =3D grub_disk_read (dev->disk, 0, diskid_offset, 4, > >> diskbuf); > >> + dev->disk->partition =3D p; > >> + if (err) > >> + return grub_errno; > >> + partuuid =3D grub_xasprintf ("%02x%02x%02x%02x-%02x", > >> + diskbuf[3], diskbuf[2], > >> diskbuf[1], diskbuf[0], > >> + p->number + 1); /* one based > >> partition number */ > >> > > This is not NT-style. NT uses partition offset. Who uses this format? A= re > > This is used by util-linux and Linux kernel. > > > * 6) PARTUUID=3D00112233-4455-6677-8899-AABBCCDDEEFF representing t= he > * unique id of a partition if the partition table provides it. > * The UUID may be either an EFI/GPT UUID, or refer to an MSDOS > * partition using the format SSSSSSSS-PP, where SSSSSSSS is a > zero- > * filled hex representation of the 32-bit "NT disk signature", > and PP > * is a zero-filled hex representation of the 1-based partition > number. > > > you sure that partition numbers are synced with user? Even in presence = of > > Solaris and bsd partitions. > > > > It is not clear what we should return for nested partition. I'm not sure > whether linux kernel scans nested partitions at all in which case we > probably should follow the suite and assign PARTUUID to top-level > partitions only. > Linux scans nested partitions and it uses though numeration in dev/sdaX, in some cases shifting numbering of normal partitions. In those cases grub and Linux numeration get out of sync > > >> + } > >> + else if (!grub_strcmp (p->partmap->name, "gpt")) > >> > > Ditto. > > > >> + { > >> + const int guid_offset =3D 16; /* location in entry */ > >> > > Ditto. > > > >> + dev->disk->partition =3D p->parent; > >> + /* little-endian 16-byte EFI partition GUID */ > >> + err =3D grub_disk_read (dev->disk, p->offset, p->index + > >> guid_offset, 16, diskbuf); > >> + dev->disk->partition =3D p; > >> + if (err) > >> + return grub_errno; > >> + partuuid =3D grub_xasprintf > >> ("%02x%02x%02x%02x-%02x%02x-%02x%02x-%02x%02x-%02x%02x%02x%02x%02x%02x= ", > >> + diskbuf[3], diskbuf[2], > >> diskbuf[1], diskbuf[0], > >> + diskbuf[5], diskbuf[4], > >> + diskbuf[7], diskbuf[6], > >> + diskbuf[8], diskbuf[9], > >> + diskbuf[10], diskbuf[11], > >> diskbuf[12], diskbuf[13], diskbuf[14], diskbuf[15]); > >> + } > >> + else > >> + return grub_error (GRUB_ERR_NOT_IMPLEMENTED_YET, > >> + N_("partition map %s does not support > >> partition UUIDs"), > >> + dev->disk->partition->partmap->name); > >> + } > >> + else > >> + partuuid =3D grub_strdup (""); /* a freeable empty string */ > >> + > >> + if (state[0].set) > >> + grub_env_set (state[0].arg, partuuid); > >> + else > >> + grub_printf ("%s", partuuid); > >> + grub_free (partuuid); > >> + grub_device_close (dev); > >> + return GRUB_ERR_NONE; > >> + } > >> grub_device_close (dev); > >> return grub_error (GRUB_ERR_BAD_ARGUMENT, "unrecognised target"); > >> } > >> -- > >> 2.9.0.137.gcf4c2cf > >> > >> > >> _______________________________________________ > >> Grub-devel mailing list > >> Grub-devel@gnu.org > >> https://lists.gnu.org/mailman/listinfo/grub-devel > >> > > > > > > > > _______________________________________________ > > Grub-devel mailing list > > Grub-devel@gnu.org > > https://lists.gnu.org/mailman/listinfo/grub-devel > > > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel > --001a114bd270e1a5f2054894f60c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On Wed, Feb 15, 2017, 1= 7:27 Andrei Borzenkov <arvidjaar@= gmail.com> wrote:
15.02.20= 17 13:56, Vladimir 'phcoder' Serbinenko =D0=BF=D0=B8=D1=88=D0=B5=D1= =82:
> On Tue, Feb 14, 2017, 19:01 Steve Kenton <skenton@ou.edu> wrote= :
>
>> Support both EFI and NT Disk Signature for passing to kernel as >> root=3DPARTUUID=3D$val
>>
>> Signed-off-by: Steve Kenton <skenton@ou.edu>
>> ---
>> It's been six months so I thought I'd resend this so it do= es not get lost
>> in case I get hit by a meteor or something before the next release=
>>
>>=C2=A0 grub-core/commands/probe.c | 53
>> ++++++++++++++++++++++++++++++++++++++++++++++
>>=C2=A0 1 file changed, 53 insertions(+)
>>
>> diff --git a/grub-core/commands/probe.c b/grub-core/commands/probe= .c
>> index cf2793e..3afc8b8 100644
>> --- a/grub-core/commands/probe.c
>> +++ b/grub-core/commands/probe.c
>> @@ -45,6 +45,7 @@ static const struct grub_arg_option options[] = =3D
>>=C2=A0 =C2=A0 =C2=A0 {"fs",=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0'f', 0, N_("Determine filesystem type.&quo= t;), 0, 0},
>>=C2=A0 =C2=A0 =C2=A0 {"fs-uuid",=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 'u', 0, N_("Determine filesyst= em UUID."),
>> 0, 0},
>>=C2=A0 =C2=A0 =C2=A0 {"label",=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 'l', 0, N_("Determine filesystem label."), 0, 0},=
>> +=C2=A0 =C2=A0 {"partuuid",=C2=A0 =C2=A0 =C2=A0 =C2=A0&#= 39;g', 0, N_("Determine partition GUID/UUID."), 0,
>> 0}, /* GUID but Linux kernel calls it "PARTUUID" */
>>
> I like how it generalizes.
>
>>=C2=A0 =C2=A0 =C2=A0 {0, 0, 0, 0, 0, 0}
>>=C2=A0 =C2=A0 };
>>
>> @@ -154,6 +155,58 @@ grub_cmd_probe (grub_extcmd_context_t ctxt, i= nt argc,
>> char **args)
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 grub_device_close (dev);
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 return GRUB_ERR_NONE;
>>=C2=A0 =C2=A0 =C2=A0 }
>> +=C2=A0 if (state[6].set)
>> +=C2=A0 =C2=A0 {
>> +=C2=A0 =C2=A0 =C2=A0 char *partuuid =3D NULL; /* NULL to silence = a spurious GCC warning */
>> +=C2=A0 =C2=A0 =C2=A0 grub_uint8_t diskbuf[16];
>> +=C2=A0 =C2=A0 =C2=A0 if (dev->disk && dev->disk->= ;partition)
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0{
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0grub_partition_t p =3D dev->= disk->partition;
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (!grub_strcmp (p->partmap= ->name, "msdos"))
>>
> Please use =3D=3D 0 rather than !
>
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0const int diskid_= offset =3D 440; /* location in MBR */
>>
> Please get this from a common header rather than hard coding. I think = we
> have it in msdos.h
>
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0dev->disk->= partition =3D p->parent;
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/* little-endian = 4-byte NT disk signature */
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0err =3D grub_disk= _read (dev->disk, 0, diskid_offset, 4,
>> diskbuf);
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0dev->disk->= partition =3D p;
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (err)
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return gru= b_errno;
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0partuuid =3D grub= _xasprintf ("%02x%02x%02x%02x-%02x",
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 diskbuf[3], diskbuf[2],
>> diskbuf[1], diskbuf[0],
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 p->number + 1); /* one based
>> partition number */
>>
> This is not NT-style. NT uses partition offset. Who uses this format? = Are

This is used by util-linux and Linux kernel.


=C2=A0*=C2=A0 =C2=A0 =C2=A0 6) PARTUUID=3D00112233-4455-6677-8899-AABBCCDDE= EFF representing the
=C2=A0*=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0unique id of a partition if the pa= rtition table provides it.
=C2=A0*=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0The UUID may be either an EFI/GPT = UUID, or refer to an MSDOS
=C2=A0*=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0partition using the format SSSSSSS= S-PP, where SSSSSSSS is a zero-
=C2=A0*=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0filled hex representation of the 3= 2-bit "NT disk signature",
and PP
=C2=A0*=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0is a zero-filled hex representatio= n of the 1-based partition
number.

> you sure that partition numbers are synced with user? Even in presence= of
> Solaris and bsd partitions.
>

It is not clear what we should return for nested partition. I'm not sur= e
whether linux kernel scans nested partitions at all in which case we
probably should follow the suite and assign PARTUUID to top-level
partitions only.
Linux scans= nested partitions and it uses though numeration in dev/sdaX, in some cases= shifting numbering of normal partitions. In those cases grub and Linux num= eration get out of sync

>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0else if (!grub_strcmp (p->pa= rtmap->name, "gpt"))
>>
> Ditto.
>
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0const int guid_of= fset =3D 16; /* location in entry */
>>
> Ditto.
>
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0dev->disk->= partition =3D p->parent;
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/* little-endian = 16-byte EFI partition GUID */
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0err =3D grub_disk= _read (dev->disk, p->offset, p->index +
>> guid_offset, 16, diskbuf);
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0dev->disk->= partition =3D p;
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (err)
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return gru= b_errno;
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0partuuid =3D grub= _xasprintf
>> ("%02x%02x%02x%02x-%02x%02x-%02x%02x-%02x%02x-%02x%02x%02x%02= x%02x%02x",
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 diskbuf[3], diskbuf[2],
>> diskbuf[1], diskbuf[0],
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 diskbuf[5], diskbuf[4],
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 diskbuf[7], diskbuf[6],
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 diskbuf[8], diskbuf[9],
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 diskbuf[10], diskbuf[11],
>> diskbuf[12], diskbuf[13], diskbuf[14], diskbuf[15]);
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0else
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return grub_error (GRUB_= ERR_NOT_IMPLEMENTED_YET,
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 N_("partition map %s does no= t support
>> partition UUIDs"),
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 dev->disk->partition->pa= rtmap->name);
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0}
>> +=C2=A0 =C2=A0 =C2=A0 else
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0partuuid =3D grub_strdup (""= ); /* a freeable empty string */
>> +
>> +=C2=A0 =C2=A0 =C2=A0 if (state[0].set)
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0grub_env_set (state[0].arg, partuuid);=
>> +=C2=A0 =C2=A0 =C2=A0 else
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0grub_printf ("%s", partuuid)= ;
>> +=C2=A0 =C2=A0 =C2=A0 grub_free (partuuid);
>> +=C2=A0 =C2=A0 =C2=A0 grub_device_close (dev);
>> +=C2=A0 =C2=A0 =C2=A0 return GRUB_ERR_NONE;
>> +=C2=A0 =C2=A0 }
>>=C2=A0 =C2=A0 grub_device_close (dev);
>>=C2=A0 =C2=A0 return grub_error (GRUB_ERR_BAD_ARGUMENT, "unrec= ognised target");
>>=C2=A0 }
>> --
>> 2.9.0.137.gcf4c2cf
>>
>>
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu.org
>> https://lists.gnu.org= /mailman/listinfo/grub-devel
>>
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mail= man/listinfo/grub-devel
>


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/l= istinfo/grub-devel
--001a114bd270e1a5f2054894f60c--