From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keara Leibovitz <kleib@mojatatu.com>
Subject: Re: [PATCH net-next 1/1] tc-testing: initial version of tunnel_key
 unit tests
Date: Thu, 28 Jun 2018 15:58:11 -0400
Message-ID: <CAEbXskW8g-pnXCfo+7yy0c912UaVH0yE7Nb88W+B3KFGqyEtUA@mail.gmail.com>
References: <1530019039-20519-1-git-send-email-kleib@mojatatu.com>
 <b5a9955f3f64ad5c017e0a995ae2d1580f08092e.camel@redhat.com>
 <CAMDBHYLmhtmtNR00yiK2i9Pt=r7Z-mRxjj7X=bR6JiDgKvCEVA@mail.gmail.com> <2ebd38dd2f1772b73f53cb5ea6c562652bb127bb.camel@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Lucas Bates <lucasb@mojatatu.com>,
        David Miller <davem@davemloft.net>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>
To: Davide Caratti <dcaratti@redhat.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-yw0-f171.google.com ([209.85.161.171]:40677 "EHLO
        mail-yw0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S965614AbeF1T60 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 28 Jun 2018 15:58:26 -0400
Received: by mail-yw0-f171.google.com with SMTP id p129-v6so2590352ywg.7
        for <netdev@vger.kernel.org>; Thu, 28 Jun 2018 12:58:26 -0700 (PDT)
In-Reply-To: <2ebd38dd2f1772b73f53cb5ea6c562652bb127bb.camel@redhat.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

>> Until I'm able to submit everything, I'd be OK with having Keara add
>> the non-zero exit codes to the teardown on her tests.  In the meantime
>> we'll get the README updated and config file added as well.
>>
>> How does this sound?
>
> it sounds good to me, but at this point we can also leave the code of
> tunnel_key as-is. there are many other items failing in this script:
>
> for act in $ACT; do
> while IFS=':' read -r id _ ; do modprobe -r act_${act} ; sleep 1 ; [ -n "$id" ] && ./tdc.py -p /home/davide/iproute2/tc/tc -e $id ; done <<EOF
> `./tdc.py -l | grep ${act}`
> EOF
> done
>
> So, it's ok for me if they are fixed all together in a series, and I
> volunteer for testing it when they land on netdev list.

Hi Davide,

I will add the non-zero exit codes and resubmit version 2 tomorrow.

Keara