From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1458762-1516614870-2-11397527585253169984 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, FREEMAIL_FROM 0.001, RCVD_IN_DNSWL_NONE -0.0001, RCVD_IN_MSPIKE_H3 -0.01, RCVD_IN_MSPIKE_WL -0.01, SPF_PASS -0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.85.217.194', Host='mail-ua0-f194.google.com', Country='US', FromHeader='com', MailFrom='com' X-Spam-charsets: plain='UTF-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: green.hu@gmail.com ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516614869; b=iURzPPghw62eg+69rHfBuc9Yyi61NYjm0K0fp8LCLQ/A38e a3HeyefhPwA+Rqcz+IAVpMdDCx/+9LeVj+kAtAptRKAnI8AZ3c83vsfp0yKsaNFw /0GSYkNlP7rZbI9tvDYOJn8HUyqbHy9psOc+N9QCeMhnR06x7Njxw2DCE9w2iS3+ ymcYWZ6anqNznjoKcidNS7cOXLCDK5pe0q/qJZ+8zKt7WWjGz23GQp9GBpXQqQ2b hx5vGdWeVBYBcaM7OXysEP0bgx/zUlycvbuE4JrDPapvWLft1LsEOM2P3KZyh10p M1r3piYnwDiLkT+gbVPE5occxKwODnpQUDPuEgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=mime-version:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; s=arctest; t= 1516614869; bh=ycJj24IkPWuINZeY3lKgbD14OFyRHGfs+AMpCcVkx0g=; b=I FVGiHR0bBmwcud3StVlgykVekjxnU+ftKRVrT28BOg9HNpzZUWLGEtmD2ZtRqAt7 opUZXeGwn8Hoi/vZMsbLGDItHM6i3amdqawRv/x51+7f3NzWlW2dQet3o8DBcfIv kbm2JmvO2ZotwP1hI//k7cOn1RMbpLrcamNGmRfrstUG+eLRPXS+3839IMQ18bD+ iu8QMoJHfjZgIvWnJQ20StRR8rJgBAV7yyNUgSHCg6paVIxrds5aHtgTGVl2pk4m G8VVGyX8pAsqrq6ySUowMpX4ergEXJmDIHubH2lMkAHwqS9DM6QOTp9ICgfBX5Mv co0Mh3aMcoho74wlUULdg== ARC-Authentication-Results: i=1; mx1.messagingengine.com; arc=none (no signatures found); dkim=pass (2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=CR8LyfqJ x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=pass (p=none,d=none) header.from=gmail.com; iprev=pass policy.iprev=209.85.217.194 (mail-ua0-f194.google.com); spf=pass smtp.mailfrom=green.hu@gmail.com smtp.helo=mail-ua0-f194.google.com; x-aligned-from=pass; x-google-dkim=pass (2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=LpyqcCoJ; x-ptr=pass x-ptr-helo=mail-ua0-f194.google.com x-ptr-lookup=mail-ua0-f194.google.com; x-return-mx=pass smtp.domain=gmail.com smtp.result=pass smtp_is_org_domain=yes header.domain=gmail.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx1.messagingengine.com; arc=none (no signatures found); dkim=pass (2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=CR8LyfqJ x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=pass (p=none,d=none) header.from=gmail.com; iprev=pass policy.iprev=209.85.217.194 (mail-ua0-f194.google.com); spf=pass smtp.mailfrom=green.hu@gmail.com smtp.helo=mail-ua0-f194.google.com; x-aligned-from=pass; x-google-dkim=pass (2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=LpyqcCoJ; x-ptr=pass x-ptr-helo=mail-ua0-f194.google.com x-ptr-lookup=mail-ua0-f194.google.com; x-return-mx=pass smtp.domain=gmail.com smtp.result=pass smtp_is_org_domain=yes header.domain=gmail.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Google-Smtp-Source: AH8x225NqhCoagQeNMkg85X17/iT/G8cd75G7JQyZGNq3d/SuvQ0WTsgDBIELGfZMDzpinE5zYqhQOojFyIRAgj+Utk= MIME-Version: 1.0 In-Reply-To: References: From: Greentime Hu Date: Mon, 22 Jan 2018 17:53:47 +0800 Message-ID: Subject: Re: [PATCH v6 31/36] dt-bindings: nds32 CPU Bindings To: Geert Uytterhoeven Cc: Arnd Bergmann , Greentime , Linux Kernel Mailing List , linux-arch , Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , Networking , Vincent Chen , DTML , Al Viro , David Howells , Will Deacon , Daniel Lezcano , linux-serial@vger.kernel.org, Linus Walleij , Mark Rutland , Greg KH , Guo Ren , Randy Dunlap , David Miller , Jonas Bonn , Stefan Kristiansson , Stafford Horne , Vincent Chen , Rick Chen , Zong Li Content-Type: text/plain; charset="UTF-8" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Hi, Geert: 2018-01-19 23:37 GMT+08:00 Geert Uytterhoeven : > Hi Greentime, > > On Fri, Jan 19, 2018 at 4:35 PM, Greentime Hu wrote: >> 2018-01-19 23:29 GMT+08:00 Geert Uytterhoeven : >>> On Fri, Jan 19, 2018 at 4:18 PM, Greentime Hu wrote: >>>> 2018-01-19 22:52 GMT+08:00 Arnd Bergmann : >>>>> On Fri, Jan 19, 2018 at 3:32 PM, Greentime Hu wrote: >>>>>> 2018-01-18 19:02 GMT+08:00 Arnd Bergmann : >>>>>>> On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: >>>>>>>> From: Greentime Hu >>>>>>>> >>>>>>>> This patch adds nds32 CPU binding documents. >>>>>>>> >>>>>>>> Signed-off-by: Vincent Chen >>>>>>>> Signed-off-by: Rick Chen >>>>>>>> Signed-off-by: Zong Li >>>>>>>> Signed-off-by: Greentime Hu >>>>>>>> Reviewed-by: Rob Herring >>>>>>>> --- >>>>>>>> Documentation/devicetree/bindings/nds32/cpus.txt | 37 ++++++++++++++++++++++ >>>>>>>> 1 file changed, 37 insertions(+) >>>>>>>> create mode 100644 Documentation/devicetree/bindings/nds32/cpus.txt >>>>>>>> >>>>>>>> diff --git a/Documentation/devicetree/bindings/nds32/cpus.txt b/Documentation/devicetree/bindings/nds32/cpus.txt >>>>>>>> new file mode 100644 >>>>>>>> index 0000000..9a52937 >>>>>>>> --- /dev/null >>>>>>>> +++ b/Documentation/devicetree/bindings/nds32/cpus.txt >>>>>>>> @@ -0,0 +1,37 @@ >>>>>>>> +* Andestech Processor Binding >>>>>>>> + >>>>>>>> +This binding specifies what properties must be available in the device tree >>>>>>>> +representation of a Andestech Processor Core, which is the root node in the >>>>>>>> +tree. >>>>>>>> + >>>>>>>> +Required properties: >>>>>>>> + >>>>>>>> + - compatible: >>>>>>>> + Usage: required >>>>>>>> + Value type: >>>>>>>> + Definition: should be one of: >>>>>>>> + "andestech,n13" >>>>>>>> + "andestech,n15" >>>>>>>> + "andestech,d15" >>>>>>>> + "andestech,n10" >>>>>>>> + "andestech,d10" >>>>>>>> + "andestech,nds32v3" >>>>>>> >>>>>>> Based on https://lkml.org/lkml/2017/11/27/1290, this should say that >>>>>>> the device tree should always list 'andestech,nds32v3' as the most >>>>>>> generic 'compatible' value and list exactly one of the others in >>>>>>> addition. >>>>> >>>>>> I will remove the others and just left "andestech,nds32v3" in here. >>>>> >>>>> No, is not what we want here, the CPU node should list exactly which core >>>>> is used, what we need in the description is a clarification that >>>>> andestech,nds32v3 must be used in addition to the more specific >>>>> string. >>>> >>>> Hi, Arnd: >>>> >>>> Sorry I still don't get your point. Do you mean we should always use >>>> compatible = "andestech,n13", "andestech,nds32v3"; >>>> instead of >>>> compatible = "andestech,n13"; >>> >>> Exactly. The first value is a device-specific compatible value, the second is >>> a generic fallback. >>> >>>> And I need to add the description in this document. >>> >>> Indeed. See for example >>> Documentation/devicetree/bindings/power/renesas,apmu.txt >>> >>> Thanks! >> >> Hi, Geert: >> >> Thank you and your example. >> I get it. I will update this document like this. >> - compatible: Should be "andestech,", "andestech,nds32v3" >> as fallback. > > And please keep a list of supported values of "andestech," > in the DT binding document, so checkpatch can validate compatible values. > Thank you for reminding me this. I will list it like this. - compatible: Usage: required Value type: Definition: Should be "andestech,", "andestech,nds32v3" as fallback. Examlpes with core_names are: "andestech,n13" "andestech,n15" "andestech,d15" "andestech,n10" "andestech,d10" From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greentime Hu Subject: Re: [PATCH v6 31/36] dt-bindings: nds32 CPU Bindings Date: Mon, 22 Jan 2018 17:53:47 +0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Arnd Bergmann , Greentime , Linux Kernel Mailing List , linux-arch , Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , Networking , Vincent Chen , DTML , Al Viro , David Howells , Will Deacon , Daniel Lezcano , linux-serial@vger.kernel.org, Linus Walleij , Mark Rutland , Greg KH , Guo Ren , Randy Dunlap Return-path: In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi, Geert: 2018-01-19 23:37 GMT+08:00 Geert Uytterhoeven : > Hi Greentime, > > On Fri, Jan 19, 2018 at 4:35 PM, Greentime Hu wrote: >> 2018-01-19 23:29 GMT+08:00 Geert Uytterhoeven : >>> On Fri, Jan 19, 2018 at 4:18 PM, Greentime Hu wrote: >>>> 2018-01-19 22:52 GMT+08:00 Arnd Bergmann : >>>>> On Fri, Jan 19, 2018 at 3:32 PM, Greentime Hu wrote: >>>>>> 2018-01-18 19:02 GMT+08:00 Arnd Bergmann : >>>>>>> On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: >>>>>>>> From: Greentime Hu >>>>>>>> >>>>>>>> This patch adds nds32 CPU binding documents. >>>>>>>> >>>>>>>> Signed-off-by: Vincent Chen >>>>>>>> Signed-off-by: Rick Chen >>>>>>>> Signed-off-by: Zong Li >>>>>>>> Signed-off-by: Greentime Hu >>>>>>>> Reviewed-by: Rob Herring >>>>>>>> --- >>>>>>>> Documentation/devicetree/bindings/nds32/cpus.txt | 37 ++++++++++++++++++++++ >>>>>>>> 1 file changed, 37 insertions(+) >>>>>>>> create mode 100644 Documentation/devicetree/bindings/nds32/cpus.txt >>>>>>>> >>>>>>>> diff --git a/Documentation/devicetree/bindings/nds32/cpus.txt b/Documentation/devicetree/bindings/nds32/cpus.txt >>>>>>>> new file mode 100644 >>>>>>>> index 0000000..9a52937 >>>>>>>> --- /dev/null >>>>>>>> +++ b/Documentation/devicetree/bindings/nds32/cpus.txt >>>>>>>> @@ -0,0 +1,37 @@ >>>>>>>> +* Andestech Processor Binding >>>>>>>> + >>>>>>>> +This binding specifies what properties must be available in the device tree >>>>>>>> +representation of a Andestech Processor Core, which is the root node in the >>>>>>>> +tree. >>>>>>>> + >>>>>>>> +Required properties: >>>>>>>> + >>>>>>>> + - compatible: >>>>>>>> + Usage: required >>>>>>>> + Value type: >>>>>>>> + Definition: should be one of: >>>>>>>> + "andestech,n13" >>>>>>>> + "andestech,n15" >>>>>>>> + "andestech,d15" >>>>>>>> + "andestech,n10" >>>>>>>> + "andestech,d10" >>>>>>>> + "andestech,nds32v3" >>>>>>> >>>>>>> Based on https://lkml.org/lkml/2017/11/27/1290, this should say that >>>>>>> the device tree should always list 'andestech,nds32v3' as the most >>>>>>> generic 'compatible' value and list exactly one of the others in >>>>>>> addition. >>>>> >>>>>> I will remove the others and just left "andestech,nds32v3" in here. >>>>> >>>>> No, is not what we want here, the CPU node should list exactly which core >>>>> is used, what we need in the description is a clarification that >>>>> andestech,nds32v3 must be used in addition to the more specific >>>>> string. >>>> >>>> Hi, Arnd: >>>> >>>> Sorry I still don't get your point. Do you mean we should always use >>>> compatible = "andestech,n13", "andestech,nds32v3"; >>>> instead of >>>> compatible = "andestech,n13"; >>> >>> Exactly. The first value is a device-specific compatible value, the second is >>> a generic fallback. >>> >>>> And I need to add the description in this document. >>> >>> Indeed. See for example >>> Documentation/devicetree/bindings/power/renesas,apmu.txt >>> >>> Thanks! >> >> Hi, Geert: >> >> Thank you and your example. >> I get it. I will update this document like this. >> - compatible: Should be "andestech,", "andestech,nds32v3" >> as fallback. > > And please keep a list of supported values of "andestech," > in the DT binding document, so checkpatch can validate compatible values. > Thank you for reminding me this. I will list it like this. - compatible: Usage: required Value type: Definition: Should be "andestech,", "andestech,nds32v3" as fallback. Examlpes with core_names are: "andestech,n13" "andestech,n15" "andestech,d15" "andestech,n10" "andestech,d10" From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greentime Hu Subject: Re: [PATCH v6 31/36] dt-bindings: nds32 CPU Bindings Date: Mon, 22 Jan 2018 17:53:47 +0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-arch-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Arnd Bergmann , Greentime , Linux Kernel Mailing List , linux-arch , Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , Networking , Vincent Chen , DTML , Al Viro , David Howells , Will Deacon , Daniel Lezcano , linux-serial@vger.kernel.org, Linus Walleij , Mark Rutland , Greg KH , Guo Ren , Randy Dunlap List-Id: devicetree@vger.kernel.org Hi, Geert: 2018-01-19 23:37 GMT+08:00 Geert Uytterhoeven : > Hi Greentime, > > On Fri, Jan 19, 2018 at 4:35 PM, Greentime Hu wrote: >> 2018-01-19 23:29 GMT+08:00 Geert Uytterhoeven : >>> On Fri, Jan 19, 2018 at 4:18 PM, Greentime Hu wrote: >>>> 2018-01-19 22:52 GMT+08:00 Arnd Bergmann : >>>>> On Fri, Jan 19, 2018 at 3:32 PM, Greentime Hu wrote: >>>>>> 2018-01-18 19:02 GMT+08:00 Arnd Bergmann : >>>>>>> On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: >>>>>>>> From: Greentime Hu >>>>>>>> >>>>>>>> This patch adds nds32 CPU binding documents. >>>>>>>> >>>>>>>> Signed-off-by: Vincent Chen >>>>>>>> Signed-off-by: Rick Chen >>>>>>>> Signed-off-by: Zong Li >>>>>>>> Signed-off-by: Greentime Hu >>>>>>>> Reviewed-by: Rob Herring >>>>>>>> --- >>>>>>>> Documentation/devicetree/bindings/nds32/cpus.txt | 37 ++++++++++++++++++++++ >>>>>>>> 1 file changed, 37 insertions(+) >>>>>>>> create mode 100644 Documentation/devicetree/bindings/nds32/cpus.txt >>>>>>>> >>>>>>>> diff --git a/Documentation/devicetree/bindings/nds32/cpus.txt b/Documentation/devicetree/bindings/nds32/cpus.txt >>>>>>>> new file mode 100644 >>>>>>>> index 0000000..9a52937 >>>>>>>> --- /dev/null >>>>>>>> +++ b/Documentation/devicetree/bindings/nds32/cpus.txt >>>>>>>> @@ -0,0 +1,37 @@ >>>>>>>> +* Andestech Processor Binding >>>>>>>> + >>>>>>>> +This binding specifies what properties must be available in the device tree >>>>>>>> +representation of a Andestech Processor Core, which is the root node in the >>>>>>>> +tree. >>>>>>>> + >>>>>>>> +Required properties: >>>>>>>> + >>>>>>>> + - compatible: >>>>>>>> + Usage: required >>>>>>>> + Value type: >>>>>>>> + Definition: should be one of: >>>>>>>> + "andestech,n13" >>>>>>>> + "andestech,n15" >>>>>>>> + "andestech,d15" >>>>>>>> + "andestech,n10" >>>>>>>> + "andestech,d10" >>>>>>>> + "andestech,nds32v3" >>>>>>> >>>>>>> Based on https://lkml.org/lkml/2017/11/27/1290, this should say that >>>>>>> the device tree should always list 'andestech,nds32v3' as the most >>>>>>> generic 'compatible' value and list exactly one of the others in >>>>>>> addition. >>>>> >>>>>> I will remove the others and just left "andestech,nds32v3" in here. >>>>> >>>>> No, is not what we want here, the CPU node should list exactly which core >>>>> is used, what we need in the description is a clarification that >>>>> andestech,nds32v3 must be used in addition to the more specific >>>>> string. >>>> >>>> Hi, Arnd: >>>> >>>> Sorry I still don't get your point. Do you mean we should always use >>>> compatible = "andestech,n13", "andestech,nds32v3"; >>>> instead of >>>> compatible = "andestech,n13"; >>> >>> Exactly. The first value is a device-specific compatible value, the second is >>> a generic fallback. >>> >>>> And I need to add the description in this document. >>> >>> Indeed. See for example >>> Documentation/devicetree/bindings/power/renesas,apmu.txt >>> >>> Thanks! >> >> Hi, Geert: >> >> Thank you and your example. >> I get it. I will update this document like this. >> - compatible: Should be "andestech,", "andestech,nds32v3" >> as fallback. > > And please keep a list of supported values of "andestech," > in the DT binding document, so checkpatch can validate compatible values. > Thank you for reminding me this. I will list it like this. - compatible: Usage: required Value type: Definition: Should be "andestech,", "andestech,nds32v3" as fallback. Examlpes with core_names are: "andestech,n13" "andestech,n15" "andestech,d15" "andestech,n10" "andestech,d10"