Re: [PATCH v11 00/11] HID: nintendo

From: Roderick Colenbrander <thunderbird2k@gmail.com>
To: Bastien Nocera <hadess@hadess.net>
Cc: "Daniel J. Ogorchock" <djogorchock@gmail.com>,
	linux-input <linux-input@vger.kernel.org>,
	Billy Laws <blaws05@gmail.com>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Jiri Kosina <jikos@kernel.org>,
	"Colenbrander, Roelof" <Roderick.Colenbrander@sony.com>,
	Siarhei Vishniakou <svv@google.com>,
	s.jegen@gmail.com, Carl Mueller <carmueller@gmail.com>
Subject: Re: [PATCH v11 00/11] HID: nintendo
Date: Sun, 26 Apr 2020 13:42:32 -0700	[thread overview]
Message-ID: <CAEc3jaACUvyrP=9=JZeUZEC16zDJ2NByJzaPHVO24024jwKJoA@mail.gmail.com> (raw)
In-Reply-To: <64ed771ebdd6c47c11a94f4e0ae365c6106b93f6.camel@hadess.net>

On Sat, Apr 25, 2020 at 6:01 AM Bastien Nocera <hadess@hadess.net> wrote:
>
> Hey Daniel,
>
> On Mon, 2020-03-16 at 22:29 -0500, Daniel J. Ogorchock wrote:
> > I removed the IMU patch for now, since I have some more work on it to
> > do
> > before it's ready. This version fixes a bug with joy-con S-trigger
> > configuration and switches the pro controller's Dpad input to a hat.
>
> I don't have a Nintendo Switch Pro controller, but I recently got an
> 8Bitdo "GBros" adapter along with a third-party GameCube adapter for
> less than 20€, and tried out the "Switch" mode against your driver.
>
> When plugging it in via USB:
> [  593.228423] input: Nintendo Co., Ltd. Pro Controller as /devices/pci0000:00/0000:00:14.0/usb3/3-1/3-1:1.0/0003:057E:2009.0007/input/input34
> [  593.229859] hid-generic 0003:057E:2009.0007: input,hidraw4: USB HID v1.11 Joystick [Nintendo Co., Ltd. Pro Controller] on usb-0000:00:14.0-1/input0
> [  593.317011] nintendo 0003:057E:2009.0007: hidraw4: USB HID v81.11 Joystick [Nintendo Co., Ltd. Pro Controller] on usb-0000:00:14.0-1/input0
> [  595.476014] nintendo 0003:057E:2009.0007: Failed to set baudrate; ret=-110
> [  595.485961] nintendo 0003:057E:2009.0007: probe - fail = -110
> [  595.486019] nintendo: probe of 0003:057E:2009.0007 failed with error -110
>
> After pairing it with Bluetooth:
> [ 3974.268521] nintendo 0005:057E:2009.0009: unknown main item tag 0x0
> [ 3974.271295] nintendo 0005:057E:2009.0009: hidraw4: BLUETOOTH HID v80.01 Gamepad [Pro Controller] on 44:85:00:1e:ab:f8
> [ 3976.494269] nintendo 0005:057E:2009.0009: controller MAC = 98:B6:E9:42:A8:DD
> [ 3977.036391] nintendo 0005:057E:2009.0009: Failed to set home LED dflt; ret=-110
> [ 3977.036402] nintendo 0005:057E:2009.0009: Failed to create leds; ret=-110
> [ 3977.049328] nintendo 0005:057E:2009.0009: probe - fail = -110
> [ 3977.564465] leds 0005:057E:2009.0009:home: Setting an LED's brightness failed (-110)
> [ 3978.076440] leds 0005:057E:2009.0009:player4: Setting an LED's brightness failed (-110)
> [ 3978.589367] leds 0005:057E:2009.0009:player3: Setting an LED's brightness failed (-110)
> [ 3979.101347] leds 0005:057E:2009.0009:player2: Setting an LED's brightness failed (-110)
> [ 3979.612308] leds 0005:057E:2009.0009:player1: Setting an LED's brightness failed (-110)
> [ 3979.612977] nintendo: probe of 0005:057E:2009.0009 failed with error -110
>
> I'm guessing the LED and baudrate setting failures should probably be
> non-fatal. Let me know if there's anything else you'd like me to test.
>
> For Fedora users who want to try out this v11 version of the driver:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=43730136
> (note that the build will be removed in a bit less than a week)
>
> Cheers

I really wonder how a device like this should be handled. It looks
like the device can also handle a bunch of other classic Nintendo
controllers.

Is there anyway of detection this adapter? It feels nasty to have to
hack in quirks for this device...

Thanks,
Roderick