From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4193C433EF for ; Mon, 23 May 2022 13:21:51 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 01F1084207; Mon, 23 May 2022 15:21:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="hmn8gvgs"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9AB3783EB4; Sun, 22 May 2022 17:53:46 +0200 (CEST) Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 16CD983E3A for ; Sun, 22 May 2022 17:53:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=hsnaves@gmail.com Received: by mail-lj1-x22e.google.com with SMTP id a23so14559249ljd.9 for ; Sun, 22 May 2022 08:53:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lwvKYLDCSiKfxPcvavjkUM5rhInQNqldJYJjtNJLLF4=; b=hmn8gvgslFqKHgYgL+O6hZEUnq379CL7gXEHtNmcY/hUfI3wm76/DYBweHhC/K+BvG NM7TaoDs14aMtHKT1oW1d6FsuaQoYIn/LffOjkFRy2DcAsrNsEoBX/xAjaviDZvaMXGG 5S6Un91+S73o0P+/1Dj0J+j1bvZ63/LZLwmR+laNRUxZR827+Af7BwQpjwZF/7qza7n8 e3gx7j9UFqUW9YI9XgUFfJOa0wWiqTi2c11rO+gihX2NFsIQWVSChjD5ZJ8WO9LsFGhz mjgkPng5YzOBqjQeE1o1yATd//o9EP3nS6cq30yzWeKQd/Cdeg0eKP5Bu5m9qOUXTgP2 jWlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lwvKYLDCSiKfxPcvavjkUM5rhInQNqldJYJjtNJLLF4=; b=Luk4IfWi4SmpEiZAYZi1BO8FbrePgOiNi/MaY12Lx1k90mhYIVWk4c/O3w9YOphn+k hmA3zTPcu7+EkxMjvdDVjKg0ELaip1U5bHhO2xa70zUfRRVWhNErtbTXSKPiFyF3nqvy I43yo4TRRhG6f/jajKfCuyYtgOpqcc9fM6+WlgNy72WHdZUPJwkvDLUg0/w1Crl6a+Kz taKTfKIL+jOrKm1phl/eeiUCThX2pWM4OgOS6zOeWV9DhGuBvV5IjhrTMh0mizeS8eZt bhK7uTfohW3P7JxGc6V/u3+f3oNrZwVwZMCBzZ4dN2iUZn2LqVuwkokicnuFkVAL2EnS A0CQ== X-Gm-Message-State: AOAM530njwX9sYDLC2vBSSq3Th8qSZHGR+us6zQ33ZWaNLJPaS7lyy35 4FSzIn1NL4mUFL5tIJonEm9WdvwaVv5KFcyoONPCV6u0xVs= X-Google-Smtp-Source: ABdhPJxCnMVIxWvS12hVfQs1Foy111Al2QYgKCjDQkZq5OHH7wGHyV0kj02KnbsFv2+WndjNzTeX4CyX/4+NZ5H8Zns= X-Received: by 2002:a2e:a78f:0:b0:253:e71f:69a8 with SMTP id c15-20020a2ea78f000000b00253e71f69a8mr2587841ljf.432.1653234823187; Sun, 22 May 2022 08:53:43 -0700 (PDT) MIME-Version: 1.0 References: <20220521173221.6425-1-hsnaves@gmail.com> In-Reply-To: From: Humberto Naves Date: Sun, 22 May 2022 11:53:31 -0400 Message-ID: Subject: Re: [PATCH] arm: socfpga: Add the terasic de10-standard board To: Marek Vasut Cc: u-boot@lists.denx.de Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Mon, 23 May 2022 15:21:28 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Marek, Thanks for the quick review! > Doesn't the PLL config also come from quartus ? It should all come from > it. See doc/README.socfpga My mistake, I will update the patch using all the files created by the bsp-create-settings. > I think a lot of those board/config-specific copyright messages could > use an update, I think they should be assigned to you. Please do a quick > V2 with that change. Besides that: Please advise what I should do there. For this particular board I adapted the code from the de10-nano board, which already had these copyright messages. Best regards, On Sat, May 21, 2022 at 10:06 PM Marek Vasut wrote: > > On 5/21/22 19:32, Humberto Naves wrote: > > Used the de10-nano files as templates for the de10-standard board. > > Changed the iocsr_config.h and pinmux_config.h based on the handoff > > files generated by quartus. Finally, the pll_config.h was copied > > from the altera cyclone5-socdk board. > > Doesn't the PLL config also come from quartus ? It should all come from > it. See doc/README.socfpga > > > Signed-off-by: Humberto Naves > > Cc: Marek Vasut > > I think a lot of those board/config-specific copyright messages could > use an update, I think they should be assigned to you. Please do a quick > V2 with that change. Besides that: > > Reviewed-by: Marek Vasut