All of lore.kernel.org
 help / color / mirror / Atom feed
From: Naohiro Aota <naota@elisp.net>
To: David Sterba <dsterba@suse.cz>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
	Naohiro Aota <naota@elisp.net>,
	Qu Wenruo <quwenruo@cn.fujitsu.com>
Subject: Re: [PATCH 1/3] btrfs-progs: test: umount if confirmation failed
Date: Tue, 8 Dec 2015 11:18:31 +0900	[thread overview]
Message-ID: <CAEe67=9D002VpFp32_dNs=GQ0GmErbgmvVRQeVvVU_VLS_6BkQ@mail.gmail.com> (raw)
In-Reply-To: <20151207153339.GF4227@twin.jikos.cz>

On Tue, Dec 8, 2015 at 12:33 AM, David Sterba <dsterba@suse.cz> wrote:
> On Fri, Dec 04, 2015 at 02:37:25PM +0900, Naohiro Aota wrote:
>> When a check in check_inode() failed, the test should umount test target
>> file system. This commit add clean up umount line in failure path.
>
> The lack of cleanup after failed tests is intentional (exceptions
> possible). The tests are supposed to do cleanup if they pass but if they
> fail the test environment could be examined. In case of more complex
> setups (loop devices, dm devices) it's some work to set it up again.
>
> We could add an optional per-test script cleanup.sh that does the
> cleanup on demand (and is also run from tests/clean-tests.sh).

I see.
Well, I overlooked the README.md stating about clean-tests.sh...

  reply	other threads:[~2015-12-08  2:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-04  5:37 [PATCH 0/3] btrfs-progs: fix file restore to lost+found bug Naohiro Aota
2015-12-04  5:37 ` [PATCH 1/3] btrfs-progs: test: umount if confirmation failed Naohiro Aota
2015-12-07 15:33   ` David Sterba
2015-12-08  2:18     ` Naohiro Aota [this message]
2015-12-04  5:37 ` [PATCH 2/3] btrfs-progs: properly reset nlink of multi-linked file Naohiro Aota
2015-12-05  1:34   ` Qu Wenruo
2015-12-07 15:37   ` David Sterba
2015-12-05  1:35 ` [PATCH 0/3] btrfs-progs: fix file restore to lost+found bug Qu Wenruo
2015-12-07  2:59   ` Naohiro Aota
2015-12-07  3:02     ` Qu Wenruo
2015-12-07 15:35     ` David Sterba
2015-12-08  2:06       ` Naohiro Aota
2015-12-15 10:13         ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEe67=9D002VpFp32_dNs=GQ0GmErbgmvVRQeVvVU_VLS_6BkQ@mail.gmail.com' \
    --to=naota@elisp.net \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.