From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95687ECAAD8 for ; Tue, 20 Sep 2022 05:54:21 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 0911E3CAD2A for ; Tue, 20 Sep 2022 07:54:19 +0200 (CEST) Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [IPv6:2001:4b78:1:20::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 1F2153CA00A for ; Tue, 20 Sep 2022 07:54:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id 7BECD600954 for ; Tue, 20 Sep 2022 07:54:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663653245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eRF9lFo0vy3dOEqFUMP3PFDtyayewhKQ/HutwATF4pw=; b=NpjA3Cd2pjgrYGurS2UPjYJ+prbsxwYT/5KS1b0ZZ1uqeTFMGvkURKbGEELP8Wo3dgcR6T KKy0vDhtbhIVIpnJJS6GQz46dx3jt24UxnMvthycB7wDKI4YXiDr24JqWIdeeSG4Yq2Shh TvyJDMo9yCimTLwoDWBteXiS6GG1gLo= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-486-rQfWLwxGOiOlntKf7a4iaA-1; Tue, 20 Sep 2022 01:54:03 -0400 X-MC-Unique: rQfWLwxGOiOlntKf7a4iaA-1 Received: by mail-ua1-f72.google.com with SMTP id y10-20020ab0560a000000b003af33bfa8c4so501254uaa.21 for ; Mon, 19 Sep 2022 22:54:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=eRF9lFo0vy3dOEqFUMP3PFDtyayewhKQ/HutwATF4pw=; b=PqlIplZnM/Mwka1si5BcKLevHkAvozYvQB8hXWIxWuCOOh1F8RYWftoaknA156VhNa +UhL58YTiRvIWyTvOJq0s3HFy9FKaCzysU4YDrG7p6N22yD/AnGUQDrNwZ/IKs6NGSl3 oAoHCwGS7maUbiyDoaQW234zf4o5ipOfBMwOWGQZz648Dl/6y9TPdOL8WH2q3Sft2GBc QUEgTRMZUv2PaebEYinnxHOIyJqcKC2BQfEBJmBDELTBANW7e4cg92y1VU1QB2/05M67 9DRdy6KmevXoyCY9LHsSktBT27GYOMd+9bUJUMi20u88dlCaZRfwyShLUcXVYZBaOwXV 9/rw== X-Gm-Message-State: ACrzQf332l3iLG7QM6K7CiBxAf7Qjkb8OCPhs6wtATBt5xR6oUxtiJnO 6UuUX5SMkhWxW4Kn6tnrv01wHJCq/LR7JXveBvdCeJoo/yzbOHnKbemph1YJRDz5TqQuV9q/jd4 e9kMrvMhe24nI0SIpETILnOcXMzA= X-Received: by 2002:a05:6102:23f7:b0:398:bce4:ead with SMTP id p23-20020a05610223f700b00398bce40eadmr7240070vsc.41.1663653243197; Mon, 19 Sep 2022 22:54:03 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6xyukJOir82oSMt88HDIjL5ppqUgyUIXWfCSReJb9x0A256ph+Bvtttto5RxDVH4kbDylP4xOPQazSj1p1tkI= X-Received: by 2002:a05:6102:23f7:b0:398:bce4:ead with SMTP id p23-20020a05610223f700b00398bce40eadmr7240058vsc.41.1663653242831; Mon, 19 Sep 2022 22:54:02 -0700 (PDT) MIME-Version: 1.0 References: <20220915031020.2633347-1-liwang@redhat.com> In-Reply-To: From: Li Wang Date: Tue, 20 Sep 2022 13:53:51 +0800 Message-ID: To: Cyril Hrubis X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Virus-Scanned: clamav-milter 0.102.4 at in-2.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] open04: add EMFILE check X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: LTP List Content-Type: multipart/mixed; boundary="===============0215397667==" Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" --===============0215397667== Content-Type: multipart/alternative; boundary="000000000000919c8705e91574b4" --000000000000919c8705e91574b4 Content-Type: text/plain; charset="UTF-8" On Mon, Sep 19, 2022 at 8:12 PM Li Wang wrote: > Cyril Hrubis wrote: > > Hi! >> > > I faintly remmeber a similar patch where we decided not to work around >> > > for a test harness leaking filedescriptors into testcases. >> > > >> > >> > This also should be a solution, I searched the mailing list and got a >> > patch[1]. >> > Do you mean adding that close-on-exec flag when opening fd in harness? >> >> Yes, that way you can be sure that no file descriptors are leaked to the >> tests. >> > > Ok, should I send patch v2 like this below? > > Note: the automation test open04 got passed but I'm not sure > if this has a side effect on logs. But from my observation, some > tests (with old-API) log can't be collected anymore. > Seems we shouldn't fix by adding 'close-on-exec' flag simply, it brings more issues to some old-API tests, I'm still looking into the problems which look like caused by ltp-pan designed. So can we just merge the patch as the original? -- Regards, Li Wang --000000000000919c8705e91574b4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, Sep 19, 2022 at 8:12 PM Li Wang <liwang@redhat.com> wrote:
Cyril Hrubis <chrubis@suse.cz> wrote:

Hi!
> > I faintly remmeber a similar patch where we decided not to work a= round
> > for a test harness leaking filedescriptors into testcases.
> >
>
> This also should be a solution, I searched the mailing list and got a<= br> > patch[1].
> Do you mean adding that close-on-exec flag when opening fd in harness?=

Yes, that way you can be sure that no file descriptors are leaked to the tests.

O= k, should I send patch v2 like this below?

Note: the automation test open= 04 got passed but I'm not sure
if t= his has a side effect on logs. But from my observation, some=C2=A0
tests (with old-API) log can't be collected= anymore.

Seems we shouldn't fix by addi= ng=C2=A0'close-on-exec' flag simply,
it brings more issues to some old-API tests, = I'm still looking into
the problems which look like caused by=C2=A0ltp-pan designed.

So can we just merge the= =C2=A0patch as the original?

--
Regards,
= Li Wang
--000000000000919c8705e91574b4-- --===============0215397667== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- Mailing list info: https://lists.linux.it/listinfo/ltp --===============0215397667==--