All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Wang <liwang@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/copy_file_range02: Fix #12 when TMPDIR is on tmpfs or ext[234]
Date: Thu, 8 Aug 2019 15:04:46 +0800	[thread overview]
Message-ID: <CAEemH2cM7mhkYBvTTFC4UhjnYxG0D_e-nkCmSF2U8pB61UT0bw@mail.gmail.com> (raw)
In-Reply-To: <20190807094119.10834-1-pvorel@suse.cz>

Hi Petr,

Thanks for highlight this.

> Cyril, Jan, Li, still not sure what the policy about errno is (see
> Cyril's statements in recent discussion about it in Jinhui's patch [1]
> [2]). With these frequent changes we should IMHO check for all possible
> variants (EXDEV, EFBIG, EINVAL).
>
> Or should we investigate all fixes and keep errors which highlight
> important fix was not backported (to both stable and LTS/enterprise
> distros kernels?). That'd be weird but approach practical :).

That sounds not very realistic. We can't satisfy all distributions for
errno checking, because we don't know when/wheather it backports the
patch.

>
> Anyway, we should define and write down LTP policy / rules about it.

I think we might have these ways of choosing:

1. Only align with the latest kernel behavior
    e.g limit the latest kernel version and verify that valid errno
The disadvantage of this is only tested on a small kernel range.

2. Guarded by kernel version check as Cyril suggests in [1]
    e.g  kernel >= 4.10; Check errno == EBADF
           kernel < 4.10; Check errno == EISDIR
           ....
The disadvantage is that the test result is affected by LTS with a
backport-patch.

3. Regards all acceptable errnos as valid on any kernel version
    e.g  whatever errno get any of them EXDEV, EFBIG, EINVAL, regard valid
This sounds obviously awful.

Or, anything else?

-- 
Regards,
Li Wang

  parent reply	other threads:[~2019-08-08  7:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-07  9:41 [LTP] [PATCH] syscalls/copy_file_range02: Fix #12 when TMPDIR is on tmpfs or ext[234] Petr Vorel
2019-08-07 11:45 ` Jan Stancek
2019-08-07 14:48 ` Darrick J. Wong
2019-08-08  7:04 ` Li Wang [this message]
2019-08-09  9:42   ` Petr Vorel
2019-08-09 10:17     ` Li Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEemH2cM7mhkYBvTTFC4UhjnYxG0D_e-nkCmSF2U8pB61UT0bw@mail.gmail.com \
    --to=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.