All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Wang <liwang@redhat.com>
To: Luke Nowakowski-Krijger <luke.nowakowskikrijger@canonical.com>
Cc: LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v5 00/18] Expand Cgroup lib and modify controller tests
Date: Tue, 26 Jul 2022 14:10:55 +0800	[thread overview]
Message-ID: <CAEemH2cW-yEk598waeFkDT4tkN0hoXqDwKL3LKCuzBqWfNqvUg@mail.gmail.com> (raw)
In-Reply-To: <cover.1658433280.git.luke.nowakowskikrijger@canonical.com>


[-- Attachment #1.1: Type: text/plain, Size: 484 bytes --]

Hi All,

I have completed my review (and test) on this patch set, generally looks
good!

With regard to the tiny issues, I think Luke you can just against the
concrete
problem to follow up and fix it. No need to resend all patches with a new
version.

I would suggest merging this patchset at present (in case of blocking
other's (or duplicate) work).

CI builds pass: https://github.com/wangli5665/ltp/runs/7460955660

Reviewed-by: Li Wang <liwang@redhat.com>


-- 
Regards,
Li Wang

[-- Attachment #1.2: Type: text/html, Size: 1528 bytes --]

[-- Attachment #2: Type: text/plain, Size: 60 bytes --]


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2022-07-26  6:11 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-21 20:52 [LTP] [PATCH v5 00/18] Expand Cgroup lib and modify controller tests Luke Nowakowski-Krijger
2022-07-21 20:52 ` [LTP] [PATCH v3 01/18] API/cgroup: Modify tst_cg_print_config for parsing and consumption Luke Nowakowski-Krijger
2022-07-21 20:52 ` [LTP] [PATCH 02/18] API/cgroup: Add option for specific pid to tst_cg_opts Luke Nowakowski-Krijger
2022-07-21 20:52 ` [LTP] [PATCH v2 03/18] API/cgroup: Add cgroup_find_root helper function Luke Nowakowski-Krijger
2022-07-21 20:52 ` [LTP] [PATCH 04/18] API/cgroup: Add CTRL_NAME_MAX define Luke Nowakowski-Krijger
2022-07-21 20:52 ` [LTP] [PATCH v2 05/18] tst_test_macros: Add TST_TO_STR and TST_STR macro Luke Nowakowski-Krijger
2022-07-26 14:44   ` Petr Vorel
2022-07-21 20:52 ` [LTP] [PATCH v5 06/18] API/cgroup: Implement tst_cg_load_config Luke Nowakowski-Krijger
2022-07-21 20:52 ` [LTP] [PATCH v3 07/18] API/cgroup: Add more controllers to tst_cgroup Luke Nowakowski-Krijger
2022-07-21 20:52 ` [LTP] [PATCH v2 08/18] API/cgroup: refuse to mount blkio when io controller is mounted Luke Nowakowski-Krijger
2022-07-26 14:40   ` Petr Vorel
2022-07-21 20:52 ` [LTP] [PATCH v2 09/18] testcases/lib: Implement tst_cgctl binary Luke Nowakowski-Krijger
2022-07-26 12:48   ` Petr Vorel
2022-07-21 20:52 ` [LTP] [PATCH v5 10/18] controllers: Expand cgroup_lib shell library Luke Nowakowski-Krijger
2022-07-26 13:12   ` Petr Vorel
2022-07-26 19:24     ` Luke Nowakowski-Krijger
2022-07-21 20:52 ` [LTP] [PATCH v3 11/18] controllers: Update cgroup_fj_* to use newer cgroup lib and test lib Luke Nowakowski-Krijger
2022-07-25 11:41   ` Richard Palethorpe
2022-07-26  6:36     ` Li Wang
2022-07-21 20:52 ` [LTP] [PATCH v3 12/18] controllers: Update memcg_control_test to newer test lib and cgroup lib Luke Nowakowski-Krijger
2022-07-21 20:52 ` [LTP] [PATCH v3 13/18] controllers: Update memcg/regression/* to new test " Luke Nowakowski-Krijger
2022-07-21 20:52 ` [LTP] [PATCH v2 14/18] controllers: Update memcg_stress_test to use newer " Luke Nowakowski-Krijger
2022-07-21 20:52 ` [LTP] [PATCH v2 15/18] controllers: update memcg/functional " Luke Nowakowski-Krijger
2022-07-21 20:52 ` [LTP] [PATCH v3 16/18] controllers: Update pids.sh " Luke Nowakowski-Krijger
2022-07-21 20:52 ` [LTP] [PATCH v2 17/18] controllers: update cpuset_regression_test.sh " Luke Nowakowski-Krijger
2022-07-21 20:52 ` [LTP] [PATCH v3 18/18] controllers: update cgroup_regression_test " Luke Nowakowski-Krijger
2022-07-26  3:33   ` Li Wang
2022-07-25  8:14 ` [LTP] [PATCH v5 00/18] Expand Cgroup lib and modify controller tests Petr Vorel
2022-07-25 20:25   ` Luke Nowakowski-Krijger
2022-07-26 13:00     ` Petr Vorel
2022-07-26  6:10 ` Li Wang [this message]
2022-07-26  8:52   ` Richard Palethorpe
2022-07-26 16:04     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEemH2cW-yEk598waeFkDT4tkN0hoXqDwKL3LKCuzBqWfNqvUg@mail.gmail.com \
    --to=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    --cc=luke.nowakowskikrijger@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.