From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li Wang Date: Fri, 16 Jul 2021 15:06:13 +0800 Subject: [LTP] [PATCH] crypto/af_alg02: use pthread_tryjoin_np() instead of pthread_kill() In-Reply-To: <20210715102813.106843-1-aleksei.kodanev@bell-sw.com> References: <20210715102813.106843-1-aleksei.kodanev@bell-sw.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi Alexey, On Thu, Jul 15, 2021 at 6:29 PM Alexey Kodanev wrote: > musl doesn't return ESRCH for pthread_kill() if thread id is not found. > > POSIX only recommends to return ESRCH, and also says that pthread_kill() > produces undefined behavior if tid lifetime has ended [1]. > > [1]: https://man7.org/linux/man-pages/man3/pthread_kill.3.html > > Signed-off-by: Alexey Kodanev > --- > testcases/kernel/crypto/af_alg02.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/testcases/kernel/crypto/af_alg02.c > b/testcases/kernel/crypto/af_alg02.c > index 31d30777c..0f5793c16 100644 > --- a/testcases/kernel/crypto/af_alg02.c > +++ b/testcases/kernel/crypto/af_alg02.c > @@ -60,7 +60,7 @@ static void run(void) > > TST_CHECKPOINT_WAIT(0); > > - while (pthread_kill(thr, 0) != ESRCH) { > + while (pthread_tryjoin_np(thr, NULL) == EBUSY) { > I'm not sure if safe enough to use because it is nonstandard GNU extensions and the "_np" means nonportable. Maybe another workaround is to define a volatile flag 'thread_complete', initialize it to '0' when thread_B starts and reset to '1' while exit, and just do a value check in the while loop of thread_A should acquire thread_B status. Is this way a bit better? -- Regards, Li Wang -------------- next part -------------- An HTML attachment was scrubbed... URL: