On Mon, Jul 25, 2022 at 7:44 PM Richard Palethorpe <rpalethorpe@suse.de>
wrote:

>
> Luke Nowakowski-Krijger <luke.nowakowskikrijger@canonical.com> writes:
>
> > +setup()
> > +{
> > +    common_setup
>
> This can fail and we have not set pid yet.
>
> > +    cgroup_fj_proc&
> > +    pid=$!
> > +    create_subgroup "$start_path/ltp_1"
> > +}
> >
> > -ROD kill -9 $pid
> > -wait $pid
> > -ROD rmdir "$start_path/ltp_1"
> > +cleanup()
> > +{
> > +    kill -9 $pid >/dev/null 2>&1
> > +    wait $pid >/dev/null 2>&1
>
> $pid is unset so this just waits forever. We need something like the
> following:
>
>     if [ -n "$pid" ]; then
>       kill -9 $pid >/dev/null 2>&1
>       wait $pid >/dev/null 2>&1
>     fi
>
>
+1 Someone who merges patch can help fix this.

-- 
Regards,
Li Wang