All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Wang <liwang@redhat.com>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH] preadv203: set max_runtime to 270s
Date: Wed, 25 May 2022 18:16:43 +0800	[thread overview]
Message-ID: <CAEemH2cfCmR0PqpMRecS2a+789ENkz-YVupuJqN+vBDKeaSwng@mail.gmail.com> (raw)
In-Reply-To: <Yo3nAGS+R3IwYYy9@yuki>


[-- Attachment #1.1: Type: text/plain, Size: 724 bytes --]

Cyril Hrubis <chrubis@suse.cz> wrote:

Hi!
> > Before the runtime patchset preadv203 use 5min as default timeout
> > per fs, that's really long enough for prepare_device(). But after
> > that, its now only has 30s which might be short for a slower system
> > to do preparation work.
> >
> > Let's set max_runtime to 270s to make the timeout at least equal
> > to previously.
>
> Isn't the main reason why the test fails that the verify_preadv2()
> function spins for at most 60 seconds?
>

Ah, you're right!
I overlooked that spins 60s but wrongly blame the default timeout in the
library.

>
> I guess that the proper solution should be:
>

This patch works for me. I will send V2 as your suggestion.

-- 
Regards,
Li Wang

[-- Attachment #1.2: Type: text/html, Size: 1672 bytes --]

[-- Attachment #2: Type: text/plain, Size: 60 bytes --]


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2022-05-25 10:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 12:50 [LTP] LTP release preparations Cyril Hrubis
2022-05-09 13:51 ` Petr Vorel
2022-05-10  8:36 ` Li Wang
2022-05-10 13:54   ` Cyril Hrubis
2022-05-19 11:42 ` Martin Doucha
2022-05-19 12:11   ` Cyril Hrubis
2022-05-24 13:01 ` Cyril Hrubis
2022-05-25  6:51   ` [LTP] [PATCH] preadv203: set max_runtime to 270s Li Wang
2022-05-25  8:21     ` Cyril Hrubis
2022-05-25 10:16       ` Li Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEemH2cfCmR0PqpMRecS2a+789ENkz-YVupuJqN+vBDKeaSwng@mail.gmail.com \
    --to=liwang@redhat.com \
    --cc=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.