From: Li Wang <liwang@redhat.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: Martin Doucha <martin.doucha@suse.com>, LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 2/2] mkswap01: wait for the triggered events to complete
Date: Thu, 21 Apr 2022 14:44:11 +0800 [thread overview]
Message-ID: <CAEemH2d=r90AUhNzqHFc8mQFHd-eQeEHLebUaJhXNNwUVb=rpA@mail.gmail.com> (raw)
In-Reply-To: <CAEemH2dBCRC2CRERBQw_Tj6SBrCZazKg-WXrJ+4qMLR3Zp=8Dg@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1936 bytes --]
On Thu, Apr 21, 2022 at 10:18 AM Li Wang <liwang@redhat.com> wrote:
>
>
> On Thu, Apr 21, 2022 at 4:56 AM Petr Vorel <pvorel@suse.cz> wrote:
>
>
>>
>> > - udevadm trigger --name-match=$TST_DEVICE
>> > + udevadm trigger --name-match=$TST_DEVICE --settle
>>
>> > if [ -n "$device" ]; then
>> > mkswap_verify "$mkswap_op" "$op_arg" "$device" "$size"
>> "$dev_file"
>>
>> --settle option for udevadm trigger has been added in v238 (in 2018) [1].
>> This mean on SLES 12-SP5, RHEL-7.9, 18.04 LTS bionic, ... we get:
>>
>> trigger: unrecognized option '--settle'
>>
>
> Thanks for pointing out this, Petr.
>
>>
>> Do we ignore backward compatibility hoping that all distros aren't tested
>> with
>> newer LTP?
>>
>
> Actually, we only use fixed older-version of LTP for long-term supported
> distros (e.g RHEL6/7) testing, as it falls into maintaining phase and no
> new
> features are added in. So this won't be a problem for us.
>
> But if we consider fully backward compatibility of newer LTP for old
> distros,
> this is a burden to maintaining work. We might need to make a balance on
> the patch accept or reject.
>
> With regard to this simple patch, if you think it's a problem to SLES
> 12-SP5, I'm
> fine to NAK and rewrite with another way (at least for ioctl09 I will do
> that).
>
> But if you're OK with making use of fixed LTP on older distros, feel free
> to apply this one :).
>
Or, just go with the traditional way for compatibility:
--- a/testcases/commands/mkswap/mkswap01.sh
+++ b/testcases/commands/mkswap/mkswap01.sh
@@ -128,7 +128,8 @@ mkswap_test()
return
fi
- udevadm trigger --name-match=$TST_DEVICE --settle
+ udevadm trigger --name-match=$TST_DEVICE
+ udevadm settle --exit-if-exists==$TST_DEVICE
if [ -n "$device" ]; then
mkswap_verify "$mkswap_op" "$op_arg" "$device" "$size"
"$dev_file"
--
Regards,
Li Wang
[-- Attachment #1.2: Type: text/html, Size: 3905 bytes --]
[-- Attachment #2: Type: text/plain, Size: 60 bytes --]
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-04-21 6:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 11:47 [LTP] [PATCH 1/2] ioctl09: wait for udevd complete the uevent handling Li Wang
2022-04-20 11:47 ` [LTP] [PATCH 2/2] mkswap01: wait for the triggered events to complete Li Wang
2022-04-20 12:07 ` Cyril Hrubis
2022-04-20 20:56 ` Petr Vorel
2022-04-21 2:18 ` Li Wang
2022-04-21 6:44 ` Li Wang [this message]
2022-04-21 7:47 ` Petr Vorel
2022-04-20 12:05 ` [LTP] [PATCH 1/2] ioctl09: wait for udevd complete the uevent handling Cyril Hrubis
2022-04-20 12:31 ` Li Wang
2022-04-20 12:52 ` Cyril Hrubis
2022-04-21 6:36 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEemH2d=r90AUhNzqHFc8mQFHd-eQeEHLebUaJhXNNwUVb=rpA@mail.gmail.com' \
--to=liwang@redhat.com \
--cc=ltp@lists.linux.it \
--cc=martin.doucha@suse.com \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.