From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li Wang Date: Thu, 14 Nov 2019 16:36:47 +0800 Subject: [LTP] [PATCH] configure.ac: Fix --with* options In-Reply-To: <1c4d8fb5-58e4-5483-26c7-7ab38b5fbd9c@jv-coder.de> References: <20191113104149.42407-1-lkml@jv-coder.de> <1c4d8fb5-58e4-5483-26c7-7ab38b5fbd9c@jv-coder.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it On Thu, Nov 14, 2019 at 4:09 PM Joerg Vehlow wrote: > Hi, > > > > Defining AC_ARG_WITH within an if to express dependencies does not > > work. > > ./configure --with-realtime-testsuite set > with_realtime_testsuite=yes, > > even if with_bash=no or with_python=no. The check is removed > > completely. > > > > > > Or, maybe we can make use of AS_IF here? and I noticed there are many > > places that use "if test ..." in the configure.ac > > file. That looks tangly... > I left a TODO in there so it can be fixed later, maybe together with > other errors. I think this does not block merging this patch first? > Well, I just saw adding new #TODO here and hoping to solve this together, a simple way I was thinking is: +AS_IF([test "x$with_bash" != xyes || test "x$with_python" != xyes], + [with_realtime_testsuite=no] +) Of course, It's fine to fix that in a separate patch! > The python requirement for realtime-testsuite is outdated/wrong anyway, > if I remember correctly. A colleague of mine recently > investigated the python requirement and we came to the conclusion, that > it is not needed for running the test. > I think it was used only for manual test result evaluation. > So there seems to be more work regarding dependencies between configure > options. > Yes, thanks for investigating this. Looking forward to more patches :). For this one: Reviewed-by: Li Wang -- Regards, Li Wang -------------- next part -------------- An HTML attachment was scrubbed... URL: