Re: [LTP] [PATCH] io_submit01/io_submit02: Bugfix for running with the option "-i"

From: Li Wang <liwang@redhat.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
	Martin Doucha <martin.doucha@suse.com>,
	LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH] io_submit01/io_submit02: Bugfix for running with the option "-i"
Date: Fri, 8 Apr 2022 11:58:31 +0800	[thread overview]
Message-ID: <CAEemH2e4WMF98j7auOJZd8+YhKk69bZ63+sLURFLNpq6qUeCRA@mail.gmail.com> (raw)
In-Reply-To: <YkxNEjvaLAsWZSaq@pevik>

[-- Attachment #1.1: Type: text/plain, Size: 1329 bytes --]

On Tue, Apr 5, 2022 at 10:08 PM Petr Vorel <pvorel@suse.cz> wrote:

> Hi all,
>
> > For io_submit01, add io_destroy before test return, or the test
> > would fail and report EAGAIN.
> > For io_submit02, move the io_destroy to the suitable location, or
> > the test would fail and report EAGAIN.
>
> $ ./io_submit01 -i150
> ...
> io_submit01.c:122: TPASS: io_submit() with NULL iocb pointers failed with
> EFAULT
> io_submit01.c:127: TFAIL: io_submit() returned -11(EAGAIN/EWOULDBLOCK),
> expected EBADF(-9)
> io_submit01.c:127: TFAIL: io_submit() returned -11(EAGAIN/EWOULDBLOCK),
> expected EBADF(-9)
> io_submit01.c:127: TFAIL: io_submit() returned -11(EAGAIN/EWOULDBLOCK),
> expected EBADF(-9)
> io_submit01.c:127: TFAIL: io_submit() returned -11(EAGAIN/EWOULDBLOCK),
> expected SUCCESS(1)
>
> $ ./io_submit02 -i150
> ...
> io_submit02.c:76: TPASS: io_submit() returns 0 if nr is zero
> io_submit02.c:78: TFAIL: io_submit() returns -1, expected 1
>
> @Cyril, Li, Martin, Viresh: while this fix is valid using memset() (which
> is required)
> slows down testing a lot. Any idea whether this can be avoid to keep the
> speed?
>

It would not be a serious problem if only execute the test once,
I'm wondering if it really necessary to rerun many times(i.e. 150)?

BTW, the patch generally looks good to me.

-- 
Regards,
Li Wang

[-- Attachment #1.2: Type: text/html, Size: 2084 bytes --]

[-- Attachment #2: Type: text/plain, Size: 60 bytes --]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp