From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 109D2C433EF for ; Mon, 7 Mar 2022 01:45:08 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 8253E3C1BBA for ; Mon, 7 Mar 2022 02:45:06 +0100 (CET) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id D5E0E3C1B69 for ; Mon, 7 Mar 2022 02:44:55 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 85184200131 for ; Mon, 7 Mar 2022 02:44:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646617493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o6UdbjlyNMNbeQ+0aeODmM7rojQ+6o8k9u/uO/mD4N8=; b=FaAk9sRbtJpR069jwScQgGzv/NUk4dX2jT/1wv2rIGb5TdrNg/fi9KRs4Ui2IuEVTdQ+Gs pDNyAA+fjw5FGyB+UT4PBdjcbktN+RTxZ9ezfOnwgheVaDEVfowOLbOy0A2f50qOch+4Ap /Zm1SBzWyMq4gqqTfO3aHSZ0DvOe/aI= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-48-M5RT3wmlMoSzNJGoPiymSg-1; Sun, 06 Mar 2022 20:44:51 -0500 X-MC-Unique: M5RT3wmlMoSzNJGoPiymSg-1 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-2dbf52cc4b9so121410467b3.18 for ; Sun, 06 Mar 2022 17:44:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o6UdbjlyNMNbeQ+0aeODmM7rojQ+6o8k9u/uO/mD4N8=; b=YLp/8oNC3RYsOkuJlEaT8N0BLqj/RolcQB3GvmQQ/cjvTnruixDnbgmc/LQSc9ciqZ Dmf1MX48QcX5wJM07zAOHOHXvF+Tf0C7INlaMUc+Ks1c97tcdrwlmkUhPzHU8aWZJ9A/ JAJ4AbpuPduXikgp9Sm9hcb9SCpEEf+XBzk3AQtpqOpBX20RrKXyREnrih/dN4SJVdNm XkldFZrlrKiNs8d9ep3U54j2T3TbRUZbLsgd8m8MloZzymiuXVYugx5H4rZwI/S7MOmx XZ18PmDvoPgWJQHXNfFBzdD+qyULv7/fbsxMEdYz24SQs+WIxThUWspqH2AxOKpdGB6Q PF+w== X-Gm-Message-State: AOAM531oTwE2P5GbrouAhpLWZJXg01KOyYnzbpoqMbG26vOvYewo5i2X sFp6/gbYK7Lb3FDj1+FkHkvf+KFS9BBxmAPXmbqG5qCg4PuqtdCKZW0f/xjCLh6rfyk03O3TCpj ob9AnfiEmO3o5Ecx7+mazB+crdPk= X-Received: by 2002:a25:76ca:0:b0:628:759f:7990 with SMTP id r193-20020a2576ca000000b00628759f7990mr6212319ybc.273.1646617490819; Sun, 06 Mar 2022 17:44:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJxFJO94sBr+ehw4pwLWytxU8BxEoztjPRochiN6tAsMGBPIYnLqpde5nHWcJVMzjB7hAzzQN8uIK5aNeKHXQsc= X-Received: by 2002:a25:76ca:0:b0:628:759f:7990 with SMTP id r193-20020a2576ca000000b00628759f7990mr6212314ybc.273.1646617490648; Sun, 06 Mar 2022 17:44:50 -0800 (PST) MIME-Version: 1.0 References: <20220303145032.21493-1-chrubis@suse.cz> <20220303145032.21493-6-chrubis@suse.cz> In-Reply-To: From: Li Wang Date: Mon, 7 Mar 2022 09:44:37 +0800 Message-ID: To: Cyril Hrubis Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=liwan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Virus-Scanned: clamav-milter 0.102.4 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 5/7] mem/ksm06: Move ksm restoration into the tst_test struct X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: LTP List Content-Type: multipart/mixed; boundary="===============0766056165==" Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" --===============0766056165== Content-Type: multipart/alternative; boundary="0000000000009c892605d99702bb" --0000000000009c892605d99702bb Content-Type: text/plain; charset="UTF-8" On Fri, Mar 4, 2022 at 8:00 PM Cyril Hrubis wrote: > Hi! > > The mem library verifies the max_page_sharing validity before > > setting because some old kernels do not have it. Thus it is fine > > to use the prefix '?'. > > > > + "?/sys/kernel/mm/ksm/run", > > > + "?/sys/kernel/mm/ksm/merge_across_nodes", > > > + "?/sys/kernel/mm/ksm/sleep_millisecs", > > > > > > > > > But for the two knobs(run, sleep_millisecs) that should exist unless > > the kernel disables KSM. So here we'd better start with prefix '!' and > > add .needs_kconfg for ???CONFIG_KSM=y' check. > > (This also fit for other ksm tests) > > I guess that if we put ! before the merge_across_nodes that would cause > TBROK on systems without CONFIG_NUMA or kernels without that feature. > > So what about just removing the question marks there and adding > .need_kconfigs for KSM and NUMA? > Er, that's exactly what I meant in the last email, maybe you overlooked the last sentence:). i.e. " prefix ! for 'run' and 'sleep_milisecs' no prefix for 'merge_across_nodes' .need_kconfigs for KSM and NUMA " -- Regards, Li Wang --0000000000009c892605d99702bb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Fri, Mar 4, 2022 at 8:00 PM Cyril Hrubis <chrubis@suse.cz> wrote:
Hi!
> The mem library verifies the max_page_sharing validity before
> setting because some old kernels do not have it. Thus it is fine
> to use the prefix '?'.
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"?/sys/ke= rnel/mm/ksm/run",
> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"?/s= ys/kernel/mm/ksm/merge_across_nodes",
> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"?/s= ys/kernel/mm/ksm/sleep_millisecs",
> >
>
>
> But for the two knobs(run, sleep_millisecs) that should exist unless > the kernel disables KSM. So here we'd better start with prefix = 9;!' and
> add .needs_kconfg for ???CONFIG_KSM=3Dy' check.
> (This also fit for other ksm tests)

I guess that if we put ! before the merge_across_nodes that would cause
TBROK on systems without CONFIG_NUMA or kernels without that feature.

So what about just removing the question marks there and adding
.need_kconfi= gs for KSM and NUMA?

Er, that's exactly what I meant in= the last email, maybe you overlooked
the last sentence:).

i.e.

"
<= div class=3D"gmail_default" style=3D"font-size:small">=C2=A0 prefix ! for &= #39;run' and 'sleep_milisecs'
=C2=A0 no prefix for 'merge_across_nodes'= ;
=C2=A0=C2=A0<= span class=3D"gmail_default">.need_kconfigs for KSM and NUMA
"

--
Regards,
Li Wang
--0000000000009c892605d99702bb-- --===============0766056165== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- Mailing list info: https://lists.linux.it/listinfo/ltp --===============0766056165==--