From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4219EC433FE for ; Tue, 21 Dec 2021 12:35:47 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 01E3B3C9234 for ; Tue, 21 Dec 2021 13:35:45 +0100 (CET) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [IPv6:2001:4b78:1:20::4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 420DD3C9207 for ; Tue, 21 Dec 2021 13:35:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id DB6A110011DF for ; Tue, 21 Dec 2021 13:35:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1640090132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=T5iPwFQzTGdR6scHSPC7wD5QbAZaB4B1M3waHGRB15M=; b=LpEIxShTCOxPFxk0dcMc6hfY/Wh4Qsqytho7O2G0tV1zhKDpCnbXs2KUbemITpF3Q2Spe4 BWrfAJpIAiMBNNvvAFHXIxW7C3FR7e08UAnoA471gOK6jJQ/ApZ2W1bolHaJ7b/RxIZy33 /1JLRSQoeiUJo1mArEMpNw+iUr4jQRk= Received: from mail-yb1-f200.google.com (mail-yb1-f200.google.com [209.85.219.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-449-8DFmvVM6MdeE-h9JTnbIJA-1; Tue, 21 Dec 2021 07:35:30 -0500 X-MC-Unique: 8DFmvVM6MdeE-h9JTnbIJA-1 Received: by mail-yb1-f200.google.com with SMTP id t24-20020a252d18000000b005c225ae9e16so25270707ybt.15 for ; Tue, 21 Dec 2021 04:35:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=T5iPwFQzTGdR6scHSPC7wD5QbAZaB4B1M3waHGRB15M=; b=FUIeljXLWDaV7BDvlIyHZ2doE3CKS+Iy7/4o3Qtk73axTVQLOqKX+y5oEVBv+ZwKRD YAyGtwsSkkP0b5NOi9V6fnc063tbNIlhJb/XD8t67kHDJNW/2/6sfxO4Mv9HtgBt3SEF evLa97+XkjvwPdAxdUUyHavZ94WopDsV0EfP8mZLuAL6jKSxuOAPM9hIWbr8OSf/3ST/ n6Iv/ZvQDcWtzYbekZueq2Bz3BmTLNnYY4OvlDhqRCZar7qVwJq9P2kAKwHdYHu09RSI 2E29sWWzikM6eqChlstZpf+5J8z87B+uQhilyk6jaYiTj/pJSZjzBdNQhflMZGxhfOXA JiRg== X-Gm-Message-State: AOAM532RYKd/AonM4TqKCldKRPR3IkBfaF7j6KhJzRcT+WhNKwFKEKmS cX1cykihsmP3pEhHc5EZsNLD65Iu8Cili7DAIQuAULNCOulwutNHEvwMGCxlJj6T2zH4jNM4aUM Jz8Rop4KL7NNlVR5VXnRM4yll0XU= X-Received: by 2002:a25:8c9:: with SMTP id 192mr4255197ybi.102.1640090128706; Tue, 21 Dec 2021 04:35:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJzxha+q6FegFgRs4MWqNgbztNmfb+kTv9GZW7/I6eEb5Z24342Yv7SkYqYjJ/VfoIm78OPENKCKiDRLH8D0MSc= X-Received: by 2002:a25:8c9:: with SMTP id 192mr4255173ybi.102.1640090128445; Tue, 21 Dec 2021 04:35:28 -0800 (PST) MIME-Version: 1.0 From: Li Wang Date: Tue, 21 Dec 2021 20:35:17 +0800 Message-ID: To: LTP List Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=liwan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Virus-Scanned: clamav-milter 0.102.4 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: [LTP] [Question] Why test C API failed in github CI X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0654766560==" Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" --===============0654766560== Content-Type: multipart/alternative; boundary="00000000000081857b05d3a73d05" --00000000000081857b05d3a73d05 Content-Type: text/plain; charset="UTF-8" Hi Petr and all, Firstly, I'm sorry to push the patchset about oom protection cursorily. The GitHub CI complained about the following failures, I feel confused when I add a bit of debug code in my private branch then. It gets passed in access(score_path, R_OK|W_OK) but failed in closing the file and give no EACCESS errno, that's wired. Did I miss anything? https://github.com/wangli5665/ltp/runs/4594473907?check_suite_focus=true -----error log------ runtest TINFO: * test05 14tst_memutils.c:118: TWARN: Failed to close FILE '/proc/63046/oom_score_adj' 15tst_memutils.c:119: TBROK: Failed to close FILE '/proc/63046/oom_score_adj': EACCES (13) ... ---------------------- --- a/lib/tst_memutils.c +++ b/lib/tst_memutils.c @@ -111,7 +111,13 @@ static void set_oom_score_adj(pid_t pid, int value) tst_brk(TBROK, "%s does not exist, please check if PID is valid", score_path); } + //debug code + if (access(score_path, R_OK | W_OK) == -1) + tst_brk(TBROK, "%s not readable/writeable", score_path); + FILE_PRINTF(score_path, "%d", value); + SAFE_FILE_PRINTF(score_path, "%d", value); + FILE_SCANF(score_path, "%d", &val); if (val != value) { -- Regards, Li Wang --00000000000081857b05d3a73d05 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Petr and all,

Firstly, I'm sorry to push the patchset ab= out oom protection cursorily.

The GitHub CI complained about the fol= lowing failures, I feel confused
when I add a bit of debug code in my pr= ivate branch then. It gets passed
in access(score_path, R_OK|W_OK) but f= ailed in closing the file and
give no EACCESS errno, that's wired.=C2=A0

= Did I miss anything= ?

https://github.com/wangli5665/ltp/runs/45944739= 07?check_suite_focus=3Dtrue

-----error log------
runtest TINF= O: * test05
14tst_memutils.c:118: TWARN: Failed to close FILE '/proc= /63046/oom_score_adj'
15tst_memutils.c:119: TBROK: Failed to close F= ILE '/proc/63046/oom_score_adj': EACCES (13)
...
----------------------

--- a/lib/tst_mem= utils.c
+++ b/lib/tst_memutils.c
@@ -111,7 +111,13 @@ static void set= _oom_score_adj(pid_t pid, int value)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 tst_brk(TBROK, "%s do= es not exist, please check if PID is valid", score_path);
=C2=A0 = =C2=A0 =C2=A0 =C2=A0 }
=C2=A0
+ =C2=A0 =C2=A0 =C2=A0 //debug code
= + =C2=A0 =C2=A0 =C2=A0 if (access(score_path, R_OK | W_OK) =3D=3D -1)
+ = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 tst_brk(TBROK, "%s no= t readable/writeable", score_path);
+
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 FILE_PRINTF(score_path, "%d", value);
+ =C2=A0 =C2=A0 =C2= =A0 SAFE_FILE_PRINTF(score_path, "%d", value);
+
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 FILE_SCANF(score_path, "%d", &val);
=C2= =A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (val !=3D value) {


--
= Regards,
Li Wang
--00000000000081857b05d3a73d05-- --===============0654766560== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- Mailing list info: https://lists.linux.it/listinfo/ltp --===============0654766560==--