From: Li Wang <liwang@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] configure.ac: Fix --with* options
Date: Mon, 18 Nov 2019 14:38:55 +0800 [thread overview]
Message-ID: <CAEemH2etxKzetDR+NW7+5WR=h=S6KAr_SSr+E-g_XRtUNyfmQg@mail.gmail.com> (raw)
In-Reply-To: <20191118061634.GA21536@x230>
On Mon, Nov 18, 2019 at 2:16 PM Petr Vorel <pvorel@suse.cz> wrote:
> Hi,
>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>
> > Well, I just saw adding new #TODO here and hoping to solve this
> together, a
> > simple way I was thinking is:
>
> > +AS_IF([test "x$with_bash" != xyes || test "x$with_python" != xyes],
> > + [with_realtime_testsuite=no]
> > +)
>
> > Of course, It's fine to fix that in a separate patch!
>
> I'm for merging this. I just wonder if it's not better to remove
> $with_bash and
> $with_python (as part of this patch), if they're not working.
>
Me too. I think we could fix that in one patch. But as Joerg mentioned they
will be working on the #TODO. So maybe it doesn't matter to do right now or
later.
>
> BTW better, than fixing bash/shell would be to actually rewrote tests
> which are
> using python and bash to C or posix shell.
> https://github.com/linux-test-project/ltp/issues/547
>
> Kind regards,
> Petr
>
>
--
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20191118/c661b854/attachment-0001.htm>
next prev parent reply other threads:[~2019-11-18 6:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 10:41 [LTP] [PATCH] configure.ac: Fix --with* options Joerg Vehlow
2019-11-13 16:02 ` Petr Vorel
2019-11-14 3:24 ` Li Wang
2019-11-14 6:31 ` Joerg Vehlow
2019-11-14 7:59 ` Li Wang
2019-11-14 8:09 ` Joerg Vehlow
2019-11-14 8:36 ` Li Wang
2019-11-18 6:16 ` Petr Vorel
2019-11-18 6:38 ` Li Wang [this message]
2019-11-18 6:40 ` Joerg Vehlow
2019-11-18 8:59 ` Petr Vorel
2019-11-18 20:41 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEemH2etxKzetDR+NW7+5WR=h=S6KAr_SSr+E-g_XRtUNyfmQg@mail.gmail.com' \
--to=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.