From: Li Wang <liwang@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 1/7] fzsync: Add self tests
Date: Mon, 12 Apr 2021 21:57:03 +0800 [thread overview]
Message-ID: <CAEemH2f1OtzmP+Vh+afVHuZvHNZSq0kwG0HrK79z7THEu1smmQ@mail.gmail.com> (raw)
In-Reply-To: <20210319091837.27319-2-rpalethorpe@suse.com>
> +/* The time signatures of threads A and B */
> +struct race {
> + const struct window a;
> + const struct window b;
> +};
> +
> +static int c;
>
Maybe define a volatile 'c' here will be better?
> +
> + tst_res(critical > 50 ? TPASS : TFAIL,
> + "cs:%-2d ct:%-2d rt:%-2d | =:%-4d -:%-4d +:%-4d",
> + a.critical_s, a.critical_t, a.return_t,
>
A tiny issue on output is, 'a.critical_s' abbreviate to 'cs' which
has duplicated name with above variable, a bit confused for me
a while:).
Anyway, the patches look quite good to me.
Reviewed-by: Li Wang <liwang@redhat.com>
--
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20210412/6d91fb31/attachment.htm>
next prev parent reply other threads:[~2021-04-12 13:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 9:18 [LTP] [PATCH v3 0/7] Fuzzy Sync single core support and tests Richard Palethorpe
2021-03-19 9:18 ` [LTP] [PATCH v3 1/7] fzsync: Add self tests Richard Palethorpe
2021-04-08 15:13 ` Cyril Hrubis
2021-04-09 9:34 ` Richard Palethorpe
2021-04-12 13:57 ` Li Wang [this message]
2021-04-13 6:42 ` Richard Palethorpe
2021-03-19 9:18 ` [LTP] [PATCH v3 2/7] fzsync: Reset delay bias Richard Palethorpe
2021-04-07 15:38 ` Cyril Hrubis
2021-03-19 9:18 ` [LTP] [PATCH v3 3/7] fzsync: Correctly print positive lower delay range bound Richard Palethorpe
2021-04-07 15:40 ` Cyril Hrubis
2021-03-19 9:18 ` [LTP] [PATCH v3 4/7] fzsync: Add sched_yield for single core machine Richard Palethorpe
2021-03-19 9:18 ` [LTP] [PATCH v3 5/7] fzsync: Move yield check out of loop and add yield to delay Richard Palethorpe
2021-04-08 12:45 ` Cyril Hrubis
2021-03-19 9:18 ` [LTP] [PATCH v3 6/7] API: Add tst_ncpus_available Richard Palethorpe
2021-04-07 15:39 ` Cyril Hrubis
2021-03-19 9:18 ` [LTP] [PATCH v3 7/7] fzsync: Check processor affinity Richard Palethorpe
2021-04-08 12:47 ` Cyril Hrubis
2021-04-09 7:18 ` Li Wang
2021-04-09 9:50 ` Richard Palethorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEemH2f1OtzmP+Vh+afVHuZvHNZSq0kwG0HrK79z7THEu1smmQ@mail.gmail.com \
--to=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.