On Mon, Sep 19, 2022 at 4:26 PM Cyril Hrubis <chrubis@suse.cz> wrote:

> Hi!
> > > tst_pollute_memory() consume time is proportional to the amount of
> > > free RAM, it is hard to find one fixed value of max_runtime to fit all
> test
> > > platforms.
> > >
> > > From my experience, if you limited this test only run with small
> > > machine (e.g. RAM <= 32G), that performs well with whatever
> > > bare metal or VM, no timeout ever.
> > >
> >
> > Btw, we did that by setting a test filter before LTP running, also we
> could
> > add a field .max_mem_avail to tst_test struct for achieving that, but not
> > sure if it's worth doing that at this moment.
>
> The proper solution will be adding a separate timeouts for setup/cleanup
> and limiting the setup runtime to something sensible, but that is
>

Separate timeouts for setup/cleanup will break the integrity of
setting functions, my concern is that if tst_pollute_memory stopped
in uncompleted, the main test part is meaningless, right?

Or, I may misunderstand you here.



> something for the next development cycle.
>

+1

-- 
Regards,
Li Wang