From: Li Wang <liwang@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] Rename tst_test_* to tst_require_*
Date: Fri, 11 Oct 2019 21:28:46 +0800 [thread overview]
Message-ID: <CAEemH2fSuRR-7HFeLBMw_6zo2bhWW88ckq468S9XhgzAG_mPFw@mail.gmail.com> (raw)
In-Reply-To: <1570799029.4238.15.camel@suse.de>
On Fri, Oct 11, 2019 at 9:03 PM Clemens Famulla-Conrad <
cfamullaconrad@suse.de> wrote:
> On Fri, 2019-10-11 at 12:06 +0200, Petr Vorel wrote:
> > Hi,
> >
> > Cc: Li and Clemens
> >
> > > these patches rename tst_test_* to tst_require_*, to better
> > > describe
> > > their use. There is also tst_require_root, that has the same
> > > behavior: It also calls tst_brk in case of a failing requirement.
> > > You can also get this patch from the following repo:
> > > https://github.com/MofX/ltp/commits/rename_tst_test-tst_require
> >
> > sorry for not thinking first, I wonder if we want to sync
> > tst_test_* (function name) vs $TST_NEEDS_* (test API variable name),
> > e.g.: tst_require_drivers $TST_NEEDS_DRIVERS
>
> I fully agree with Petr that we must be consistent in naming between
> variable- and function-name.
>
+1
>
> >
> > i.e. either of these:
> > s/tst_test_/tst_needs_/
> > s/TST_NEEDS_/TST_REQUIRE_/
> >
> > I consider *require* as more descriptive than *needs*,
> > but changing to *require* would require more work :).
>
> If we use needs or require ? Hard question - when I search for synonyms
> from one or the other, I don't see a big different. Without looking on
> the impact, require sounds also more descriptive.
>
Yes, I have the same feeling here.
FYI:
needs: because it's important
require: because it's a necessity
https://www.englishcurrent.com/grammar/difference-need-require-verbs/
--
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20191011/f0a81006/attachment-0001.htm>
next prev parent reply other threads:[~2019-10-11 13:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 9:07 [LTP] Rename tst_test_* to tst_require_* Joerg Vehlow
2019-10-11 9:07 ` [LTP] [PATCH 1/2] shell: Rename s/tst_test_cmds/tst_require_cmds/ Joerg Vehlow
2019-10-11 9:07 ` [LTP] [PATCH 2/2] shell: Rename s/tst_test_drivers/tst_require_drivers/ Joerg Vehlow
2019-10-11 10:06 ` [LTP] Rename tst_test_* to tst_require_* Petr Vorel
2019-10-11 12:36 ` Cyril Hrubis
2019-10-11 13:03 ` Clemens Famulla-Conrad
2019-10-11 13:10 ` Cyril Hrubis
2019-10-11 14:00 ` Petr Vorel
2019-10-24 12:28 ` Cyril Hrubis
2019-10-24 12:48 ` Petr Vorel
2019-11-06 16:26 ` Cyril Hrubis
2019-11-06 17:01 ` Petr Vorel
2019-11-07 11:09 ` Petr Vorel
2019-11-07 11:32 ` Petr Vorel
2019-10-11 13:28 ` Li Wang [this message]
2019-10-11 13:39 ` Joerg Vehlow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEemH2fSuRR-7HFeLBMw_6zo2bhWW88ckq468S9XhgzAG_mPFw@mail.gmail.com \
--to=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.