From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 021DD3D7B for ; Fri, 6 May 2022 22:29:01 +0000 (UTC) Received: by mail-il1-f173.google.com with SMTP id z12so5664452ilp.8 for ; Fri, 06 May 2022 15:29:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zwndxwZpt7KSFoHB/JllAwgCIQTy+eDrSST89tNr+rw=; b=ZpTIt5r3YNWAFCPuKwEPGE1ECe/A6pVYLXW7cHkPiOfdva23H2S1bFvkci9mZvoXaJ Kj1N5XAuIQ+zAqmhgMDfoZXgfrZApaETBzC6i0GE8C3cQPu5m761+iVctsMTxYtftuKs 6Q5MYuuSa9aB+JvGdmDlNqka3JEJ2LBi6zwlY3U7agZj0t8P5g66ZetDF3noo9bVL5t2 rVa7ukJXMAI3MYojV6HR23NOCfz00F9HhsrpV3RKu2C+mf/FpPR4aJ8jp2NuzOmJ90M/ Udy9wBY6k0dYtfzFh7EQB9DtSSqUeBCi9OeOqeHfYtRTuPx5PF4gpQ0Qc/qas0ccmTRW 3rbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zwndxwZpt7KSFoHB/JllAwgCIQTy+eDrSST89tNr+rw=; b=5uLCaq5xbHWIsDgypqLJSqbYTD8sDNBWwD0+u6beu/nMqIBjQ5NsL7pgcHyZC2EyQr xhdw1WsgczlykDayJFsx/BqJO2+7pm3JWQZo/ErUQti89Bs5TrzBhDRkwafdxFVbRIBt a+xRzhTp2xCjERfLCxr4DM0Tlyt5aO7gHtIYJNsQJ8CW3FknpeBjj25TWk0mwp5mUxb4 EMkJmNWHT/mmWW2GskVanIBQgWQsTd6GNvw5NPdEh+5t0/1Krj6QmVWqpNC8hL0psJBB nTziW25RQ2vdXq8mPoNMKN8Twvh9I+oYpT6G2k0Gfs4cyagaJ3iBkOip3wZJyfIm1p7R bwuA== X-Gm-Message-State: AOAM531EgcEBVjGU5wKopvgcRWTOc1em6gZW7Quiy2U0mYr56aPVj+Rs ho/qcK33d43KDgTkFYnc+6d5N0S4lMBY5rGti2Q= X-Google-Smtp-Source: ABdhPJz0iJf3Bm4SpkdUJSGvP7ctgom6SdZiNH5T/y1ubDp7Y/sx0N5yMMh7WxL0OxCq91+ofkdt0GN+fNf23hGvFXs= X-Received: by 2002:a92:cd8b:0:b0:2cf:90f9:30e0 with SMTP id r11-20020a92cd8b000000b002cf90f930e0mr15562ilb.252.1651876141122; Fri, 06 May 2022 15:29:01 -0700 (PDT) Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20220502211235.142250-1-mathew.j.martineau@linux.intel.com> In-Reply-To: <20220502211235.142250-1-mathew.j.martineau@linux.intel.com> From: Andrii Nakryiko Date: Fri, 6 May 2022 15:28:50 -0700 Message-ID: Subject: Re: [PATCH bpf-next v3 0/8] bpf: mptcp: Support for mptcp_sock and is_mptcp To: Mat Martineau Cc: Networking , bpf , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , mptcp@lists.linux.dev Content-Type: text/plain; charset="UTF-8" On Mon, May 2, 2022 at 2:12 PM Mat Martineau wrote: > > This patch set adds BPF access to the is_mptcp flag in tcp_sock and > access to mptcp_sock structures, along with associated self tests. You > may recognize some of the code from earlier > (https://lore.kernel.org/bpf/20200918121046.190240-6-nicolas.rybowski@tessares.net/) > but it has been reworked quite a bit. > > > v1 -> v2: Emit BTF type, add func_id checks in verifier.c and bpf_trace.c, > remove build check for CONFIG_BPF_JIT, add selftest check for CONFIG_MPTCP, > and add a patch to include CONFIG_IKCONFIG/CONFIG_IKCONFIG_PROC for the > BPF self tests. > > v2 -> v3: Access sysctl through the filesystem to work around CI use of > the more limited busybox sysctl command. > > > Geliang Tang (6): > bpf: add bpf_skc_to_mptcp_sock_proto > selftests: bpf: Enable CONFIG_IKCONFIG_PROC in config > selftests: bpf: test bpf_skc_to_mptcp_sock > selftests: bpf: verify token of struct mptcp_sock > selftests: bpf: verify ca_name of struct mptcp_sock > selftests: bpf: verify first of struct mptcp_sock > It would be nice to use more consistent with the majority of other commits "selftests/bpf: " prefix. Thank you. > Nicolas Rybowski (2): > bpf: expose is_mptcp flag to bpf_tcp_sock > selftests: bpf: add MPTCP test base > > MAINTAINERS | 2 + > include/linux/bpf.h | 1 + > include/linux/btf_ids.h | 3 +- > include/net/mptcp.h | 6 + > include/uapi/linux/bpf.h | 8 + > kernel/bpf/verifier.c | 1 + > kernel/trace/bpf_trace.c | 2 + > net/core/filter.c | 27 +- > net/mptcp/Makefile | 2 + > net/mptcp/bpf.c | 22 ++ > scripts/bpf_doc.py | 2 + > tools/include/uapi/linux/bpf.h | 8 + > .../testing/selftests/bpf/bpf_mptcp_helpers.h | 17 ++ > tools/testing/selftests/bpf/bpf_tcp_helpers.h | 4 + > tools/testing/selftests/bpf/config | 3 + > tools/testing/selftests/bpf/network_helpers.c | 43 ++- > tools/testing/selftests/bpf/network_helpers.h | 4 + > .../testing/selftests/bpf/prog_tests/mptcp.c | 272 ++++++++++++++++++ > .../testing/selftests/bpf/progs/mptcp_sock.c | 80 ++++++ > 19 files changed, 497 insertions(+), 10 deletions(-) > create mode 100644 net/mptcp/bpf.c > create mode 100644 tools/testing/selftests/bpf/bpf_mptcp_helpers.h > create mode 100644 tools/testing/selftests/bpf/prog_tests/mptcp.c > create mode 100644 tools/testing/selftests/bpf/progs/mptcp_sock.c > > > base-commit: 20b87e7c29dffcfa3f96f2e99daec84fd46cabdb > -- > 2.36.0 >