From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: John Fastabend <john.fastabend@gmail.com>
Cc: Roman Gushchin <guro@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [bpf-next PATCH] bpf, selftests: use ::1 for localhost in tcp_server.py
Date: Tue, 28 Jul 2020 11:39:39 -0700 [thread overview]
Message-ID: <CAEf4BzYVb1NY=GxBCqTWS1e7_+pbOXg3GsM+JXsGNZS30MGyQQ@mail.gmail.com> (raw)
In-Reply-To: <159594714197.21431.10113693935099326445.stgit@john-Precision-5820-Tower>
On Tue, Jul 28, 2020 at 7:40 AM John Fastabend <john.fastabend@gmail.com> wrote:
>
> Using localhost requires the host to have a /etc/hosts file with that
> specific line in it. By default my dev box did not, they used
> ip6-localhost, so the test was failing. To fix remove the need for any
> /etc/hosts and use ::1.
>
> I could just add the line, but this seems easier.
>
> Signed-off-by: John Fastabend <john.fastabend@gmail.com>
> ---
Makes sense.
Acked-by: Andrii Nakryiko <andriin@fb.com>
> tools/testing/selftests/bpf/tcp_client.py | 2 +-
> tools/testing/selftests/bpf/tcp_server.py | 2 +-
> tools/testing/selftests/bpf/test_netcnt.c | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
[...]
next prev parent reply other threads:[~2020-07-28 18:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 14:39 [bpf-next PATCH] bpf, selftests: use ::1 for localhost in tcp_server.py John Fastabend
2020-07-28 17:44 ` Song Liu
2020-07-28 18:39 ` Andrii Nakryiko [this message]
2020-07-28 22:28 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4BzYVb1NY=GxBCqTWS1e7_+pbOXg3GsM+JXsGNZS30MGyQQ@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=guro@fb.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.