All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: "Daniel Borkmann" <daniel@iogearbox.net>,
	"Stanislav Fomichev" <sdf@google.com>,
	"Toke Høiland-Jørgensen" <toke@redhat.com>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"Martin KaFai Lau" <martin.lau@linux.dev>,
	"Song Liu" <song@kernel.org>, "Yonghong Song" <yhs@fb.com>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"KP Singh" <kpsingh@kernel.org>, "Hao Luo" <haoluo@google.com>,
	"Jiri Olsa" <jolsa@kernel.org>, bpf <bpf@vger.kernel.org>,
	"David Vernet" <void@manifault.com>,
	"Jesper Dangaard Brouer" <brouer@redhat.com>
Subject: Re: [RFC PATCH v2] Documentation/bpf: Add a description of "stable kfuncs"
Date: Tue, 24 Jan 2023 11:54:49 -0800	[thread overview]
Message-ID: <CAEf4BzZ-CuxBq8U953bfwzQVJn6YA2z4OnvnG47qZ11JLZ68Eg@mail.gmail.com> (raw)
In-Reply-To: <CAEf4BzbAt_Yp-GkAr3Ov4x_v2cawzuJXC5ux4NA-FZ2rv6PCAg@mail.gmail.com>

On Tue, Jan 24, 2023 at 9:17 AM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
>
> On Wed, Jan 18, 2023 at 8:32 PM Alexei Starovoitov
> <alexei.starovoitov@gmail.com> wrote:
> >
> > On Wed, Jan 18, 2023 at 11:48:59AM +0100, Daniel Borkmann wrote:
> > >
> > > My $0.02 is that I don't think we need to make a hard-cut ban as part of this.
> >
> > The hard-cut is easier to enforce otherwise every developer will be arguing that
> > their new feature is special and it requires a new discussion.
> > This thread has been going for too long. We need to finish it now and
> > don't come back to it again every now and then.
>
> I wish that we could grant exception at least to complete dynptr
> basics (bpf_dynptr_is_null, bpf_dynptr_get_size,
> bpf_dynptr_{clone,trim,advance}) so that it is consistently provided
> as a unified set of helpers. Similarly, for open coded loop iterator
> (3 helpers), I believe it would be better for BPF ecosystem overall to
> work on any BPF-enabled architecture and configuration (no matter JIT
> or not, BTF of not, etc), just due to generality and unassuming nature
> of this functionality.
>
> But it is what it is, let's move on.

Just to expand a bit on the above and make it clearer. I don't like a
hard-cut ban on helpers, but I'll disagree and commit and will move
open-coded iterators to kfuncs. And whoever is waiting on the helpers
vs kfuncs decision should stop waiting and use kfuncs.


[...]

  reply	other threads:[~2023-01-24 19:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-17 21:27 [RFC PATCH v2] Documentation/bpf: Add a description of "stable kfuncs" Toke Høiland-Jørgensen
2023-01-17 21:53 ` Stanislav Fomichev
2023-01-17 22:03   ` Toke Høiland-Jørgensen
2023-01-17 22:20     ` Stanislav Fomichev
2023-01-17 23:19       ` Alexei Starovoitov
2023-01-18  2:00         ` Stanislav Fomichev
2023-01-18 10:48           ` Daniel Borkmann
2023-01-18 16:53             ` David Vernet
2023-01-19  4:32             ` Alexei Starovoitov
2023-01-24 17:17               ` Andrii Nakryiko
2023-01-24 19:54                 ` Andrii Nakryiko [this message]
2023-01-25  1:18               ` Toke Høiland-Jørgensen
2023-01-26  5:34                 ` Alexei Starovoitov
2023-01-27 17:50                   ` Toke Høiland-Jørgensen
2023-01-18 15:53 ` David Vernet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEf4BzZ-CuxBq8U953bfwzQVJn6YA2z4OnvnG47qZ11JLZ68Eg@mail.gmail.com \
    --to=andrii.nakryiko@gmail.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=brouer@redhat.com \
    --cc=daniel@iogearbox.net \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=sdf@google.com \
    --cc=song@kernel.org \
    --cc=toke@redhat.com \
    --cc=void@manifault.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.