From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Jakub Sitnicki <jakub@cloudflare.com>
Cc: bpf <bpf@vger.kernel.org>, Networking <netdev@vger.kernel.org>,
kernel-team@cloudflare.com
Subject: Re: [PATCH bpf-next 1/3] flow_dissector: Pull BPF program assignment up to bpf-netns
Date: Mon, 22 Jun 2020 23:02:49 -0700 [thread overview]
Message-ID: <CAEf4BzZ0_01j4g-APS9HQ-jqKf3=qTerYWCkRmYscWWo2R0xwg@mail.gmail.com> (raw)
In-Reply-To: <20200622160300.636567-2-jakub@cloudflare.com>
On Mon, Jun 22, 2020 at 9:03 AM Jakub Sitnicki <jakub@cloudflare.com> wrote:
>
> Prepare for using bpf_prog_array to store attached programs by moving out
> code that updates the attached program out of flow dissector.
>
> Managing bpf_prog_array is more involved than updating a single bpf_prog
> pointer. This will let us do it all from one place, bpf/net_namespace.c, in
> the subsequent patch.
>
> No functional change intended.
>
> Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com>
> ---
LGTM.
Acked-by: Andrii Nakryiko <andriin@fb.com>
> include/net/flow_dissector.h | 3 ++-
> kernel/bpf/net_namespace.c | 20 ++++++++++++++++++--
> net/core/flow_dissector.c | 13 ++-----------
> 3 files changed, 22 insertions(+), 14 deletions(-)
>
[...]
next prev parent reply other threads:[~2020-06-23 6:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 16:02 [PATCH bpf-next 0/3] bpf, netns: Prepare for multi-prog attachment Jakub Sitnicki
2020-06-22 16:02 ` [PATCH bpf-next 1/3] flow_dissector: Pull BPF program assignment up to bpf-netns Jakub Sitnicki
2020-06-23 6:02 ` Andrii Nakryiko [this message]
2020-06-22 16:02 ` [PATCH bpf-next 2/3] bpf, netns: Keep attached programs in bpf_prog_array Jakub Sitnicki
2020-06-23 6:23 ` Andrii Nakryiko
2020-06-23 10:51 ` Jakub Sitnicki
2020-06-22 16:03 ` [PATCH bpf-next 3/3] bpf, netns: Keep a list of attached bpf_link's Jakub Sitnicki
2020-06-23 6:26 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4BzZ0_01j4g-APS9HQ-jqKf3=qTerYWCkRmYscWWo2R0xwg@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=jakub@cloudflare.com \
--cc=kernel-team@cloudflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.