All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Stanislav Fomichev <sdf@google.com>
Cc: Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>, Yonghong Song <yhs@fb.com>
Subject: Re: [PATCH bpf-next v2] selftests/bpf: move netcnt test under test_progs
Date: Mon, 2 Aug 2021 17:32:06 -0700	[thread overview]
Message-ID: <CAEf4BzZZCzfywqLRK8Jodzf-XmRrKHRTsqGGE_erXdxm+coxqg@mail.gmail.com> (raw)
In-Reply-To: <20210802173951.2818349-1-sdf@google.com>

On Mon, Aug 2, 2021 at 10:39 AM Stanislav Fomichev <sdf@google.com> wrote:
>
> Rewrite to skel and ASSERT macros as well while we are at it.
>
> v2:
> - don't check result of bpf_map__fd (Yonghong Song)
> - remove from .gitignore (Andrii Nakryiko)
> - move ping_command into network_helpers (Andrii Nakryiko)
> - remove assert() (Andrii Nakryiko)
>
> Signed-off-by: Stanislav Fomichev <sdf@google.com>
> Acked-by: Yonghong Song <yhs@fb.com>
> ---

netcnt selftest is failing in our CI ([0]), PTAL. xdp_context_test_run
failure is unrelated, ignore that one.

  [0] https://github.com/kernel-patches/bpf/runs/3225481504?check_suite_focus=true

>  tools/testing/selftests/bpf/.gitignore        |   1 -
>  tools/testing/selftests/bpf/Makefile          |   3 +-
>  tools/testing/selftests/bpf/network_helpers.c |  12 ++
>  tools/testing/selftests/bpf/network_helpers.h |   1 +
>  .../testing/selftests/bpf/prog_tests/netcnt.c |  82 ++++++++++
>  .../selftests/bpf/prog_tests/tc_redirect.c    |  12 --
>  tools/testing/selftests/bpf/test_netcnt.c     | 148 ------------------
>  7 files changed, 96 insertions(+), 163 deletions(-)
>  create mode 100644 tools/testing/selftests/bpf/prog_tests/netcnt.c
>  delete mode 100644 tools/testing/selftests/bpf/test_netcnt.c
>

[...]

      reply	other threads:[~2021-08-03  0:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02 17:39 [PATCH bpf-next v2] selftests/bpf: move netcnt test under test_progs Stanislav Fomichev
2021-08-03  0:32 ` Andrii Nakryiko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEf4BzZZCzfywqLRK8Jodzf-XmRrKHRTsqGGE_erXdxm+coxqg@mail.gmail.com \
    --to=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=netdev@vger.kernel.org \
    --cc=sdf@google.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.