From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1F9CC433E0 for ; Tue, 26 May 2020 22:32:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CDA6620899 for ; Tue, 26 May 2020 22:32:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TEAjwDPe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390038AbgEZWcW (ORCPT ); Tue, 26 May 2020 18:32:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389482AbgEZWcW (ORCPT ); Tue, 26 May 2020 18:32:22 -0400 Received: from mail-qv1-xf44.google.com (mail-qv1-xf44.google.com [IPv6:2607:f8b0:4864:20::f44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17749C061A0F for ; Tue, 26 May 2020 15:32:22 -0700 (PDT) Received: by mail-qv1-xf44.google.com with SMTP id ee19so10282106qvb.11 for ; Tue, 26 May 2020 15:32:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4MuLB3Y5BDOYSMiMLlCiBkQT07E50QnXceZRsKX1T6I=; b=TEAjwDPec8jTSFJay+hTMc8FOse6ks/ptXNiCwVyoCWF81IpjAblRVcRw9S+b0MJBo G1HDR8xUVfq7L6GGV0P9SvfxaxvDLCgxtisaUoTDHZQjkAKyJRkB7aZwzlsomJoBSYie oeVjHO7NTQr6Yhh1W2OWt/nOn8SSmRDeIzsI5r3FcG9S04+/2iRiRfOYG+nRdks3wD4e ROAOQvKJTxLujP7JJo54wrgh54J0cowuf0lUKeY9lyuu2GmjcdSip8zEDpxzCyOetLy2 6tJTNwxFe7NoZX0ECSZxmBNNeamK0AQarMhfAacNDH4shsUjD+EE5LIBw8XKVBKNuYx6 jwng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4MuLB3Y5BDOYSMiMLlCiBkQT07E50QnXceZRsKX1T6I=; b=i54Y73cAmZNk6HGh7d/9gtMbOe++47gpO9RFu8k2zIifoS/azNm6QOTU8fqwE9jn8y s8t8sGmdp2/bKijNyopYsil/jtPam67wMk+Fdhhsav42uNyMc6WUdiWRFTry2m8bfv5D 2dFzBNKnWv5GTKliBX6ucQMB8/Q7YTTVVFbRx6ms0n9UekueBBp7G7zE88xU3LxHCjv3 MXPxOfvdctyXvI11rGiuSOMS3vhMnuQUWlXiel02zl3xOigZTTb8V8gcPlZVAVHxihki DQtdHFT6ZbHLo3fBoCoSV7qgQUZ5cBg5iZcoXpAC6r+gnBIcsszCUvoMXA8HmEnPM/B7 7J4g== X-Gm-Message-State: AOAM530Eix5uljm+9vZXFQEUHIwlOVhX52BKSNj4xCFgTPwtLqLxcpR+ GSm901QHy+PjKNoMD/mLdkt7E1jiIpTh1yZWaTM= X-Google-Smtp-Source: ABdhPJyA8UAZB36juvAxHrFCg//aJSRXoIw4ZbnZx3TAzMCeBBbIeyC+lNW8OYx3DK9aodcKVBYxQaWgQLXUVR6mA4U= X-Received: by 2002:ad4:588c:: with SMTP id dz12mr22444111qvb.196.1590532341287; Tue, 26 May 2020 15:32:21 -0700 (PDT) MIME-Version: 1.0 References: <20200522041310.233185-1-yauheni.kaliuta@redhat.com> In-Reply-To: From: Andrii Nakryiko Date: Tue, 26 May 2020 15:32:10 -0700 Message-ID: Subject: Re: [PATCH 0/8] selftests/bpf: installation and out of tree build fixes To: Yauheni Kaliuta Cc: bpf , Jiri Benc , Jiri Olsa , Andrii Nakryiko , Daniel Borkmann Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu, May 21, 2020 at 11:41 PM Yauheni Kaliuta wrote: > > > Actually, a bit more needed :) >From the other kselftest thread, it seems like selftests are not supporting builds out-of-tree. With that, wouldn't it be simpler to build in tree and then just copy selftests/bpf directory to wherever you need to run tests from? It would be simple and reliable. Given I and probably everyone else never build and run tests out-of-tree, it's just too easy to break this and you'll be constantly chasing some non-obvious breakages... Is there some problem with such approach? > > >>>>> On Fri, 22 May 2020 07:13:02 +0300, Yauheni Kaliuta wrote: > > > I had a look, here are some fixes. > > Yauheni Kaliuta (8): > > selftests/bpf: remove test_align from Makefile > > selftests/bpf: build bench.o for any $(OUTPUT) > > selftests/bpf: install btf .c files > > selftests/bpf: fix object files installation > > selftests/bpf: add output dir to include list > > selftests/bpf: fix urandom_read installation > > selftests/bpf: fix test.h placing for out of tree build > > selftests/bpf: factor out MKDIR rule > > > tools/testing/selftests/bpf/Makefile | 77 ++++++++++++++++++++-------- > > 1 file changed, 55 insertions(+), 22 deletions(-) > > > -- > > 2.26.2 > > > -- > WBR, > Yauheni Kaliuta >