From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50908C433F5 for ; Thu, 12 May 2022 03:08:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244689AbiELDIg (ORCPT ); Wed, 11 May 2022 23:08:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229940AbiELDIe (ORCPT ); Wed, 11 May 2022 23:08:34 -0400 Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A0EA37A9F for ; Wed, 11 May 2022 20:08:28 -0700 (PDT) Received: by mail-io1-xd2a.google.com with SMTP id s23so3990257iog.13 for ; Wed, 11 May 2022 20:08:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gH9nt5Z+twTdMet/u1CbVcZ/HwvokShMe4DYq6ey1ws=; b=mjMITYrwuNjiAOOqoIxqXih5BdpaOxAsbI7ApWL3j76DWOqf7508gYyxJIIbRZHM3/ hWRyJ0onJGseJj944QZUHurAu/1hWuRj3kFWHifwYs52FzhciCjL/O6QkAuxYcatIwpC 6fGf0au6lyF9GXClcJ6HK3dfvnLLpcOtrMMzgZmscZeYCtBEAvZ47RCHEdOPLl7FwGkG lG8iTSHWH4i7PPtPocTkfmzdPuBbY0BHUOHm/dDx1z1tNfZllNrsf5XJJddz52FD5pHa krV1mi4Q4ni1HZrKzm7C9gQk6fcEOeRGwoVsz50dOHQeStrljBG5FY1KWW5kRjJg0I4E Kssg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gH9nt5Z+twTdMet/u1CbVcZ/HwvokShMe4DYq6ey1ws=; b=y1IV3LusFnK+H5i8toeSr6xLmccmZlXCJNuGW6mUGrHZvET2V6Ne3loyNj9cbz1oqc 2d41OQH6ummnvatcpCuCXKVy9qFbNMG5YXYyvBhP4apWPADV6+JG3ia0PW94beIvrCe6 j0bLsFYRU3x/EJeNiBNTQb+zrtzs8FGIgf4Eokk4QWE7+Myem5X7D8gYGFL1I67l8+gT 4sysSbeFprrvfNwuaXoL6SnHxMENMMnH3K05iw7q08miuyPgC1/j3N8HIl6ENDAZuWw3 B5zP26yBvUY/yGvwEef92HWYEMLDx6eWWmk8ge5FWqXhFfWojGl90tv9rOStLuFoZ9Jz UG6w== X-Gm-Message-State: AOAM531frb4SsJBDEd4ipiD+kXUf8FqUuFx1MbRDF1Ex9/85DJDhdtuZ /CrIvyx6rUvS7eWbKJeydFvQHibhCr9FQ+c0g1DLGGYe X-Google-Smtp-Source: ABdhPJz29dthggp3OqY26f+HrxsBqjupDoVbWtj1xSB0tAau8/xFN2KfBeO0xTA8mgNoJx5oX2XcYobL9iInpwlGWvQ= X-Received: by 2002:a05:6638:533:b0:32a:d418:b77b with SMTP id j19-20020a056638053300b0032ad418b77bmr13919738jar.237.1652324907569; Wed, 11 May 2022 20:08:27 -0700 (PDT) MIME-Version: 1.0 References: <20220511194654.765705-1-memxor@gmail.com> <20220511194654.765705-4-memxor@gmail.com> In-Reply-To: <20220511194654.765705-4-memxor@gmail.com> From: Andrii Nakryiko Date: Wed, 11 May 2022 20:08:16 -0700 Message-ID: Subject: Re: [PATCH bpf-next v2 3/4] selftests/bpf: Add negative C tests for kptrs To: Kumar Kartikeya Dwivedi Cc: bpf , Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, May 11, 2022 at 12:46 PM Kumar Kartikeya Dwivedi wrote: > > This uses the newly added SEC("?foo") naming to disable autoload of > programs, and then loads them one by one for the object and verifies > that loading fails and matches the returned error string from verifier. > This is similar to already existing verifier tests but provides coverage > for BPF C. > > Signed-off-by: Kumar Kartikeya Dwivedi > --- > .../selftests/bpf/prog_tests/map_kptr.c | 87 +++- > .../selftests/bpf/progs/map_kptr_fail.c | 418 ++++++++++++++++++ > 2 files changed, 504 insertions(+), 1 deletion(-) > create mode 100644 tools/testing/selftests/bpf/progs/map_kptr_fail.c > [...] > + > +static void test_map_kptr_success(void) > { > struct map_kptr *skel; > int key = 0, ret; > @@ -35,3 +113,10 @@ void test_map_kptr(void) > > map_kptr__destroy(skel); > } > + > +void test_map_kptr(void) > +{ > + if (test__start_subtest("success")) > + test_map_kptr_success(); > + test_map_kptr_fail(); I think the intent for this was to be another subtest, right? Worth fixing in a follow up? > +} > diff --git a/tools/testing/selftests/bpf/progs/map_kptr_fail.c b/tools/testing/selftests/bpf/progs/map_kptr_fail.c > new file mode 100644 > index 000000000000..05e209b1b12a > --- /dev/null > +++ b/tools/testing/selftests/bpf/progs/map_kptr_fail.c > @@ -0,0 +1,418 @@ [...]