From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Alexei Starovoitov <ast@fb.com>
Cc: Andrii Nakryiko <andriin@fb.com>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH v4 bpf-next 6/7] libbpf: add BPF_CORE_READ/BPF_CORE_READ_INTO helpers
Date: Tue, 8 Oct 2019 09:53:49 -0700 [thread overview]
Message-ID: <CAEf4Bza8d+O0dRZy5NkQbpA-Fnk32PhZK2wqJxJw=Ve9eYUwUA@mail.gmail.com> (raw)
In-Reply-To: <5411bdae-a723-6dd3-d35a-8ec825924b4e@fb.com>
On Tue, Oct 8, 2019 at 8:10 AM Alexei Starovoitov <ast@fb.com> wrote:
>
> On 10/7/19 11:15 PM, Andrii Nakryiko wrote:
> >>> +#define BPF_CORE_READ(src, a, ...) \
> >>> + ({ \
> >>> + ___type(src, a, ##__VA_ARGS__) __r; \
> >>> + BPF_CORE_READ_INTO(&__r, src, a, ##__VA_ARGS__); \
> >>> + __r; \
> >>> + })
> >>> +
> >> Since we're splitting things into
> >> bpf_{helpers,helper_defs,endian,tracing}.h
> >> how about adding all core macros into bpf_core_read.h ?
> > ok, but maybe just bpf_core.h then?
>
> bpf_core.h is too generic. It either needs to be capitalized,
> which is unheard of for header files or some suffix added.
> I think bpf_core_read.h is short enough and doesn't look like
> bpf_core_write.h will be coming any time soon.
> If you're worried about _read part then may be
> bpf_core_access.h ?
>
Alright, I'll split it off into bpf_core_read.h.
next prev parent reply other threads:[~2019-10-08 16:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 22:47 [PATCH v4 bpf-next 0/7] Move bpf_helpers and add BPF_CORE_READ macros Andrii Nakryiko
2019-10-07 22:47 ` [PATCH v4 bpf-next 1/7] selftests/bpf: undo GCC-specific bpf_helpers.h changes Andrii Nakryiko
2019-10-07 22:47 ` [PATCH v4 bpf-next 2/7] selftests/bpf: samples/bpf: split off legacy stuff from bpf_helpers.h Andrii Nakryiko
2019-10-07 22:47 ` [PATCH v4 bpf-next 3/7] selftests/bpf: adjust CO-RE reloc tests for new bpf_core_read() macro Andrii Nakryiko
2019-10-07 22:47 ` [PATCH v4 bpf-next 4/7] selftests/bpf: split off tracing-only helpers into bpf_tracing.h Andrii Nakryiko
2019-10-07 22:47 ` [PATCH v4 bpf-next 5/7] libbpf: move bpf_{helpers,helper_defs,endian,tracing}.h into libbpf Andrii Nakryiko
2019-10-07 22:47 ` [PATCH v4 bpf-next 6/7] libbpf: add BPF_CORE_READ/BPF_CORE_READ_INTO helpers Andrii Nakryiko
2019-10-08 4:56 ` Alexei Starovoitov
2019-10-08 6:15 ` Andrii Nakryiko
2019-10-08 15:10 ` Alexei Starovoitov
2019-10-08 16:53 ` Andrii Nakryiko [this message]
2019-10-07 22:47 ` [PATCH v4 bpf-next 7/7] selftests/bpf: add BPF_CORE_READ and BPF_CORE_READ_STR_INTO macro tests Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4Bza8d+O0dRZy5NkQbpA-Fnk32PhZK2wqJxJw=Ve9eYUwUA@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=Kernel-team@fb.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.