All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: John Fastabend <john.fastabend@gmail.com>
Cc: Neil Spring <ntspring@fb.com>, bpf <bpf@vger.kernel.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH bpf-next v3] bpf testing: permit ingress_ifindex in bpf_prog_test_run_xattr
Date: Tue, 7 Sep 2021 17:04:51 -0700	[thread overview]
Message-ID: <CAEf4Bza=-7FfG-EpuQhzJHShgpZ+VoH+eFWt6WOXAif4OEMeEA@mail.gmail.com> (raw)
In-Reply-To: <612f161528808_152fe2084d@john-XPS-13-9370.notmuch>

On Tue, Aug 31, 2021 at 10:56 PM John Fastabend
<john.fastabend@gmail.com> wrote:
>
> Neil Spring wrote:
> > bpf_prog_test_run_xattr takes a struct __sk_buff, but did not permit
> > that __skbuff to include an nonzero ingress_ifindex.
> >
> > This patch updates to allow ingress_ifindex, convert the __sk_buff field to
> > sk_buff (skb_iif) and back, and test that the value is present from
> > tested bpf.  The test sets an unlikely distinct value for ingress_ifindex
> > (11) from ifindex (1), but that seems in keeping with the rest of the
> > synthetic fields.
> >
> > Adding this support allows testing BPF that operates differently on
> > incoming and outgoing skbs by discriminating on this field.
> >
> > Signed-off-by: Neil Spring <ntspring@fb.com>
> > ---
>
> Acked-by: John Fastabend <john.fastabend@gmail.com>

Applied to bpf-next, thanks.

      reply	other threads:[~2021-09-08  0:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31  3:33 [PATCH bpf-next v3] bpf testing: permit ingress_ifindex in bpf_prog_test_run_xattr Neil Spring
2021-09-01  5:56 ` John Fastabend
2021-09-08  0:04   ` Andrii Nakryiko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEf4Bza=-7FfG-EpuQhzJHShgpZ+VoH+eFWt6WOXAif4OEMeEA@mail.gmail.com' \
    --to=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=john.fastabend@gmail.com \
    --cc=ntspring@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.