From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0188BC433F5 for ; Tue, 21 Sep 2021 21:27:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C809360E05 for ; Tue, 21 Sep 2021 21:27:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230497AbhIUV2p (ORCPT ); Tue, 21 Sep 2021 17:28:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234385AbhIUV2m (ORCPT ); Tue, 21 Sep 2021 17:28:42 -0400 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B86ACC061574 for ; Tue, 21 Sep 2021 14:27:13 -0700 (PDT) Received: by mail-qk1-x730.google.com with SMTP id c7so2418380qka.2 for ; Tue, 21 Sep 2021 14:27:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SAVCbPhVsGX5e4u6hHL5/jm9pyg5/28r4sgqWvbEmaQ=; b=SP9Thmvth7DITYdskWYHevqtQDETCMILc53imXOnQ6udTbYQ9fuwjUvHBRvpIevs3W 85U0P9znVV5go9dO4ZRm+CkZcg8Yrp4HA6JnwOQr/0yQ+mHLXvkAYV7KjFNhUNoVMTpg 4f5c55S8/SofgrUopQ/PG9Cp/uYMWysWUBRSKw72wS0weDxFPJmmSy/nhH3wjoB9SjJz Ev4/Vi8ld5lYUQ+oBkPZ5PkvLRD6dXPrUU7RaaEhc+2lvzdPyhiM+w+JRkv9+CsvqDaB NAPeq30AAWHXwg8TuE67VuTYha3jPF00WG24W06Ib/fiV9ZZcKh/7QRpoQj3wnIUdiEO hl/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SAVCbPhVsGX5e4u6hHL5/jm9pyg5/28r4sgqWvbEmaQ=; b=RdSDrWc7h0rOdcAvuCDmWbinka1+EH41V2Z13c1GUEJ8zXLZ7JnA119mtK0GMJLrEO WnQwac/6QV6UwiLxaJVPB75h/w7dMCCQv3QcZXkbCDgqz93vNJL3YLIGdmm+xaF30dga dER7nbdzp43lLdLATxzRj2r0f9qNcMWBdMsPIL7v13pMkUyr66oP/V0pZRBjHmu9N2dE oy4qDfDAho3Dg+WJwSXCTJwqHnjLyPOFmgDNWKC+L044wC/jfKBHvoiQUJkqJZXvwnXY R2n7tyrp9Yaj6TDaw0KWfUC3a0FpCOXezixwxWB8XFJ08KU49zlPt/ZdOgDWZM7ioQcy hu9A== X-Gm-Message-State: AOAM532Gewkm8xmuYzLnUMu2piBkMEqpPtv0f6K0Qv3fvPOW1WI6jhR1 3D7fqUE+onH2i0rcjvv6UqN4Jc/2kKsrkB/ELfY= X-Google-Smtp-Source: ABdhPJxsz2JTbMwYaNHpwqAeJnUYncBKqm3MNRHOdhJpFrhwVDJR9oanjCABcAzDY0VrypDxsPH3UPDyASl+nhkatmU= X-Received: by 2002:a05:6902:724:: with SMTP id l4mr37247422ybt.433.1632259632919; Tue, 21 Sep 2021 14:27:12 -0700 (PDT) MIME-Version: 1.0 References: <20210917215721.43491-1-alexei.starovoitov@gmail.com> <20210917215721.43491-3-alexei.starovoitov@gmail.com> In-Reply-To: <20210917215721.43491-3-alexei.starovoitov@gmail.com> From: Andrii Nakryiko Date: Tue, 21 Sep 2021 14:27:01 -0700 Message-ID: Subject: Re: [PATCH RFC bpf-next 02/10] bpf: Define enum bpf_core_relo_kind as uapi. To: Alexei Starovoitov Cc: "David S. Miller" , Daniel Borkmann , Andrii Nakryiko , john fastabend , Lorenz Bauer , mcroce@microsoft.com, bpf , Kernel Team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Fri, Sep 17, 2021 at 2:57 PM Alexei Starovoitov wrote: > > From: Alexei Starovoitov > > enum bpf_core_relo_kind is generated by llvm and processed by libbpf. > It's a de-facto uapi. > With CO-RE in the kernel the bpf_core_relo_kind values become uapi de-jure. > Also rename them with BPF_CORE_ prefix to distinguish from conflicting names in > bpf_core_read.h. The enums bpf_field_info_kind, bpf_type_id_kind, > bpf_type_info_kind, bpf_enum_value_kind are passing different values from bpf > program into llvm. > > Signed-off-by: Alexei Starovoitov > --- LGTM. Acked-by: Andrii Nakryiko > include/uapi/linux/bpf.h | 19 ++++++++ > tools/include/uapi/linux/bpf.h | 19 ++++++++ > tools/lib/bpf/libbpf.c | 2 +- > tools/lib/bpf/relo_core.c | 84 +++++++++++++++++----------------- > tools/lib/bpf/relo_core.h | 18 -------- > 5 files changed, 81 insertions(+), 61 deletions(-) > [...]