All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: Andrii Nakryiko <andrii@kernel.org>, bpf <bpf@vger.kernel.org>,
	Networking <netdev@vger.kernel.org>
Subject: Re: [PATCH bpf] libbpf: don't crash on object files with no symbol tables
Date: Tue, 31 Aug 2021 15:45:54 -0700	[thread overview]
Message-ID: <CAEf4BzaCukRbk=wBY=jobyCKDpQma-41gH34D=iigpj_AO6Hiw@mail.gmail.com> (raw)
In-Reply-To: <20210831165802.168776-1-toke@redhat.com>

On Tue, Aug 31, 2021 at 9:58 AM Toke Høiland-Jørgensen <toke@redhat.com> wrote:
>
> If libbpf encounters an ELF file that has been stripped of its symbol
> table, it will crash in bpf_object__add_programs() when trying to
> dereference the obj->efile.symbols pointer. Add a check and return to avoid
> this.
>
> Fixes: 6245947c1b3c ("libbpf: Allow gaps in BPF program sections to support overriden weak functions")
> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
> ---
>  tools/lib/bpf/libbpf.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index 6f5e2757bb3c..4cd102affeef 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -668,6 +668,9 @@ bpf_object__add_programs(struct bpf_object *obj, Elf_Data *sec_data,
>         const char *name;
>         GElf_Sym sym;
>
> +       if (!symbols)
> +               return -ENOENT;
> +

The more logical place to do this check is in
bpf_object__elf_collect(). Can you add this there? We can also include
helpful error message.

But I'm also curious which Clang version is being used to cause no ELF
symbols being generated?

>         progs = obj->programs;
>         nr_progs = obj->nr_programs;
>         nr_syms = symbols->d_size / sizeof(GElf_Sym);
> --
> 2.33.0
>

  reply	other threads:[~2021-08-31 22:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31 16:58 [PATCH bpf] libbpf: don't crash on object files with no symbol tables Toke Høiland-Jørgensen
2021-08-31 22:45 ` Andrii Nakryiko [this message]
2021-09-01 10:19   ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEf4BzaCukRbk=wBY=jobyCKDpQma-41gH34D=iigpj_AO6Hiw@mail.gmail.com' \
    --to=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=toke@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.