From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CADCC433E9 for ; Mon, 25 Jan 2021 23:53:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E58582223D for ; Mon, 25 Jan 2021 23:53:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727454AbhAYXxh (ORCPT ); Mon, 25 Jan 2021 18:53:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731500AbhAYXwD (ORCPT ); Mon, 25 Jan 2021 18:52:03 -0500 Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [IPv6:2607:f8b0:4864:20::b30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0F2DC06174A; Mon, 25 Jan 2021 15:51:21 -0800 (PST) Received: by mail-yb1-xb30.google.com with SMTP id e206so2782718ybh.13; Mon, 25 Jan 2021 15:51:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qZvwvmKLspAExS2kwmTTz9/DNwWIFqV/R4BI9mcKzX4=; b=tl5UpclauFBd1JetlUKe42cfMkBDF2Tg5NRIlicYWlOgaYAb62nk7yEdyR4/lSGwE2 eC9VKlfKrkqdj87OtXPOobJdB2u3N5umKsAIoU/Kk54tOzKzxa3fZYr6yCeRmQRQRwnJ 0UFN0W0/tI1l6XflhEpJLy50wVYCDAR8oS/zSRGhsuXBDZB/K+lBz7TKn9ikBhtXZnx8 429A4SBQXJI4M1QE+HgHmaJI/SbMeIteOJPINlOIGenQ90vadX/D1ofjotUiIkgQqcQp LipsIsZil6Ox1SRjJy7PGnsdK1JKdxm0EAiKPcOMpzdd8YdOxL3n7aGR9GoJ+toXRpUS 4QRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qZvwvmKLspAExS2kwmTTz9/DNwWIFqV/R4BI9mcKzX4=; b=ofRkm4KpF/hm4sU/zp6s7bqPuRkcXOXu98H8Ln7c1JKojDSutKTWu2MvukiPmiI+cd U4pGuFUki6ouet8/acETXmDXYcZWLIxDNwb/0C6cll3Ikc0EiFkUarohaEEmgufCYB1S lwEdIpQcSvwcCUS6AkwfmhscgHARoETf/rYcW1o11oEDQQmlSHIQqw2XelbUzPbgQpyE ElNVAUTwVOv26YlTlpzJmS6a4alIMn3yJUyEL5HHyQpYSSpnc2VokAYZkSSaVsiFQzMC XbEVHpyu7CpUR92/FKU+jAZuVBm/onjJTkgt2mLxM9rbF2mr6KzjkhODdzvLUT6zBeyi aquA== X-Gm-Message-State: AOAM5338dr6C/TubeTJMu8CMXHp07rCcaxKplf+WT6PNhJdEw3R2L17q NcrIrUjXc0VFjrw9x6a3v542HK3SNj00PxEg0mY= X-Google-Smtp-Source: ABdhPJzLwdlN8XUSoocavs0qXYzkNT5XHy9fhp0/ISEXKqAPRdPYbgN6b6ymo+swubUCoDaHVhOUPrZxKBWC5hiFURY= X-Received: by 2002:a25:ad91:: with SMTP id z17mr4671269ybi.260.1611618680667; Mon, 25 Jan 2021 15:51:20 -0800 (PST) MIME-Version: 1.0 References: <20210124221519.219750-1-jolsa@kernel.org> <20210124221519.219750-3-jolsa@kernel.org> In-Reply-To: <20210124221519.219750-3-jolsa@kernel.org> From: Andrii Nakryiko Date: Mon, 25 Jan 2021 15:51:08 -0800 Message-ID: Subject: Re: [PATCH 2/2] bpf_encoder: Translate SHN_XINDEX in symbol's st_shndx values To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , dwarves@vger.kernel.org, Networking , bpf , Yonghong Song , Hao Luo , Martin KaFai Lau , Song Liu , John Fastabend , KP Singh , Joe Lawrence , Mark Wielaard Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Sun, Jan 24, 2021 at 2:18 PM Jiri Olsa wrote: > > For very large ELF objects (with many sections), we could > get special value SHN_XINDEX (65535) for symbol's st_shndx. > > This patch is adding code to detect the optional extended > section index table and use it to resolve symbol's section > index. > > Adding elf_symtab__for_each_symbol_index macro that returns > symbol's section index and usign it in collect functions. > > Tested by running pahole on kernel compiled with: > make KCFLAGS="-ffunction-sections -fdata-sections" -j$(nproc) vmlinux > > and ensure FUNC records are generated and match normal > build (without above KCFLAGS). > > Also bpf selftest passed and generated kernel BTF, > is same as without the patch. > > Signed-off-by: Jiri Olsa > --- Acked-by: Andrii Nakryiko > btf_encoder.c | 33 +++++++++++++++++---------------- > elf_symtab.c | 41 +++++++++++++++++++++++++++++++++++++++-- > elf_symtab.h | 29 +++++++++++++++++++++++++++++ > 3 files changed, 85 insertions(+), 18 deletions(-) > [...]