From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 604B0C83000 for ; Wed, 29 Apr 2020 00:16:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A5B220737 for ; Wed, 29 Apr 2020 00:16:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QO5OIfa4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726353AbgD2AQH (ORCPT ); Tue, 28 Apr 2020 20:16:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726355AbgD2AQG (ORCPT ); Tue, 28 Apr 2020 20:16:06 -0400 Received: from mail-qv1-xf43.google.com (mail-qv1-xf43.google.com [IPv6:2607:f8b0:4864:20::f43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02210C03C1AC for ; Tue, 28 Apr 2020 17:16:06 -0700 (PDT) Received: by mail-qv1-xf43.google.com with SMTP id p13so294118qvt.12 for ; Tue, 28 Apr 2020 17:16:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QjcMVd62cBcBYuo19RjjPoO7o0XbAonG5SKrDKCtA1M=; b=QO5OIfa4ZqCrAt1z0eIBZqkXIf65B/SmL5u0Ks679Hu6BLtXKArYM8cz6y+EbF+SV9 pOlcpwjltm+Vbep5MjEUxeaPpIVgAzq5JmiSGpieUbLQoinAbPBO7i1fmuUSf5zuBngS n9BKrn/4vMLeYx3S9BbQwW3GePiNcVCy8XFgRL94wziLWzMtK6Y93HUH+xlRivRFeiJc 3VoXrJ3/QxI0XaYKZ50/xoNLrRprRCHP67jXMH2V7DkZ9pXipyqzkvpZDmWEF0RjtkV7 8stlFGTpUXDmUUM/N6zpXMji9eBacq7EXDrJlviBNlk2wKAJ2RPh4j+ShdesL4jMDpOa 0TjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QjcMVd62cBcBYuo19RjjPoO7o0XbAonG5SKrDKCtA1M=; b=FBWeQoeqQWZxIoP+MEeCpD2MVZHvHeAyHn0nq+D9+g24BXru81uugfSr5LQZyngeMT xwryId2qbboHIxcKOG0Cpl7JBBXK3tSeaeTnFpS5zSyaQLg2IdOUmO5hn6UZKKcZf3HO slHPTSQqN/TizlTwzgB3S8keoP7ueu2mWairosPbT6Y2usrBfABzrogQ6bmXIPdFaNxc 3HCJJbkKE0WfX6Ax60RlU6ieTTeeSPMkXj+chmE+i7y2B970QxmxYxSNN2ZHcRXnWITv XDM3SYDh0xB7cVjLSOr1o9DlsSSYpZrYvae75H2+Tx3qr9/uccgs3Jro81R9xJVNiKCw X/cg== X-Gm-Message-State: AGi0PuZ2Iz1sejFkv5L1hfq6GLtCJJ+XUAwzcAdiq+0hobbu8onUtCVi 16wp2UwgVNpNkoeI8YD//WtdFOOxay+9H86l0yE= X-Google-Smtp-Source: APiQypI4jreJ//CEGRbBF5uReLc79x4Ttxl4o8nH+uYWpJYA3GonowLXKWmk3pdKX9xuLjlTg7yqS1oqtf8r87F7FjI= X-Received: by 2002:a0c:fd8c:: with SMTP id p12mr31094520qvr.163.1588119364118; Tue, 28 Apr 2020 17:16:04 -0700 (PDT) MIME-Version: 1.0 References: <20200428173742.2988395-1-vkabatov@redhat.com> <8e07a2db-a258-f1b3-d1f4-74f131cbcb6d@iogearbox.net> In-Reply-To: <8e07a2db-a258-f1b3-d1f4-74f131cbcb6d@iogearbox.net> From: Andrii Nakryiko Date: Tue, 28 Apr 2020 17:15:53 -0700 Message-ID: Subject: Re: [PATCH v2] selftests/bpf: Copy runqslower to OUTPUT directory To: Daniel Borkmann Cc: Veronika Kabatova , bpf , Andrii Nakryiko , Jesper Dangaard Brouer Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, Apr 28, 2020 at 12:40 PM Daniel Borkmann wrote: > > On 4/28/20 8:57 PM, Andrii Nakryiko wrote: > > On Tue, Apr 28, 2020 at 10:38 AM Veronika Kabatova wrote: > >> > >> $(OUTPUT)/runqslower makefile target doesn't actually create runqslower > >> binary in the $(OUTPUT) directory. As lib.mk expects all > >> TEST_GEN_PROGS_EXTENDED (which runqslower is a part of) to be present in > >> the OUTPUT directory, this results in an error when running e.g. `make > >> install`: > >> > >> rsync: link_stat "tools/testing/selftests/bpf/runqslower" failed: No > >> such file or directory (2) > >> > >> Copy the binary into the OUTPUT directory after building it to fix the > >> error. > >> > >> Fixes: 3a0d3092a4ed ("selftests/bpf: Build runqslower from selftests") > >> Signed-off-by: Veronika Kabatova > >> --- > > > > Acked-by: Andrii Nakryiko > > Applied, thanks! Veronika, This change leaves runqslower laying around in selftests/bpf directory and available to be committed into git. Can you please follow up with adding runqslower to .gitignore? Thanks!