From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54FA9C2BB1D for ; Wed, 11 Mar 2020 18:48:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B95E206BE for ; Wed, 11 Mar 2020 18:48:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="spqbp/1s" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730784AbgCKSsP (ORCPT ); Wed, 11 Mar 2020 14:48:15 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:42745 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730780AbgCKSsP (ORCPT ); Wed, 11 Mar 2020 14:48:15 -0400 Received: by mail-qt1-f194.google.com with SMTP id g16so2365590qtp.9; Wed, 11 Mar 2020 11:48:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VL0/QIgFV/TQJg/uDW5O01TQ4UTQA+jR1k5TpH13mB0=; b=spqbp/1sEC2oBHy+lxErElsVMiMB1MEJW/sZH41FyLEwHwLqYp/8pfkrsApXXeOp6v Kds0GfHS0uESruvqWyf49XQI+D9xVr/MD1bVWXKFYaYHX0HeI4/s3EB5jKRKfrpdFGGW eDpcFhNMtlLyIaWXlzotdGQ/GOhWVib2OmzvqWWC7W7SzurXf9Z/tJbf+hmEipieJVOS X+9qZN4ouv3H7OAgmqdlCBRu3A1jpgzjRVnJK2xgYKrBY+71QlvGtAVML/lMCe4rAf4h 07Qpk4rQlnjnDAisA/O4KkglIR9XlaxwWSC4o+KBWfZIZZgY7JDkRTKGwitY4ED81Brh DHyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VL0/QIgFV/TQJg/uDW5O01TQ4UTQA+jR1k5TpH13mB0=; b=PrK/D9bFuHtHsreQjhG86Bg8PkLZ/qSSfJFL7Qf3rWCA9OEvA2Ooer/ToKEYx+WyLz RD3IdGH7UPAafkZz0fthjwrzpxVmy9dhyVzOsRnGRogPhdkvwOhTfe6qL8bzPYUvYfu8 Ei3F13YA2tWXOjcmIxKJr+DhA2JhC5RTpZN0CLBBtfyD8f+mqzMylo8rO8kVLGaybfLw UmCTL7FH/ZDR0TRLr6mHcFbA/rgWEHqQto3h/1T5q1ZQKa6zsiwKsbMbSWKrzEgDps52 YnrakS62TBjkWooXsoQYy/xWY5PtsCAuKqbHZfe1fm9k8ITXdDwSG+yakHAR6FJ6xC81 fNXg== X-Gm-Message-State: ANhLgQ2rIoy7nDWMAsB9fiLIEfzMr2vG8JUb5snhqxGeBOh+AElLM33i hDinZtNEmuRtteW7RKhwUyjrFOqoAdbGY3lv/VzFgsCu4jU= X-Google-Smtp-Source: ADFU+vv6HXIO1TBJYRYhd8up2V+wemkxMPiHwO7VlmKCb5zStnPkot/ror23Bb44iD+lFLaxWNPk47BW6qRuO+xTyS4= X-Received: by 2002:ac8:3f62:: with SMTP id w31mr3926845qtk.171.1583952494276; Wed, 11 Mar 2020 11:48:14 -0700 (PDT) MIME-Version: 1.0 References: <20200127125534.137492-1-jakub@cloudflare.com> <20200127125534.137492-13-jakub@cloudflare.com> In-Reply-To: <20200127125534.137492-13-jakub@cloudflare.com> From: Andrii Nakryiko Date: Wed, 11 Mar 2020 11:48:02 -0700 Message-ID: Subject: Re: [PATCH bpf-next v5 12/12] selftests/bpf: Tests for SOCKMAP holding listening sockets To: Jakub Sitnicki Cc: bpf , Networking , kernel-team@cloudflare.com Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Jan 27, 2020 at 4:58 AM Jakub Sitnicki wrote: > > Now that SOCKMAP can store listening sockets, user-space and BPF API is > open to a new set of potential pitfalls. Exercise the map operations (with > extra attention to code paths susceptible to races between map ops and > socket cloning), and BPF helpers that work with SOCKMAP to gain confidence > that all works as expected. > > Signed-off-by: Jakub Sitnicki > --- > .../selftests/bpf/prog_tests/sockmap_listen.c | 1455 +++++++++++++++++ > .../selftests/bpf/progs/test_sockmap_listen.c | 77 + > 2 files changed, 1532 insertions(+) > create mode 100644 tools/testing/selftests/bpf/prog_tests/sockmap_listen.c > create mode 100644 tools/testing/selftests/bpf/progs/test_sockmap_listen.c > Hey Jakub! I'm frequently getting spurious failures for sockmap_listen selftest. We also see that in libbpf's Github CI testing as well. Do you mind taking a look? Usually it's the following kinds of error: ./test_progs:connect_accept_thread:733: accept: Resource temporarily unavailable connect_accept_thread:FAIL:733 Thanks!