All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Martin Kelly <martin.kelly@crowdstrike.com>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
	Alexei Starovoitov <ast@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"kernel-team@fb.com" <kernel-team@fb.com>,
	"David S. Miller" <davem@davemloft.net>,
	Andrii Nakryiko <andrii@kernel.org>
Subject: Re: Clarification on bpftool dual licensing
Date: Tue, 16 Nov 2021 14:00:19 -0800	[thread overview]
Message-ID: <CAEf4BzaheW1EGczxS8zXmObBte81gR7pepa9cLi8Z=UvwJdnrg@mail.gmail.com> (raw)
In-Reply-To: <0b80c79b-de0c-931c-262d-4da6e2add9f9@iogearbox.net>

On Tue, Nov 16, 2021 at 2:16 AM Daniel Borkmann <daniel@iogearbox.net> wrote:
>
> On 11/15/21 7:20 PM, Martin Kelly wrote:
> > Hi,
> >
> > I have a question regarding the dual licensing provision of bpftool. I
> > understand that bpftool can be distributed as either GPL 2.0 or BSD 2-clause.
> > That said, bpftool can also auto-generate BPF code that gets specified inline
> > in the skeleton header file, and it's possible that the BPF code generated is
> > GPL. What I'm wondering is what happens if bpftool generates GPL-licensed BPF
> > code inside the skeleton header, so that you get a header like this:
> >
> > something.skel.h:
> > /* this file is BSD 2-clause, by nature of dual licensing */
>
> Fwiw, the generated header contains an SPDX identifier:
>
>   /* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */
>   /* THIS FILE IS AUTOGENERATED! */
>
> > /* THIS FILE IS AUTOGENERATED! */
> >
> > /* standard skeleton definitions */
> >
> > ...
> >
> > s->data_sz = XXX;
> > s->data = (void *)"\
> > <eBPF bytecode, produced by GPL 2.0 sources, specified in binary>
> > ";
> >
> > My guess is that, based on the choice to dual-license bpftool, the header is
> > meant to still be BSD 2-clause, and the s->data inline code's GPL license is
> > not meant to change the licensing of the header itself, but I wanted to

Yes, definitely that is the intent (but not a lawyer either).


> > double-check, especially as I am not a lawyer. If this is indeed the intent,
> > is there any opposition to a patch clarifying this more explicitly in
> > Documentation/bpf/bpf_licensing.rst?
>
> Not a lawyer either, but my interpretation is that this point related to "packaging"
> of BPF programs from the bpf_licensing.rst would apply here (given this is what it
> does after all):
>
>    Packaging BPF programs with user space applications
>    ===================================================
>
>    Generally, proprietary-licensed applications and GPL licensed BPF programs
>    written for the Linux kernel in the same package can co-exist because they are
>    separate executable processes. This applies to both cBPF and eBPF programs.

Yep. If someone packages proprietary BPF ELF into a skeleton, that
doesn't make the BPF ELF suddenly GPL or BSD, I'd imagine.

      reply	other threads:[~2021-11-16 22:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-15 18:20 Clarification on bpftool dual licensing Martin Kelly
2021-11-16 10:16 ` Daniel Borkmann
2021-11-16 22:00   ` Andrii Nakryiko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEf4BzaheW1EGczxS8zXmObBte81gR7pepa9cLi8Z=UvwJdnrg@mail.gmail.com' \
    --to=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=kernel-team@fb.com \
    --cc=martin.kelly@crowdstrike.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.