From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Kui-Feng Lee <kuifeng@fb.com>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH bpf-next v7 2/5] bpf, x86: Create bpf_tramp_run_ctx on the caller thread's stack
Date: Mon, 9 May 2022 11:54:12 -0700 [thread overview]
Message-ID: <CAEf4Bzb6xwtu4T3Na75V9tTfxUZuD4LE_--ajqDFHyGSennxRw@mail.gmail.com> (raw)
In-Reply-To: <20220508032117.2783209-3-kuifeng@fb.com>
On Sat, May 7, 2022 at 8:21 PM Kui-Feng Lee <kuifeng@fb.com> wrote:
>
> BPF trampolines will create a bpf_tramp_run_ctx, a bpf_run_ctx, on
> stacks and set/reset the current bpf_run_ctx before/after calling a
> bpf_prog.
>
> Signed-off-by: Kui-Feng Lee <kuifeng@fb.com>
> ---
Please preserve received Acked-by/Reviewed-by/etc tags that you got on
previous iterations, unless you feel like you did some major changes
that might invalidate reviewer's "approval".
Still looks good to me:
Acked-by: Andrii Nakryiko <andrii@kernel.org>
> arch/x86/net/bpf_jit_comp.c | 38 +++++++++++++++++++++++++++++++++++++
> include/linux/bpf.h | 17 +++++++++++++----
> kernel/bpf/syscall.c | 7 +++++--
> kernel/bpf/trampoline.c | 20 +++++++++++++++----
> 4 files changed, 72 insertions(+), 10 deletions(-)
>
[...]
next prev parent reply other threads:[~2022-05-09 18:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-08 3:21 [PATCH bpf-next v7 0/5] Attach a cookie to a tracing program Kui-Feng Lee
2022-05-08 3:21 ` [PATCH bpf-next v7 1/5] bpf, x86: Generate trampolines from bpf_tramp_links Kui-Feng Lee
2022-05-09 18:54 ` Andrii Nakryiko
2022-05-10 16:50 ` Kui-Feng Lee
2022-05-08 3:21 ` [PATCH bpf-next v7 2/5] bpf, x86: Create bpf_tramp_run_ctx on the caller thread's stack Kui-Feng Lee
2022-05-09 18:54 ` Andrii Nakryiko [this message]
2022-05-09 21:04 ` Alexei Starovoitov
2022-05-10 1:29 ` Kui-Feng Lee
2022-05-10 1:43 ` Kui-Feng Lee
2022-05-10 2:11 ` Alexei Starovoitov
2022-05-08 3:21 ` [PATCH bpf-next v7 3/5] bpf, x86: Attach a cookie to fentry/fexit/fmod_ret/lsm Kui-Feng Lee
2022-05-09 18:58 ` Andrii Nakryiko
2022-05-10 16:44 ` Kui-Feng Lee
2022-05-10 18:44 ` Andrii Nakryiko
2022-05-08 3:21 ` [PATCH bpf-next v7 4/5] libbpf: Assign cookies to links in libbpf Kui-Feng Lee
2022-05-09 19:05 ` Andrii Nakryiko
2022-05-10 17:23 ` Kui-Feng Lee
2022-05-08 3:21 ` [PATCH bpf-next v7 5/5] selftest/bpf: The test cses of BPF cookie for fentry/fexit/fmod_ret/lsm Kui-Feng Lee
2022-05-09 19:08 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4Bzb6xwtu4T3Na75V9tTfxUZuD4LE_--ajqDFHyGSennxRw@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=kuifeng@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.