All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Dave Marchevsky <davemarchevsky@fb.com>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>, Yonghong Song <yhs@fb.com>,
	Networking <netdev@vger.kernel.org>
Subject: Re: [PATCH v4 bpf-next 9/9] selftests/bpf: Add test for bpf_printk w/ 0 fmt args
Date: Thu, 2 Sep 2021 16:14:29 -0700	[thread overview]
Message-ID: <CAEf4Bzb8BgSpKRysgX1uCcTfjd7ZmtTPkHB0H6ufAsJMe8MKvQ@mail.gmail.com> (raw)
In-Reply-To: <20210902171929.3922667-10-davemarchevsky@fb.com>

On Thu, Sep 2, 2021 at 10:23 AM Dave Marchevsky <davemarchevsky@fb.com> wrote:
>
> This corner case isn't covered by existing selftests' use of bpf_printk.
>
> Just test compilation, not output, as trace_vprintk already tests
> trace_pipe output.
>
> Signed-off-by: Dave Marchevsky <davemarchevsky@fb.com>
> ---
>  tools/testing/selftests/bpf/progs/trace_vprintk.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/tools/testing/selftests/bpf/progs/trace_vprintk.c b/tools/testing/selftests/bpf/progs/trace_vprintk.c
> index 255e2f018efe..33455e48a9ab 100644
> --- a/tools/testing/selftests/bpf/progs/trace_vprintk.c
> +++ b/tools/testing/selftests/bpf/progs/trace_vprintk.c
> @@ -23,3 +23,10 @@ int sys_enter(void *ctx)
>                 one, 2, three, 4, five, 6, seven, 8, nine, 10, ++trace_vprintk_ran);
>         return 0;
>  }
> +
> +SEC("fentry/__x64_sys_nanosleep")
> +int zero_fmt_args(void *ctx)
> +{
> +       bpf_printk("\t"); // runner doesn't search for this, just ensure it compiles

C++ comments :( please use /* */

I'd probably just add this bpf_printk() in the same BPF program above
and roll it into previous patch. Doesn't seem like we need dedicated
BPF program just for this.


> +       return 0;
> +}
> --
> 2.30.2
>

      reply	other threads:[~2021-09-02 23:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02 17:19 [PATCH v4 bpf-next 0/9] bpf: implement variadic printk helper Dave Marchevsky
2021-09-02 17:19 ` [PATCH v4 bpf-next 1/9] bpf: merge printk and seq_printf VARARG max macros Dave Marchevsky
2021-09-02 17:19 ` [PATCH v4 bpf-next 2/9] selftests/bpf: stop using bpf_program__load Dave Marchevsky
2021-09-02 22:58   ` Andrii Nakryiko
2021-09-02 17:19 ` [PATCH v4 bpf-next 3/9] bpf: add bpf_trace_vprintk helper Dave Marchevsky
2021-09-02 17:19 ` [PATCH v4 bpf-next 4/9] libbpf: Modify bpf_printk to choose helper based on arg count Dave Marchevsky
2021-09-02 23:08   ` Andrii Nakryiko
2021-09-02 17:19 ` [PATCH v4 bpf-next 5/9] libbpf: use static const fmt string in __bpf_printk Dave Marchevsky
2021-09-02 23:09   ` Andrii Nakryiko
2021-09-02 17:19 ` [PATCH v4 bpf-next 6/9] bpftool: only probe trace_vprintk feature in 'full' mode Dave Marchevsky
2021-09-02 23:10   ` Andrii Nakryiko
2021-09-02 17:19 ` [PATCH v4 bpf-next 7/9] selftests/bpf: Migrate prog_tests/trace_printk CHECKs to ASSERTs Dave Marchevsky
2021-09-02 17:19 ` [PATCH v4 bpf-next 8/9] selftests/bpf: add trace_vprintk test prog Dave Marchevsky
2021-09-02 23:13   ` Andrii Nakryiko
2021-09-02 17:19 ` [PATCH v4 bpf-next 9/9] selftests/bpf: Add test for bpf_printk w/ 0 fmt args Dave Marchevsky
2021-09-02 23:14   ` Andrii Nakryiko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEf4Bzb8BgSpKRysgX1uCcTfjd7ZmtTPkHB0H6ufAsJMe8MKvQ@mail.gmail.com \
    --to=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davemarchevsky@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.