From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Andrii Nakryiko <andrii@kernel.org>, bpf <bpf@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Team <kernel-team@fb.com>,
Luka Perkov <luka.perkov@sartura.hr>,
Tony Ambardar <tony.ambardar@gmail.com>,
Andrii Nakryiko <andriin@fb.com>
Subject: Re: [PATCH v2 bpf-next 4/4] selftests/bpf: validate libbpf's auto-sizing of LD/ST/STX instructions
Date: Wed, 7 Oct 2020 16:33:54 -0700 [thread overview]
Message-ID: <CAEf4BzbHQ__QtEjCssXqE-uHCAmTvQHRB4gOYC2-8Up5_s7B8g@mail.gmail.com> (raw)
In-Reply-To: <20201007232957.nrmqryypzc44rqcd@ast-mbp>
On Wed, Oct 7, 2020 at 4:30 PM Alexei Starovoitov
<alexei.starovoitov@gmail.com> wrote:
>
> On Wed, Oct 07, 2020 at 01:29:46PM -0700, Andrii Nakryiko wrote:
> > diff --git a/tools/testing/selftests/bpf/progs/test_core_autosize.c b/tools/testing/selftests/bpf/progs/test_core_autosize.c
> > new file mode 100644
> > index 000000000000..e999f2e2ea22
> > --- /dev/null
> > +++ b/tools/testing/selftests/bpf/progs/test_core_autosize.c
> > @@ -0,0 +1,172 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +// Copyright (c) 2019 Facebook
>
> The year is wrong.
> Also Copyright should be in /* */
> The // exception is only for SPDX and only in .c
> .h should have both in /* */
argh, copy/paste from test_core_reloc.c
We have plenty of those '//' vs '/* */' issues with SPDX and
Copyrights in selftests. Might be a good idea to finally fix all that.
prev parent reply other threads:[~2020-10-07 23:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 20:29 [PATCH v2 bpf-next 0/4] libbpf: auto-resize relocatable LOAD/STORE instructions Andrii Nakryiko
2020-10-07 20:29 ` [PATCH v2 bpf-next 1/4] libbpf: skip CO-RE relocations for not loaded BPF programs Andrii Nakryiko
2020-10-07 20:29 ` [PATCH v2 bpf-next 2/4] libbpf: support safe subset of load/store instruction resizing with CO-RE Andrii Nakryiko
2020-10-07 20:29 ` [PATCH v2 bpf-next 3/4] libbpf: allow specifying both ELF and raw BTF for CO-RE BTF override Andrii Nakryiko
2020-10-07 20:29 ` [PATCH v2 bpf-next 4/4] selftests/bpf: validate libbpf's auto-sizing of LD/ST/STX instructions Andrii Nakryiko
2020-10-07 23:29 ` Alexei Starovoitov
2020-10-07 23:33 ` Andrii Nakryiko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzbHQ__QtEjCssXqE-uHCAmTvQHRB4gOYC2-8Up5_s7B8g@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=luka.perkov@sartura.hr \
--cc=netdev@vger.kernel.org \
--cc=tony.ambardar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.