All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Andrii Nakryiko <andriin@fb.com>, Alexei Starovoitov <ast@fb.com>,
	Yonghong Song <yhs@fb.com>,
	dwarves@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH pahole] pahole: use 32-bit integers for iterations within CU
Date: Fri, 8 Mar 2019 11:39:57 -0800	[thread overview]
Message-ID: <CAEf4BzbLkwhCSb1i3cGJJh=OJ-_+53Q+hnqhqp96+fmj9B6aLg@mail.gmail.com> (raw)
In-Reply-To: <20190307140917.GW13100@kernel.org>

On Thu, Mar 7, 2019 at 6:09 AM Arnaldo Carvalho de Melo
<arnaldo.melo@gmail.com> wrote:
>
> Em Thu, Mar 07, 2019 at 11:02:47AM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Wed, Mar 06, 2019 at 04:23:21PM -0800, Andrii Nakryiko escreveu:
> > > Due to this assumption, libdwarves and other parts of pahole are using 16-bit
> > > counters to iterate over entities within CU. This can cause infinite loop when
> > > iterating BTF data, if there are more than 65535 types. This patch changes
> > > non-public variables to use 32-bit integers, where appropriate.
>
> > Ok, there are some bits that are unrelated, I'm comment on it and remove
> > before applying.

Yeah, thanks for cleaning this up! My intent was to convert all places
where we rely on uint16_t for things that potentially can overflow (so
not just IDs) and are safe to change without binary compatibility
issues. I didn't intend this to cause you more work, sorry about that.

>
> Ooops, see below, I'm removing the non-type related parts, and will look
> at changing the types till btfdiff with that allyesconfig aarch64
> vmlinux image shows no diffs.
>
> - Arnaldo

<snip>

  parent reply	other threads:[~2019-03-08 19:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-07  0:23 [PATCH pahole] pahole: use 32-bit integers for iterations within CU Andrii Nakryiko
2019-03-07 14:02 ` Arnaldo Carvalho de Melo
2019-03-07 14:09   ` Arnaldo Carvalho de Melo
2019-03-07 14:11     ` Arnaldo Carvalho de Melo
2019-03-08 19:39     ` Andrii Nakryiko [this message]
2019-03-08  0:26   ` Arnaldo Carvalho de Melo
2019-03-08 18:45     ` Arnaldo Carvalho de Melo
2019-03-08 19:42       ` Andrii Nakryiko
2019-03-11  4:31         ` Andrii Nakryiko
2019-03-11 14:53           ` Arnaldo Carvalho de Melo
2019-03-11 16:39             ` Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEf4BzbLkwhCSb1i3cGJJh=OJ-_+53Q+hnqhqp96+fmj9B6aLg@mail.gmail.com' \
    --to=andrii.nakryiko@gmail.com \
    --cc=andriin@fb.com \
    --cc=arnaldo.melo@gmail.com \
    --cc=ast@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=dwarves@vger.kernel.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.