From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C48402F26 for ; Wed, 2 Feb 2022 07:05:25 +0000 (UTC) Received: by mail-io1-f52.google.com with SMTP id z199so24243609iof.10 for ; Tue, 01 Feb 2022 23:05:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SpryQOT2uTRwsdibcfsESI84DVoBT/VezHdCUqIw1nM=; b=Yh8JER6t2u+rs0xm1gDMhpppjo8c55JDcz4lc1HhglDS5vddc25oWSMVv5dafoq2tL X0EqeQ14PSrUBuQkDiKHBefLoTCrIPMhBcMLC4RBUJhmE816dG1uZB9z3Sk6BbJklR3D Y6a17cBDceerLRMxU8JtWsbkJrqxlp3m1OZNOmBvDWxdv1i3Z4SOTXFxfqYAnKryxNoS Fhjl60AsaagVaNs1saZNbjsF9Vh7z04r7CWdRI6Fo4GCYvqXXp2ewZeDC79N66/yVUo6 LsUtUpHgRc6Rdk5tsGhSvgH2C2oCIAVi7+2HyASUyd7UtuupMDN9XfJnLBhHxs3Doeed rmlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SpryQOT2uTRwsdibcfsESI84DVoBT/VezHdCUqIw1nM=; b=4O8aW753ZDtIE5OAXe33fs8BLIA+8KLXuULykEwRc3oWA5U8hM3J7MdLVVaZlT2hqi nUuWkRM+ITWvc34cmVtBo2uPe6a6oQ4VjDq/ekDy0Jg+Sf4q+CNQsp6Bpz7CX0C88ZYY MpD+9Ut2rLV+QvwlBkfzf9SvhMHDjf2/S2fUxTRL0BeYYqdvsuXDFgBsCp276uHMUnqs 9xlmt/JPLcCep5YXtiq56DlE+Sii11VqWPC1SCyGAf5Ua8WLB/1ZBU0bJu2uAqgdEZ8P 8H1gmaOQYi0jg6pfBI6UpIb7N+cjTKPAEM0B8wt6CFWDngWatWWXrBoSK2Pf45r+BGoo 6Ixw== X-Gm-Message-State: AOAM533Y3fWmd6VrzLC55XHbv0AjbFy7wGb58Fos/wzZbtHbLfM5zv9M How+waVVlM6DfL78NksyK9n8mQD3psSnoTdQ/UY= X-Google-Smtp-Source: ABdhPJyR0STyeIw70QHeReGkVxZkBvrSHZI1p+33uA5B2bkuVWZRQTmlR4YBRQ37MslJVt1AuMhh4dGDaT+Tp8C9mTQ= X-Received: by 2002:a02:2422:: with SMTP id f34mr14962916jaa.237.1643785524885; Tue, 01 Feb 2022 23:05:24 -0800 (PST) Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20220201205624.652313-1-nathan@kernel.org> In-Reply-To: <20220201205624.652313-1-nathan@kernel.org> From: Andrii Nakryiko Date: Tue, 1 Feb 2022 23:05:13 -0800 Message-ID: Subject: Re: [PATCH bpf-next 0/5] Allow CONFIG_DEBUG_INFO_DWARF5=y + CONFIG_DEBUG_INFO_BTF=y To: Nathan Chancellor Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Nick Desaulniers , Networking , bpf , open list , llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" On Tue, Feb 1, 2022 at 12:56 PM Nathan Chancellor wrote: > > Hi all, > > This series allows CONFIG_DEBUG_INFO_DWARF5 to be selected with > CONFIG_DEBUG_INFO_BTF=y by checking the pahole version. > > The first four patches add CONFIG_PAHOLE_VERSION and > scripts/pahole-version.sh to clean up all the places that pahole's > version is transformed into a 3-digit form. > > The fourth patch adds a PAHOLE_VERSION dependency to DEBUG_INFO_DWARF5 > so that there are no build errors when it is selected with > DEBUG_INFO_BTF. > > I build tested Fedora's aarch64 and x86_64 config with ToT clang 14.0.0 > and GCC 11 with CONFIG_DEBUG_INFO_DWARF5 enabled with both pahole 1.21 > and 1.23. > > Nathan Chancellor (5): > MAINTAINERS: Add scripts/pahole-flags.sh to BPF section > kbuild: Add CONFIG_PAHOLE_VERSION > scripts/pahole-flags.sh: Use pahole-version.sh > lib/Kconfig.debug: Use CONFIG_PAHOLE_VERSION > lib/Kconfig.debug: Allow BTF + DWARF5 with pahole 1.21+ > LGTM. I'd probably combine patches 2 and 3, but it's minor. I really like the CONFIG_PAHOLE_VERSION and how much cleaner it makes Kconfig options. Acked-by: Andrii Nakryiko > MAINTAINERS | 2 ++ > init/Kconfig | 4 ++++ > lib/Kconfig.debug | 6 +++--- > scripts/pahole-flags.sh | 2 +- > scripts/pahole-version.sh | 13 +++++++++++++ > 5 files changed, 23 insertions(+), 4 deletions(-) > create mode 100755 scripts/pahole-version.sh > > > base-commit: 533de4aea6a91eb670ff8ff2b082bb34f2c5d6ab > -- > 2.35.1 >